<p>Joshua Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/6596">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjproject: Patch to correct STUN FINGERPRINT usage<br><br>Change-Id: I0e453253dff1388b0186b36c754457c1d0d12db6<br>---<br>A third-party/pjproject/patches/0080-STUN-Fingerprint-with-ICE.patch<br>1 file changed, 35 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/third-party/pjproject/patches/0080-STUN-Fingerprint-with-ICE.patch b/third-party/pjproject/patches/0080-STUN-Fingerprint-with-ICE.patch<br>new file mode 100644<br>index 0000000..96d44fa<br>--- /dev/null<br>+++ b/third-party/pjproject/patches/0080-STUN-Fingerprint-with-ICE.patch<br>@@ -0,0 +1,35 @@<br>+From 28490e9ddee0937516f9edcaf95d274fe5ceaf4c Mon Sep 17 00:00:00 2001<br>+From: Sean Bright <sean.bright@gmail.com><br>+Date: Mon, 25 Sep 2017 14:06:53 -0400<br>+Subject: [PATCH] ICE: Use STUN FINGERPRINT attribute when sending keepalives<br>+<br>+Per RFC 5245 Section 10:<br>+<br>+   If STUN is being used for keepalives, a STUN Binding Indication is<br>+   used [RFC5389].  The Indication MUST NOT utilize any authentication<br>+   mechanism.  It SHOULD contain the FINGERPRINT attribute to aid in<br>+   demultiplexing, but SHOULD NOT contain any other attributes.<br>+---<br>+ pjnath/src/pjnath/ice_session.c | 6 ++----<br>+ 1 file changed, 2 insertions(+), 4 deletions(-)<br>+<br>+diff --git a/pjnath/src/pjnath/ice_session.c b/pjnath/src/pjnath/ice_session.c<br>+index 159d7b1..f90005a 100644<br>+--- a/pjnath/src/pjnath/ice_session.c<br>++++ b/pjnath/src/pjnath/ice_session.c<br>+@@ -1217,10 +1217,8 @@ static void ice_keep_alive(pj_ice_sess *ice, pj_bool_t send_now)<br>+       msg_data = PJ_POOL_ZALLOC_T(tdata->pool, pj_ice_msg_data);<br>+        msg_data->transport_id = the_check->lcand->transport_id;<br>+ <br>+-       /* Temporarily disable FINGERPRINT. The Binding Indication <br>+-  * SHOULD NOT contain any attributes.<br>+-        */<br>+- saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_FALSE);<br>++      /* Make sure that the FINGERPRINT attribute is used per RFC 5245 Section 10 */<br>++      saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_TRUE);<br>+ <br>+    /* Send to session */<br>+        addr_len = pj_sockaddr_get_len(&the_check->rcand->addr);<br>+-- <br>+2.7.4<br>+<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/6596">change 6596</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6596"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 14 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0e453253dff1388b0186b36c754457c1d0d12db6 </div>
<div style="display:none"> Gerrit-Change-Number: 6596 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>