<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/5879">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Matthew Fredrickson: Looks good to me, but someone else must approve
Sean Bright: Looks good to me, approved
Jenkins2: Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pjsip: Correct attribute passthrough tests.<br><br>While testing multistream support in PJSIP it uncovered<br>a few issues with the attribute passthrough tests.<br><br>The speex test was not configured to accept both ulaw<br>and speex. As a result in multistream a reinvite occurred<br>for the calling leg to switch it to only speex. This change<br>makes both ulaw and speex accepted so that no reinvite occurs.<br><br>The h263 and h264 tests did not answer their INVITEs with<br>valid SDP. They answered with only a single video stream<br>when they should answer with both an audio and video. In<br>multistream this caused the calling leg to get a reinvite<br>declining the audio stream. PJSIP helps in this area by<br>correcting the received SDP so it is proper.<br><br>Change-Id: I966e7c53831e0ba925e3c8fc500953b9c46a4b1b<br>---<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml<br>M tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml<br>3 files changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf<br>index f4f304f..6b9089d 100644<br>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf<br>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/configs/ast1/pjsip.conf<br>@@ -45,6 +45,7 @@<br> type=peer<br> aors=phoneB-speex<br> disallow=all<br>+allow=ulaw<br> allow=speex<br> <br> [phoneB-speex]<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml<br>index a132490..311d1f7 100644<br>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml<br>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h263.xml<br>@@ -56,6 +56,8 @@<br> s=-<br> c=IN IP[media_ip_type] [media_ip]<br> t=0 0<br>+ m=audio 6000 RTP/AVP 0<br>+ a=rtpmap:0 PCMU/8000<br> m=video 6002 RTP/AVP 34<br> a=rtpmap:34 H263/90000<br> a=fmtp:34 SQCIF=1;QCIF=1;CIF=1;CIF4=1;CIF16=1;F=1;I=1;J=1;T=1;K=1;N=1;PAR=255:255;BPP=65535;HRD=1<br>diff --git a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml<br>index 0efece2..5af8629 100644<br>--- a/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml<br>+++ b/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/speex_h263_h264/sipp/phone_B_h264.xml<br>@@ -56,6 +56,8 @@<br> s=-<br> c=IN IP[media_ip_type] [media_ip]<br> t=0 0<br>+ m=audio 6000 RTP/AVP 0<br>+ a=rtpmap:0 PCMU/8000<br> m=video 6002 RTP/AVP 99<br> a=rtpmap:99 H264/90000<br> a=fmtp:99 profile-level-id=42801e;packetization-mode=1;max-mbps=48600<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/5879">change 5879</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5879"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I966e7c53831e0ba925e3c8fc500953b9c46a4b1b </div>
<div style="display:none"> Gerrit-Change-Number: 5879 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>