[asterisk-commits] testsuite: Fix test because original issue was not a bug. (testsuite[master])

[SVN commits to the Asterisk project]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5633 )

Change subject: testsuite: Fix test because original issue was not a bug.
......................................................................


testsuite: Fix test because original issue was not a bug.

The original issue was not a bug because the SIPp scenario messages were
invalid.

* Fix the SIPp scenario messages to send valid SIP messages to decline the
media stream in the deferred SDP eschange.

ASTERISK-24410

Change-Id: I1bedb08a6d2786c241f7c3c416a4b9e4fb064143
---
M tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/sipp/uac-declined-delayed.xml
M tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/test-config.yaml
2 files changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Jenkins2: Approved for Submit
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/sipp/uac-declined-delayed.xml b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/sipp/uac-declined-delayed.xml
index d03b833..2fa6e29 100644
--- a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/sipp/uac-declined-delayed.xml
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/sipp/uac-declined-delayed.xml
@@ -14,7 +14,6 @@
       Contact: sip:test@[local_ip]:[local_port]
       Max-Forwards: 70
       Subject: Codec test
-      Content-Type: application/sdp
       Content-Length: 0
 
     ]]>
@@ -52,6 +51,7 @@
       Contact: sip:alice-codec-match@[local_ip]:[local_port]
       Max-Forwards: 70
       Subject: Performance Test
+      Content-Type: application/sdp
       Content-Length: [len]
 
       v=0
diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/test-config.yaml
index 64e8fdb..6c7ff83 100644
--- a/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/test-config.yaml
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/off-nominal/single-media-stream/audio/initial-declined/test-config.yaml
@@ -10,10 +10,6 @@
           audio stream in the ACK. This should cause the channel to
           be immediately hung up.
 
-# Note: The second scenario is currently disabled. This is due
-# to ASTERISK-24410. When that issue is resolved, this scenario
-# should be enabled.
-
 test-modules:
     test-object:
         config-section: test-object-config
@@ -26,7 +22,7 @@
         -
             scenarios:
                 - { 'key-args': {'scenario': 'uac-declined.xml', '-i': '127.0.0.1', '-p': '5062', '-s': 'alice', } }
-#                - { 'key-args': {'scenario': 'uac-declined-delayed.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice', } }
+                - { 'key-args': {'scenario': 'uac-declined-delayed.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice', } }
 
 
 properties:

-- 
To view, visit https://gerrit.asterisk.org/5633
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bedb08a6d2786c241f7c3c416a4b9e4fb064143
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>