[asterisk-commits] srtp: Remove test for zero tag. (testsuite[master])

[SVN commits to the Asterisk project]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5364 )

Change subject: srtp: Remove test for zero tag.
......................................................................


srtp: Remove test for zero tag.

For better compatibility with phones we allow a
tag of zero to occur.

ASTERISK-25490

Change-Id: I27c4debd5c5080fe1955e6f511dd7718fd07a3a7
---
M tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
M tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml
M tests/channels/pjsip/srtp_negotiation/sipp/decline.csv
M tests/channels/pjsip/srtp_negotiation/test-config.yaml
4 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Sean Bright: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
index 4136b9a..2d1d523 100644
--- a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
+++ b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
@@ -1,7 +1,6 @@
 SEQUENTIAL
 ;
 1;
-0 AES_CM_128_HMAC_SHA1_80 inline:qtoB12WnTe19t8vuhcJVRFmoeHhHyF9tcu/4bAkS;
 AES_CM_128_HMAC_SHA1_80 inline:WbTBosdVUZqEb6Htqhn+m3z7wUh4RJVR8nE15GbN;
 FOO AES_CM_128_HMAC_SHA1_80 inline:WbTBosdVUZqEb6Htqhn+m3z7wUh4RJVR8nE15GbN;
 100000000000 AES_CM_128_HMAC_SHA1_80 inline:qtoB12WnTe19t8vuhcJVRFmoeHhHyF9tcu/4bAkS;
diff --git a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml
index 669b57b..6e0b6a2 100644
--- a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml
+++ b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml
@@ -24,7 +24,6 @@
         * srtp-invite-off-nominal-crypto:
           - verify declining an empty crypto attribute
           - verify declining only a tag
-          - verify declining an invalid tag (0)
           - verify declining an attribute with no tag
           - verify declining a non-integer tag (FOO)
           - verify declining an invalid tag (100000000000)
diff --git a/tests/channels/pjsip/srtp_negotiation/sipp/decline.csv b/tests/channels/pjsip/srtp_negotiation/sipp/decline.csv
index 4136b9a..2d1d523 100644
--- a/tests/channels/pjsip/srtp_negotiation/sipp/decline.csv
+++ b/tests/channels/pjsip/srtp_negotiation/sipp/decline.csv
@@ -1,7 +1,6 @@
 SEQUENTIAL
 ;
 1;
-0 AES_CM_128_HMAC_SHA1_80 inline:qtoB12WnTe19t8vuhcJVRFmoeHhHyF9tcu/4bAkS;
 AES_CM_128_HMAC_SHA1_80 inline:WbTBosdVUZqEb6Htqhn+m3z7wUh4RJVR8nE15GbN;
 FOO AES_CM_128_HMAC_SHA1_80 inline:WbTBosdVUZqEb6Htqhn+m3z7wUh4RJVR8nE15GbN;
 100000000000 AES_CM_128_HMAC_SHA1_80 inline:qtoB12WnTe19t8vuhcJVRFmoeHhHyF9tcu/4bAkS;
diff --git a/tests/channels/pjsip/srtp_negotiation/test-config.yaml b/tests/channels/pjsip/srtp_negotiation/test-config.yaml
index 77797b0..2d77788 100644
--- a/tests/channels/pjsip/srtp_negotiation/test-config.yaml
+++ b/tests/channels/pjsip/srtp_negotiation/test-config.yaml
@@ -15,7 +15,6 @@
          * off-nominal calls
            - verify declining an empty crypto attribute
            - verify declining only a tag
-           - verify declining an invalid tag (0)
            - verify declining an attribute with no tag
            - verify declining a non-integer tag (FOO)
            - verify declining an invalid tag (100000000000)

-- 
To view, visit https://gerrit.asterisk.org/5364
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27c4debd5c5080fe1955e6f511dd7718fd07a3a7
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>