[asterisk-commits] res pjsip pubsub: Remove unneeded endpoint unref (asterisk[master])

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Tue Feb 28 17:32:25 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/5100 )

Change subject: res_pjsip_pubsub:  Remove unneeded endpoint unref
......................................................................


res_pjsip_pubsub:  Remove unneeded endpoint unref

When a subscription was being recreated and the endpoint wasn't
found, we were trying to unref the endpoint.  This was causing
FRACKs.  Removed the unref.

ASTERISK-26823 #close

Change-Id: If86d2aecff8fe853c7f38a1bfde721fcef3cd164
---
M res/res_pjsip_pubsub.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Mark Michelson: Looks good to me, approved
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c
index 709dc66..e905024 100644
--- a/res/res_pjsip_pubsub.c
+++ b/res/res_pjsip_pubsub.c
@@ -1456,7 +1456,6 @@
 		ast_log(LOG_WARNING, "Failed recreating '%s' subscription: The endpoint was not found\n",
 			persistence->endpoint);
 		ast_sorcery_delete(ast_sip_get_sorcery(), persistence);
-		ao2_ref(endpoint, -1);
 		return 0;
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/5100
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If86d2aecff8fe853c7f38a1bfde721fcef3cd164
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-commits mailing list