[asterisk-commits] loader: Add volatile to resource being loaded. (asterisk[15.2])

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Dec 27 21:08:35 CST 2017


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/7736 )

Change subject: loader: Add volatile to resource_being_loaded.
......................................................................

loader: Add volatile to resource_being_loaded.

Some compiler optimizers seem to assume that dlopen will not use
__attribute__((constructor)) functions to call back to the program.
This was causing resource_being_loaded to be optimized away completely.

ASTERISK-27531 #close
Tested By: abelbeck

Change-Id: If17a3b889e06811a0e7119f0539d052494d6ece9
---
M main/loader.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Richard Mudgett: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/main/loader.c b/main/loader.c
index 2a203c6..a6a87a0 100644
--- a/main/loader.c
+++ b/main/loader.c
@@ -198,7 +198,7 @@
  *
  * This is protected by the module_list lock.
  */
-static struct ast_module *resource_being_loaded;
+static struct ast_module * volatile resource_being_loaded;
 
 /*!
  * \internal

-- 
To view, visit https://gerrit.asterisk.org/7736
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15.2
Gerrit-MessageType: merged
Gerrit-Change-Id: If17a3b889e06811a0e7119f0539d052494d6ece9
Gerrit-Change-Number: 7736
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-commits/attachments/20171227/f3d62186/attachment.html>


More information about the asterisk-commits mailing list