[asterisk-commits] confbridge: Handle user hangup during name recording (asterisk[14])

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Aug 30 13:54:05 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/6321 )

Change subject: confbridge: Handle user hangup during name recording
......................................................................

confbridge: Handle user hangup during name recording

This prevents orphaned CBAnn channels from getting stuck in the bridge.

ASTERISK-26994 #close
Reported by: James Terhune

Change-Id: I5e43e832a9507ec3f2c59752cd900b41dab80457
---
M apps/app_confbridge.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/apps/app_confbridge.c b/apps/app_confbridge.c
index a33622f..f5f0742 100644
--- a/apps/app_confbridge.c
+++ b/apps/app_confbridge.c
@@ -2320,7 +2320,11 @@
 	if (!quiet &&
 		(ast_test_flag(&user.u_profile, USER_OPT_ANNOUNCE_JOIN_LEAVE) ||
 		(ast_test_flag(&user.u_profile, USER_OPT_ANNOUNCE_JOIN_LEAVE_REVIEW)))) {
-		conf_rec_name(&user, args.conf_name);
+		if (conf_rec_name(&user, args.conf_name)) {
+			pbx_builtin_setvar_helper(chan, "CONFBRIDGE_RESULT", "FAILED");
+			res = -1; /* Hangup during name recording */
+			goto confbridge_cleanup;
+		}
 	}
 
 	/* menu name */

-- 
To view, visit https://gerrit.asterisk.org/6321
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e43e832a9507ec3f2c59752cd900b41dab80457
Gerrit-Change-Number: 6321
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-commits/attachments/20170830/d00349a6/attachment-0001.html>


More information about the asterisk-commits mailing list