[asterisk-commits] apps/app dial: Set the DIALSTATUS to NOANSWER on privacy opt... (asterisk[14])

[SVN commits to the Asterisk project]

Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: apps/app_dial: Set the DIALSTATUS to NOANSWER on privacy option 5
......................................................................


apps/app_dial: Set the DIALSTATUS to NOANSWER on privacy option 5

If the callee selects option '5' using the Dial application's privacy
(P) option, the DIALSTATUS is erroneously set to ANSWER. This option
reflects the callee sending the caller to VoiceMail one time; the call
is definitely *not* ANSWERed in such a scenario. With this patch, the
DIALSTATUS is instead set to NOANSWER, which is the same DIALSTATUS that
is set when the 'send to VoiceMail every time' option is set.

ASTERISK-25691

Change-Id: Iaf0c9f0fa00545e7366443875e2bb7d9a89a1358
---
M apps/app_dial.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/apps/app_dial.c b/apps/app_dial.c
index 48193b5..c427faf 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1919,9 +1919,10 @@
 		ast_copy_string(pa->status, "DONTCALL", sizeof(pa->status));
 		break;
 	case '5':
-		/* XXX should we set status to DENY ? */
-		if (ast_test_flag64(opts, OPT_PRIVACY))
+		if (ast_test_flag64(opts, OPT_PRIVACY)) {
+			ast_copy_string(pa->status, "NOANSWER", sizeof(pa->status));
 			break;
+		}
 		/* if not privacy, then 5 is the same as "default" case */
 	default: /* bad input or -1 if failure to start autoservice */
 		/* well, if the user messes up, ... he had his chance... What Is The Best Thing To Do?  */

-- 
To view, visit https://gerrit.asterisk.org/3823
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf0c9f0fa00545e7366443875e2bb7d9a89a1358
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>