[asterisk-commits] Require TEST FRAMEWORK for agent acknowledge tests. (testsuite[master])

[SVN commits to the Asterisk project]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4240 )

Change subject: Require TEST_FRAMEWORK for agent acknowledge tests.
......................................................................


Require TEST_FRAMEWORK for agent acknowledge tests.

The agent acknowledge tests rely on the PLAYBACK testsuite event in
order to pass. However, they didn't have TEST_FRAMEWORK as a dependency.
Now the test won't even run if TEST_FRAMEWORK is not set in the Asterisk
review.

Change-Id: Ic9235ce31dc097c73f97423b12d3afd40496f9cc
---
M tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml
M tests/apps/agents/agent_acknowledge/nominal/test-config.yaml
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Scott Griepentrog: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  Corey Farrell: Looks good to me, but someone else must approve



diff --git a/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml b/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml
index c42c971..7250c5b 100644
--- a/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml
+++ b/tests/apps/agents/agent_acknowledge/agent_acknowledge_error/test-config.yaml
@@ -259,6 +259,8 @@
 properties:
     minversion: '12.0.0'
     dependencies:
+        # Needed for the PLAYBACK event
+        - buildoption: 'TEST_FRAMEWORK'
         - python : 'starpy'
         - python : 'twisted'
     tags:
diff --git a/tests/apps/agents/agent_acknowledge/nominal/test-config.yaml b/tests/apps/agents/agent_acknowledge/nominal/test-config.yaml
index d7dcba3..337a99f 100644
--- a/tests/apps/agents/agent_acknowledge/nominal/test-config.yaml
+++ b/tests/apps/agents/agent_acknowledge/nominal/test-config.yaml
@@ -392,6 +392,8 @@
 properties:
     minversion: '12.0.0'
     dependencies:
+        # Needed for PLAYBACK event
+        - buildoption: 'TEST_FRAMEWORK'
         - python : 'starpy'
         - python : 'twisted'
     tags:

-- 
To view, visit https://gerrit.asterisk.org/4240
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9235ce31dc097c73f97423b12d3afd40496f9cc
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>