[asterisk-commits] bob does not exist: sometimes fails due to sipp scenario bei... (testsuite[master])

[SVN commits to the Asterisk project]

Mark Michelson has submitted this change and it was merged.

Change subject: bob_does_not_exist: sometimes fails due to sipp scenario being closed early
......................................................................


bob_does_not_exist: sometimes fails due to sipp scenario being closed early

The 'tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist'
would sporadically fail when the tcp sipp scenarios were killed too early. This
occurred because the test was being stopped upon receiving the first of the
expected hangup events. When this happened pjsip reported the socket as closed,
resulting in a "CONGESTED" hangup cause.

Added a 'trigger-on-count' parameter to the offending event action chain so that
the stop action won't trigger until all events have been received.

Note, while the 'tests/apps/queues/transfer/caller_attended/' test has not
failed (at least I don't think it has) it too could potentially suffer from
the same problem, so I added the parameter there as well.

SWP-8433

Change-Id: I0b8f3922bfca5446db298d50363a89a13c06e89d
---
M tests/apps/queues/transfer/caller_attended/test-config.yaml
M tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, approved
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/tests/apps/queues/transfer/caller_attended/test-config.yaml b/tests/apps/queues/transfer/caller_attended/test-config.yaml
index 2c1743f..3cfa455 100644
--- a/tests/apps/queues/transfer/caller_attended/test-config.yaml
+++ b/tests/apps/queues/transfer/caller_attended/test-config.yaml
@@ -146,6 +146,7 @@
                     Event: 'Hangup'
                     Channel: 'PJSIP/alice-.*'
             count: 2
+            trigger-on-count: True
         stop_test:
 
 properties:
diff --git a/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml b/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml
index 5c93a67..b6909c6 100644
--- a/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml
+++ b/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_does_not_exist/test-config.yaml
@@ -162,6 +162,7 @@
                 match:
                     Cause: '18'
             count: '4'
+            trigger-on-count: True
         stop_test:
 
 properties:

-- 
To view, visit https://gerrit.asterisk.org/2277
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8f3922bfca5446db298d50363a89a13c06e89d
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>