[asterisk-commits] Fix IO conversion bug (asterisk[master])

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Dec 9 05:34:03 CST 2016


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/4594 )

Change subject: Fix IO conversion bug
......................................................................


Fix IO conversion bug

Expression 'rlen < 0' is always false.
Unsigned type value is never < 0.

Change-Id: Id9f393ff25b009a6c4a6e40b95f561a9369e4585
---
M res/res_http_websocket.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/res/res_http_websocket.c b/res/res_http_websocket.c
index 106ba48..8413823 100644
--- a/res/res_http_websocket.c
+++ b/res/res_http_websocket.c
@@ -490,7 +490,7 @@
  */
 static inline int ws_safe_read(struct ast_websocket *session, char *buf, int len, enum ast_websocket_opcode *opcode)
 {
-	size_t rlen;
+	ssize_t rlen;
 	int xlen = len;
 	char *rbuf = buf;
 	int sanity = 10;

-- 
To view, visit https://gerrit.asterisk.org/4594
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9f393ff25b009a6c4a6e40b95f561a9369e4585
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-commits mailing list