[asterisk-commits] file: branch 11 r432948 - /branches/11/funcs/func_curl.c

[SVN commits to the Asterisk project]

Author: file
Date: Fri Mar 13 20:59:31 2015
New Revision: 432948

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=432948
Log:
func_curl: Don't hold exclusive lock when performing HTTP request.

This code originally kept a lock held when performing the HTTP
request to ensure that the options provided to curl remain valid.
This doesn't seem to be necessary these days and holding the lock
caused requests to happen sequentially instead of in parallel.

ASTERISK-18708 #close
Reported by: Dave Cabot

Modified:
    branches/11/funcs/func_curl.c

Modified: branches/11/funcs/func_curl.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/funcs/func_curl.c?view=diff&rev=432948&r1=432947&r2=432948
==============================================================================
--- branches/11/funcs/func_curl.c (original)
+++ branches/11/funcs/func_curl.c Fri Mar 13 20:59:31 2015
@@ -654,6 +654,7 @@
 			curl_easy_setopt(*curl, cur->key, cur->value);
 		}
 	}
+	AST_LIST_UNLOCK(&global_curl_info);
 
 	if (chan && (store = ast_channel_datastore_find(chan, &curl_info, NULL))) {
 		list = store->data;
@@ -692,7 +693,6 @@
 	if (store) {
 		AST_LIST_UNLOCK(list);
 	}
-	AST_LIST_UNLOCK(&global_curl_info);
 
 	if (args.postdata) {
 		curl_easy_setopt(*curl, CURLOPT_POST, 0);