[asterisk-commits] Stasis & Attended transfers: Bouncing test due to off nomina... (testsuite[master])

[SVN commits to the Asterisk project]

Joshua Colp has submitted this change and it was merged.

Change subject: Stasis & Attended transfers: Bouncing test due to off nominal path
......................................................................


Stasis & Attended transfers: Bouncing test due to off nominal path

Initially it was thought that the reason several of the stasis/attended
transfer tests were bouncing/failing was due to the endpoint hanging up
too quickly and stopping the transfer process midstream. However, that
was not the case. It was actually due to a race condition between the
initiating transfer thread and the bridge channel impart thread. Since
that is the case this tests can now expect all events to be received.

ASTERISK-24782
Reported by: John Bigelow

Change-Id: I9aee48b2dee47ad422caebdd4b861d25d5a0f75b
---
M tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
1 file changed, 18 insertions(+), 24 deletions(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
index b350152..cdcd0f6 100644
--- a/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
+++ b/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml
@@ -17,23 +17,17 @@
          Stasis(testsuite) app and added to the Stasis bridge 'test_bridge'
          with the second alice channel.
 
-         In the nominal scenario, alice then completes the attended transfer
-         essentially transferring the non-Stasis bridge to the Stasis bridge.
-         Asterisk does this by creating a Local channel where each half is
-         swapped in place of the two alice channels. After the transfer is
-         successful with a local replacement channel half in the non-Stasis
-         bridge with bob and another in the Stasis bridge with carol, bob is
-         hung up. This then initiates the hang up of the local replacement
-         channel half that was in the non-Stasis bridge with bob and the hang
-         up of the local replacement channel half that was in the Stasis bridge
-         with carol. Carol is also hung up which initiates the hung up of the
-         kick off local channel and the destruction of the stasis bridge.
-
-         However, it is possible, and valid, for alice to send a 'bye' to bob
-         immediately after the refer has been received. If this occurs bob is
-         hung up and the transfer process stops. The expected transfer events
-         are thus not raised and received. This test accounts for this
-         possibility."
+         Alice then completes the attended transfer essentially transferring the
+         non-Stasis bridge to the Stasis bridge. Asterisk does this by creating
+         a Local channel where each half is swapped in place of the two alice
+         channels. After the transfer is successful with a local replacement
+         channel half in the non-Stasis bridge with bob and another in the
+         Stasis bridge with carol, bob is hung up. This then initiates the hang
+         up of the local replacement channel half that was in the non-Stasis
+         bridge with bob and the hang up of the local replacement channel half
+         that was in the Stasis bridge with carol. Carol is also hung up which
+         initiates the hung up of the kick off local channel and the destruction
+         of the stasis bridge."
 
 test-modules:
     test-object:
@@ -222,7 +216,7 @@
                 destination_link_second_leg:
                     name: 'Local/_attended at transfer-.*;2'
                 result: 'Success'
-            count: <1
+            count: 1
     # Ensure alice's first channel leaves the non-Stasis bridge.
     -
         ami-events:
@@ -254,7 +248,7 @@
                     name: 'Local/_attended at transfer-.*;2'
                 replace_channel:
                     name: 'PJSIP/alice-.*'
-            count: <1
+            count: 1
     # Ensure alice's second channel leaves the Stasis bridge.
     -
         ari-events:
@@ -276,7 +270,7 @@
                     id: 'test_bridge'
                 channel:
                     name: 'Local/_attended at transfer-.*;2'
-            count: <1
+            count: 1
     # Ensure alice's second channel exits the Stasis app. Then hang up bob.
     -
         ari-events:
@@ -322,14 +316,14 @@
                     Channel: 'Local/_attended at transfer-.*;1'
                 nomatch:
                     BridgeUniqueid: 'test_bridge'
-            count: <1
+            count: 1
     -
         ami-events:
             conditions:
                 match:
                     Event: 'Hangup'
                     Channel: 'Local/_attended at transfer-.*;1'
-            count: <1
+            count: 1
     # Ensure the local channel half in Stasis bridge with carol leaves the
     # bridge.
     -
@@ -341,7 +335,7 @@
                     id: 'test_bridge'
                 channel:
                     name: 'Local/_attended at transfer-.*;2'
-            count: <1
+            count: 1
     # Ensure the local channel half in Stasis bridge with carol exits the
     # Stasis app.
     -
@@ -351,7 +345,7 @@
                 application: 'testsuite'
                 channel:
                     name: 'Local/_attended at transfer-.*;2'
-            count: <1
+            count: 1
     # Ensure carol leaves the Stasis bridge.
     -
         ari-events:

-- 
To view, visit https://gerrit.asterisk.org/727
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9aee48b2dee47ad422caebdd4b861d25d5a0f75b
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>