[asterisk-commits] mjordan: branch 11 r434190 - /branches/11/funcs/func_math.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Mon Apr  6 21:09:19 2015
New Revision: 434190

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=434190
Log:
clang compiler warnings: Fix sometimes-initialized warning in func_math

This patch fixes a bug in a unit test in func_math where a variable could be
passed to ast_free that wasn't allocated. This patch corrects the issue and
ensures that we only attempt to free a variable if we previously allocated
it.

Review: https://reviewboard.asterisk.org/r/4552

ASTERISK-24917
Reported by: dkdegroot
patches:
  rb4552.patch submitted by dkdegroot (License 6600)

Modified:
    branches/11/funcs/func_math.c

Modified: branches/11/funcs/func_math.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/funcs/func_math.c?view=diff&rev=434190&r1=434189&r2=434190
==============================================================================
--- branches/11/funcs/func_math.c (original)
+++ branches/11/funcs/func_math.c Mon Apr  6 21:09:19 2015
@@ -482,13 +482,11 @@
 
 	ast_test_status_update(test, "Testing MATH() substitution ...\n");
 
-	if (!(expr = ast_str_create(16)) || !(result = ast_str_create(16))) {
-		if (expr) {
-			ast_free(expr);
-		}
-		if (result) {
-			ast_free(result);
-		}
+	if (!(expr = ast_str_create(16))) {
+		return AST_TEST_FAIL;
+	}
+	if (!(result = ast_str_create(16))) {
+		ast_free(expr);
 		return AST_TEST_FAIL;
 	}