[asterisk-commits] rmudgett: branch 12 r424096 - /branches/12/main/threadpool.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Mon Sep 29 15:24:53 2014
New Revision: 424096

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=424096
Log:
threadpool.c: Minor cleanup fixes.

* Fix threadpool_alloc() prototype.

* Add missing off-nominal NULL check of pool in threadpool_alloc().

* searializer_create() does not need to create the object with a lock as
the lock is not used.

Modified:
    branches/12/main/threadpool.c

Modified: branches/12/main/threadpool.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/main/threadpool.c?view=diff&rev=424096&r1=424095&r2=424096
==============================================================================
--- branches/12/main/threadpool.c (original)
+++ branches/12/main/threadpool.c Mon Sep 29 15:24:53 2014
@@ -385,13 +385,15 @@
  * \retval NULL Could not initialize threadpool properly
  * \retval non-NULL The newly-allocated threadpool
  */
-static void *threadpool_alloc(const char *name, const struct ast_threadpool_options *options)
-{
-	RAII_VAR(struct ast_threadpool *, pool,
-			ao2_alloc(sizeof(*pool), threadpool_destructor), ao2_cleanup);
-	struct ast_str *control_tps_name = ast_str_create(64);
-
-	if (!control_tps_name) {
+static struct ast_threadpool *threadpool_alloc(const char *name, const struct ast_threadpool_options *options)
+{
+	RAII_VAR(struct ast_threadpool *, pool, NULL, ao2_cleanup);
+	struct ast_str *control_tps_name;
+
+	pool = ao2_alloc(sizeof(*pool), threadpool_destructor);
+	control_tps_name = ast_str_create(64);
+	if (!pool || !control_tps_name) {
+		ast_free(control_tps_name);
 		return NULL;
 	}
 
@@ -859,8 +861,9 @@
 {
 	struct ast_taskprocessor *tps;
 	RAII_VAR(struct ast_taskprocessor_listener *, tps_listener, NULL, ao2_cleanup);
-	RAII_VAR(struct ast_threadpool *, pool, threadpool_alloc(name, options), ao2_cleanup);
-
+	RAII_VAR(struct ast_threadpool *, pool, NULL, ao2_cleanup);
+
+	pool = threadpool_alloc(name, options);
 	if (!pool) {
 		return NULL;
 	}
@@ -1136,7 +1139,9 @@
 
 static struct serializer *serializer_create(struct ast_threadpool *pool)
 {
-	struct serializer *ser = ao2_alloc(sizeof(*ser), serializer_dtor);
+	struct serializer *ser;
+
+	ser = ao2_alloc_options(sizeof(*ser), serializer_dtor, AO2_ALLOC_OPT_LOCK_NOLOCK);
 	if (!ser) {
 		return NULL;
 	}