[asterisk-commits] seanbright: branch 12 r423481 - /branches/12/res/res_pjsip/config_auth.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu Sep 18 14:29:35 CDT 2014


Author: seanbright
Date: Thu Sep 18 14:29:30 2014
New Revision: 423481

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=423481
Log:
res_pjsip: Don't require a password when doing userpass authentication.

An empty password is valid for username/password authentication so we should
allow password to be empty/not supplied.

Review: https://reviewboard.asterisk.org/r/3988

Modified:
    branches/12/res/res_pjsip/config_auth.c

Modified: branches/12/res/res_pjsip/config_auth.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/res/res_pjsip/config_auth.c?view=diff&rev=423481&r1=423480&r2=423481
==============================================================================
--- branches/12/res/res_pjsip/config_auth.c (original)
+++ branches/12/res/res_pjsip/config_auth.c Thu Sep 18 14:29:30 2014
@@ -94,13 +94,6 @@
 	}
 
 	switch (auth->type) {
-	case AST_SIP_AUTH_TYPE_USER_PASS:
-		if (ast_strlen_zero(auth->auth_pass)) {
-			ast_log(LOG_ERROR, "'userpass' authentication specified but no "
-					"password specified for auth '%s'\n", ast_sorcery_object_get_id(auth));
-			res = -1;
-		}
-		break;
 	case AST_SIP_AUTH_TYPE_MD5:
 		if (ast_strlen_zero(auth->md5_creds)) {
 			ast_log(LOG_ERROR, "'md5' authentication specified but no md5_cred "
@@ -113,6 +106,7 @@
 			res = -1;
 		}
 		break;
+	case AST_SIP_AUTH_TYPE_USER_PASS:
 	case AST_SIP_AUTH_TYPE_ARTIFICIAL:
 		break;
 	}




More information about the asterisk-commits mailing list