[asterisk-commits] file: branch 12 r427981 - in /branches/12/channels: chan_motif.c chan_pjsip.c

[SVN commits to the Asterisk project]

Author: file
Date: Sat Nov 15 12:59:47 2014
New Revision: 427981

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=427981
Log:
chan_motif / chan_pjsip: Fix incorrect "No such module" messages when reloading.

For chan_motif the direct return value of the underlying config options framework
was passed back. This can relay various states which the module loader would not
interpet as success. It has been changed so only on errors will it report back
an error.

For chan_pjsip the code implemented a dummy reload function which always
returned an error. This has been removed as all configuration is held within
res_pjsip instead.

ASTERISK-23651 #close
Reported by: Rusty Newton

Modified:
    branches/12/channels/chan_motif.c
    branches/12/channels/chan_pjsip.c

Modified: branches/12/channels/chan_motif.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/channels/chan_motif.c?view=diff&rev=427981&r1=427980&r2=427981
==============================================================================
--- branches/12/channels/chan_motif.c (original)
+++ branches/12/channels/chan_motif.c Sat Nov 15 12:59:47 2014
@@ -2785,7 +2785,11 @@
 /*! \brief Reload module */
 static int reload(void)
 {
-	return aco_process_config(&cfg_info, 1);
+	if (aco_process_config(&cfg_info, 1) == ACO_PROCESS_ERROR) {
+		return -1;
+	}
+
+	return 0;
 }
 
 /*! \brief Unload the jingle channel from Asterisk */

Modified: branches/12/channels/chan_pjsip.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/channels/chan_pjsip.c?view=diff&rev=427981&r1=427980&r2=427981
==============================================================================
--- branches/12/channels/chan_pjsip.c (original)
+++ branches/12/channels/chan_pjsip.c Sat Nov 15 12:59:47 2014
@@ -2259,12 +2259,6 @@
 	return AST_MODULE_LOAD_FAILURE;
 }
 
-/*! \brief Reload module */
-static int reload(void)
-{
-	return -1;
-}
-
 /*! \brief Unload the PJSIP channel from Asterisk */
 static int unload_module(void)
 {
@@ -2288,6 +2282,5 @@
 AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_LOAD_ORDER, "PJSIP Channel Driver",
 		.load = load_module,
 		.unload = unload_module,
-		.reload = reload,
 		.load_pri = AST_MODPRI_CHANNEL_DRIVER,
 	       );