[asterisk-commits] jrose: trunk r427903 - in /trunk: ./ configs/samples/cdr.conf.sample main/cdr.c

[SVN commits to the Asterisk project]

Author: jrose
Date: Fri Nov 14 12:12:05 2014
New Revision: 427903

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=427903
Log:
Documentation: Revise explanation of cdr.conf option 'Unanswered'

ASTERISK-24279 #close
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/4109/
........

Merged revisions 427901 from http://svn.asterisk.org/svn/asterisk/branches/12
........

Merged revisions 427902 from http://svn.asterisk.org/svn/asterisk/branches/13

Modified:
    trunk/   (props changed)
    trunk/configs/samples/cdr.conf.sample
    trunk/main/cdr.c

Propchange: trunk/
------------------------------------------------------------------------------
Binary property 'branch-13-merged' - no diff available.

Modified: trunk/configs/samples/cdr.conf.sample
URL: http://svnview.digium.com/svn/asterisk/trunk/configs/samples/cdr.conf.sample?view=diff&rev=427903&r1=427902&r2=427903
==============================================================================
--- trunk/configs/samples/cdr.conf.sample (original)
+++ trunk/configs/samples/cdr.conf.sample Fri Nov 14 12:12:05 2014
@@ -13,20 +13,13 @@
 ; any loading of backend CDR modules.  Default is "yes".
 ;enable=yes
 
-; Define whether or not to log unanswered calls. Setting this to "yes" will
-; report every attempt to ring a phone in dialing attempts, when it was not
-; answered. For example, if you try to dial 3 extensions, and this option is "yes",
-; you will get 3 CDR's, one for each phone that was rung. Default is "no". Some
-; find this information horribly useless. Others find it very valuable. Note, in "yes"
-; mode, you will see one CDR, with one of the call targets on one side, and the originating
-; channel on the other, and then one CDR for each channel attempted. This may seem
-; redundant, but cannot be helped.
-;
-; In brief, this option controls the reporting of unanswered calls which only have an A 
-; party. Calls which get offered to an outgoing line, but are unanswered, are still 
-; logged, and that is the intended behaviour. (It also results in some B side CDRs being
-; output, as they have the B side channel as their source channel, and no destination 
-; channel.)
+; Define whether or not to log unanswered calls that don't involve an outgoing
+; party. Setting this to "yes" will make calls to extensions that don't answer
+; and don't set a B side channel (such as by using the Dial application)
+; receive CDR log entries. If this option is set to "no", then those log
+; entries will not be created. Unasnwered Calls which get offered to an
+; outgoing line will always receive log entries regardless of this option, and
+; that is the intended behaviour.
 ;unanswered = no
 
 ; Define whether or not to log congested calls. Setting this to "yes" will

Modified: trunk/main/cdr.c
URL: http://svnview.digium.com/svn/asterisk/trunk/main/cdr.c?view=diff&rev=427903&r1=427902&r2=427903
==============================================================================
--- trunk/main/cdr.c (original)
+++ trunk/main/cdr.c Fri Nov 14 12:12:05 2014
@@ -98,19 +98,15 @@
 					</description>
 				</configOption>
 				<configOption name="unanswered">
-					<synopsis>Log calls that are never answered.</synopsis>
-					<description><para>Define whether or not to log unanswered calls. Setting this to "yes" will
-					report every attempt to ring a phone in dialing attempts, when it was not
-					answered. For example, if you try to dial 3 extensions, and this option is "yes",
-					you will get 3 CDR's, one for each phone that was rung. Some find this information horribly
-					useless. Others find it very valuable. Note, in "yes" mode, you will see one CDR, with one of
-					the call targets on one side, and the originating channel on the other, and then one CDR for
-					each channel attempted. This may seem redundant, but cannot be helped.</para>
-					<para>In brief, this option controls the reporting of unanswered calls which only have an A
-					party. Calls which get offered to an outgoing line, but are unanswered, are still
-					logged, and that is the intended behavior. (It also results in some B side CDRs being
-					output, as they have the B side channel as their source channel, and no destination
-					channel.)</para>
+					<synopsis>Log calls that are never answered and don't set an outgoing party.</synopsis>
+					<description><para>
+					Define whether or not to log unanswered calls that don't involve an outgoing party. Setting
+					this to "yes" will make calls to extensions that don't answer and don't set a side B channel
+					(such as by using the Dial application) receive CDR log entries. If this option is set to
+					"no", then those log entries will not be created. Unanswered calls which get offered to an
+					outgoing line will always receive log entries regardless of this option, and that is the
+					intended behavior.
+					</para>
 					</description>
 				</configOption>
 				<configOption name="congestion">