[asterisk-commits] mjordan: branch 11 r427607 - /branches/11/addons/chan_mobile.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Sat Nov  8 18:24:53 2014
New Revision: 427607

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=427607
Log:
addons/chan_mobile: Increase buffer size of UCS2 encoded SMS messages

When UCS2 character encoding is used, one symbol in national language can be
expanded to 4 bytes. The current buffer used for receiving message in
do_monitor_phone is 256 bytes, which is not large enough for incoming messages.

For example:
* AT+CMGR phone response prefix
  '+CMGR: "REC UNREAD","+7**********",,"14/10/29,13:31:39+12"\r\n' - 60 bytes
* SMS body with UCS2 encoding (max) - 280 bytes
* AT+CMGR phone response suffix '\r\n\r\nOK\r\n' - 8 bytes
* Terminating null character - 1 byte

This results in a needed buffer size of 349 bytes. Hence, this patch opts for a
350 byte buffer.

ASTERISK-24468 #close
Reported by: Dmitriy Bubnov
patches:
  chan_mobile-1_8.diff uploaded by Dmitriy Bubnov (License 6651)
  chan_mobile-trunk.diff uploaded by Dmitry Bubnov (License 6651)


Modified:
    branches/11/addons/chan_mobile.c

Modified: branches/11/addons/chan_mobile.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/addons/chan_mobile.c?view=diff&rev=427607&r1=427606&r2=427607
==============================================================================
--- branches/11/addons/chan_mobile.c (original)
+++ branches/11/addons/chan_mobile.c Sat Nov  8 18:24:53 2014
@@ -3659,7 +3659,7 @@
 {
 	struct mbl_pvt *pvt = (struct mbl_pvt *)data;
 	struct hfp_pvt *hfp = pvt->hfp;
-	char buf[256];
+	char buf[350];
 	int t;
 	at_message_t at_msg;
 	struct msg_queue_entry *entry;