[asterisk-commits] coreyfarrell: branch 12 r427020 - in /branches/12: ./ main/abstract_jb.c

[SVN commits to the Asterisk project]

Author: coreyfarrell
Date: Sun Nov  2 01:38:14 2014
New Revision: 427020

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=427020
Log:
func_jitterbuffer: fix frame leaks.

Fix code paths where it is possible for frames to leak.
Fix uninitialized variable in jb_get_fixed and jb_get_adaptive.

ASTERISK-22409 #related
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/4128/
........

Merged revisions 427019 from http://svn.asterisk.org/svn/asterisk/branches/11

Modified:
    branches/12/   (props changed)
    branches/12/main/abstract_jb.c

Propchange: branches/12/
------------------------------------------------------------------------------
Binary property 'branch-11-merged' - no diff available.

Modified: branches/12/main/abstract_jb.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/main/abstract_jb.c?view=diff&rev=427020&r1=427019&r2=427020
==============================================================================
--- branches/12/main/abstract_jb.c (original)
+++ branches/12/main/abstract_jb.c Sun Nov  2 01:38:14 2014
@@ -656,7 +656,7 @@
 static int jb_get_fixed(void *jb, struct ast_frame **fout, long now, long interpl)
 {
 	struct fixed_jb *fixedjb = (struct fixed_jb *) jb;
-	struct fixed_jb_frame frame;
+	struct fixed_jb_frame frame = { .data = &ast_null_frame };
 	int res;
 
 	res = fixed_jb_get(fixedjb, &frame, now, interpl);
@@ -752,7 +752,7 @@
 static int jb_get_adaptive(void *jb, struct ast_frame **fout, long now, long interpl)
 {
 	jitterbuf *adaptivejb = (jitterbuf *) jb;
-	jb_frame frame;
+	jb_frame frame = { .data = &ast_null_frame };
 	int res;
 
 	res = jb_get(adaptivejb, &frame, now, interpl);
@@ -921,8 +921,14 @@
 		} else {
 			res = framedata->jb_impl->put(framedata->jb_obj, jbframe, now);
 		}
+
 		if (res == AST_JB_IMPL_OK) {
+			if (jbframe != frame) {
+				ast_frfree(frame);
+			}
 			frame = &ast_null_frame;
+		} else if (jbframe != frame) {
+			ast_frfree(jbframe);
 		}
 		putframe = 1;
 	}
@@ -949,6 +955,8 @@
 			}
 		}
 
+		ast_frfree(frame);
+		frame = &ast_null_frame;
 		res = framedata->jb_impl->get(framedata->jb_obj, &frame, now, framedata->timer_interval);
 		switch (res) {
 		case AST_JB_IMPL_OK:
@@ -961,6 +969,7 @@
 		case AST_JB_IMPL_INTERP:
 			if (framedata->last_format.id) {
 				struct ast_frame tmp = { 0, };
+
 				tmp.frametype = AST_FRAME_VOICE;
 				ast_format_copy(&tmp.subclass.format, &framedata->last_format);
 				/* example: 8000hz / (1000 / 20ms) = 160 samples */
@@ -968,11 +977,13 @@
 				tmp.delivery = ast_tvadd(framedata->start_tv, ast_samp2tv(next, 1000));
 				tmp.offset = AST_FRIENDLY_OFFSET;
 				tmp.src  = "func_jitterbuffer interpolation";
+				ast_frfree(frame);
 				frame = ast_frdup(&tmp);
 				break;
 			}
 			/* else fall through */
 		case AST_JB_IMPL_NOFRAME:
+			ast_frfree(frame);
 			frame = &ast_null_frame;
 			break;
 		}