[asterisk-commits] rmeyerriecks: branch 1.8 r410710 - /branches/1.8/main/callerid.c

[SVN commits to the Asterisk project]

Author: rmeyerriecks
Date: Mon Mar 17 16:14:21 2014
New Revision: 410710

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=410710
Log:
callerid: Logic error in checksum processing

Callerid checksum-ing was being handled incorrectly here. When the checksum is
calculated to be 0x00, it will perform 0x100-0x00 which results in 0x100. This
value will then fail the otherwise correct callerid message.

This patch changes the logic to simply add the calculated checksum to the
transmitted 2's compliment checksum.  

Review: https://reviewboard.asterisk.org/r/3356/
(closes issue ASTERISK-23488)

Modified:
    branches/1.8/main/callerid.c

Modified: branches/1.8/main/callerid.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/callerid.c?view=diff&rev=410710&r1=410709&r2=410710
==============================================================================
--- branches/1.8/main/callerid.c (original)
+++ branches/1.8/main/callerid.c Mon Mar 17 16:14:21 2014
@@ -621,7 +621,7 @@
 				}
 				break;
 			case 5: /* Check checksum */
-				if (b != (256 - (cid->cksum & 0xff))) {
+				if ((b + cid->cksum) & 0xff)) {
 					ast_log(LOG_NOTICE, "Caller*ID failed checksum\n");
 					/* Try again */
 					cid->sawflag = 0;