[asterisk-commits] coreyfarrell: branch 12 r417212 - /branches/12/main/astobj2_container.c

[SVN commits to the Asterisk project]

Author: coreyfarrell
Date: Wed Jun 25 13:56:09 2014
New Revision: 417212

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=417212
Log:
ao2_container node object ignores REF_DEBUG in all places except one

Almost every reference operation against container node's uses
__ao2_alloc or __ao2_ref, thereby preventing ref logging for
the nodes.  One node reference is released with ao2_t_ref, causing
refcounter.py to falsely report skews and leaks for many nodes.

ASTERISK-23922 #close
Reported by: Corey Farrell
Review: https://reviewboard.asterisk.org/r/3670/

Modified:
    branches/12/main/astobj2_container.c

Modified: branches/12/main/astobj2_container.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/main/astobj2_container.c?view=diff&rev=417212&r1=417211&r2=417212
==============================================================================
--- branches/12/main/astobj2_container.c (original)
+++ branches/12/main/astobj2_container.c Wed Jun 25 13:56:09 2014
@@ -75,7 +75,8 @@
 	}
 
 	if (flags & AO2_UNLINK_NODE_UNREF_NODE) {
-		ao2_t_ref(node, -1, "Remove node from container");
+		/* Remove node from container */
+		__ao2_ref(node, -1);
 	}
 
 	return 1;