[asterisk-commits] kmoore: branch 11 r419162 - in /branches/11: ./ addons/ addons/ooh323c/src/ a...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Tue Jul 22 09:00:41 CDT 2014


Author: kmoore
Date: Tue Jul 22 09:00:33 2014
New Revision: 419162

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=419162
Log:
Fix more dev-mode build issues
........

Merged revisions 419129 from http://svn.asterisk.org/svn/asterisk/branches/1.8

Modified:
    branches/11/   (props changed)
    branches/11/addons/chan_ooh323.c
    branches/11/addons/ooh323c/src/ooq931.c
    branches/11/addons/ooh323c/src/printHandler.c
    branches/11/apps/app_meetme.c
    branches/11/res/res_jabber.c
    branches/11/tests/test_abstract_jb.c
    branches/11/tests/test_aoc.c
    branches/11/tests/test_astobj2.c
    branches/11/tests/test_astobj2_thrash.c
    branches/11/tests/test_config.c
    branches/11/tests/test_event.c
    branches/11/tests/test_format_api.c
    branches/11/tests/test_hashtab_thrash.c
    branches/11/tests/test_logger.c
    branches/11/tests/test_voicemail_api.c

Propchange: branches/11/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: branches/11/addons/chan_ooh323.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/addons/chan_ooh323.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/addons/chan_ooh323.c (original)
+++ branches/11/addons/chan_ooh323.c Tue Jul 22 09:00:33 2014
@@ -493,7 +493,7 @@
 		if (ch) {
 			manager_event(EVENT_FLAG_SYSTEM, "ChannelUpdate", 
 				"Channel: %s\r\nChanneltype: %s\r\n"
-				"CallRef: %d\r\n", ast_channel_name(ch), "OOH323", i->call_reference);
+				"CallRef: %u\r\n", ast_channel_name(ch), "OOH323", i->call_reference);
 		}
 	} else
 		ast_log(LOG_WARNING, "Unable to allocate channel structure\n");
@@ -1125,7 +1125,7 @@
 			ast_channel_lock(ast);
 			if (!p->alertsent) {
 	    			if (gH323Debug) {
-					ast_debug(1, "Sending forced ringback for %s, res = %d\n", 
+					ast_debug(1, "Sending forced ringback for %s, res = %u\n", 
 						callToken, ooManualRingback(callToken));
 				} else {
 	    				ooManualRingback(callToken);
@@ -1180,7 +1180,7 @@
 		p->lastrtptx = time(NULL);
 
 		if (f->frametype == AST_FRAME_MODEM) {
-			ast_debug(1, "Send UDPTL %d/%d len %d for %s\n",
+			ast_debug(1, "Send UDPTL %u/%d len %d for %s\n",
 				f->frametype, f->subclass.integer, f->datalen, ast_channel_name(ast));
 			if (p->udptl)
 				res = ast_udptl_write(p->udptl, f);
@@ -1225,7 +1225,7 @@
 			ast_mutex_unlock(&p->lock);
 			return 0;
 		} else {
-			ast_log(LOG_WARNING, "Can't send %d type frames with OOH323 write\n", 
+			ast_log(LOG_WARNING, "Can't send %u type frames with OOH323 write\n", 
 									 f->frametype);
 			ast_mutex_unlock(&p->lock);
 			return 0;
@@ -1289,7 +1289,7 @@
 		if (ast_channel_state(ast) != AST_STATE_UP) {
 	    		if (!p->progsent) {
 	     			if (gH323Debug) {
-					ast_debug(1, "Sending manual progress for %s, res = %d\n", callToken,
+					ast_debug(1, "Sending manual progress for %s, res = %u\n", callToken,
              				ooManualProgress(callToken));	
 				} else {
 	     				ooManualProgress(callToken);
@@ -1302,7 +1302,7 @@
 		if (ast_channel_state(ast) == AST_STATE_RING || ast_channel_state(ast) == AST_STATE_RINGING) {
 			if (!p->alertsent) {
 				if (gH323Debug) {
-					ast_debug(1, "Sending manual ringback for %s, res = %d\n",
+					ast_debug(1, "Sending manual ringback for %s, res = %u\n",
 						callToken,
 						ooManualRingback(callToken));
 				} else {
@@ -2153,7 +2153,7 @@
 			ast_queue_control(c, AST_CONTROL_ANSWER);
    			ast_channel_unlock(p->owner);
 			manager_event(EVENT_FLAG_SYSTEM,"ChannelUpdate","Channel: %s\r\nChanneltype: %s\r\n"
-				"CallRef: %d\r\n", ast_channel_name(c), "OOH323", p->call_reference);
+				"CallRef: %u\r\n", ast_channel_name(c), "OOH323", p->call_reference);
 		}
 		ast_mutex_unlock(&p->lock);
 
@@ -3190,7 +3190,7 @@
 		ast_cli(a->fd, "%-15.15s%s\n", "AccountCode: ", peer->accountcode);
 		ast_cli(a->fd, "%-15.15s%s\n", "AMA flags: ", ast_cdr_flags2str(peer->amaflags));
 		ast_cli(a->fd, "%-15.15s%s\n", "IP:Port: ", ip_port);
-		ast_cli(a->fd, "%-15.15s%d\n", "OutgoingLimit: ", peer->outgoinglimit);
+		ast_cli(a->fd, "%-15.15s%u\n", "OutgoingLimit: ", peer->outgoinglimit);
 		ast_cli(a->fd, "%-15.15s%d\n", "rtptimeout: ", peer->rtptimeout);
 		ast_cli(a->fd, "%-15.15s%s\n", "nat: ", peer->nat?"yes":"no");
 		if (peer->rtpmaskstr[0]) {
@@ -3350,7 +3350,7 @@
 		ast_cli(a->fd, "%-15.15s%s\n", "AMA flags: ", ast_cdr_flags2str(user->amaflags));
 		ast_cli(a->fd, "%-15.15s%s\n", "Context: ", user->context);
 		ast_cli(a->fd, "%-15.15s%d\n", "IncomingLimit: ", user->incominglimit);
-		ast_cli(a->fd, "%-15.15s%d\n", "InUse: ", user->inUse);
+		ast_cli(a->fd, "%-15.15s%u\n", "InUse: ", user->inUse);
 		ast_cli(a->fd, "%-15.15s%d\n", "rtptimeout: ", user->rtptimeout);
 		ast_cli(a->fd, "%-15.15s%s\n", "nat: ", user->nat?"yes":"no");
 		if (user->rtpmaskstr[0]) {
@@ -4376,7 +4376,7 @@
 
 	ast_rtp_instance_get_remote_address(*rtp, &tmp);
 	if (gH323Debug) {
-		ast_verb(0, "ooh323_get_rtp_peer  %s -> %s:%d, %d\n", ast_channel_name(chan), ast_sockaddr_stringify_addr(&tmp),
+		ast_verb(0, "ooh323_get_rtp_peer  %s -> %s:%d, %u\n", ast_channel_name(chan), ast_sockaddr_stringify_addr(&tmp),
 						ast_sockaddr_port(&tmp), res);
 	}
 	if (gH323Debug) {
@@ -4962,7 +4962,7 @@
 	case 5:
 		f = ast_udptl_read(p->udptl);		/* UDPTL t.38 data */
 		if (gH323Debug) {
-			 ast_debug(1, "Got UDPTL %d/%d len %d for %s\n",
+			 ast_debug(1, "Got UDPTL %u/%d len %d for %s\n",
 				f->frametype, f->subclass.integer, f->datalen, ast_channel_name(ast));
 		}
 		p->lastrtprx = time(NULL);

Modified: branches/11/addons/ooh323c/src/ooq931.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/addons/ooh323c/src/ooq931.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/addons/ooh323c/src/ooq931.c (original)
+++ branches/11/addons/ooh323c/src/ooq931.c Tue Jul 22 09:00:33 2014
@@ -319,7 +319,7 @@
          strcpy(buf, "Escape");
          break;
       default:
-         sprintf(buf, "<%u>", messageType);
+         sprintf(buf, "<%d>", messageType);
    }
    return buf;
 }
@@ -360,7 +360,7 @@
          strcpy(buf, "User-User");
          break;
       default:
-         sprintf(buf, "0x%02x", number);
+         sprintf(buf, "0x%02x", (unsigned)number);
    }
    return buf;
 }
@@ -371,8 +371,8 @@
    unsigned int i;
 
    printf("Q.931 Message:\n");
-   printf("   protocolDiscriminator: %i\n", q931msg->protocolDiscriminator);
-   printf("   callReference: %i\n", q931msg->callReference);
+   printf("   protocolDiscriminator: %u\n", q931msg->protocolDiscriminator);
+   printf("   callReference: %u\n", q931msg->callReference);
    printf("   from: %s\n", (q931msg->fromDestination ? 
                                        "destination" : "originator"));
    printf("   messageType: %s (0x%X)\n\n", 
@@ -382,9 +382,9 @@
    for(i = 0, curNode = q931msg->ies.head; i < q931msg->ies.count; i++) {
       Q931InformationElement *ie = (Q931InformationElement*) curNode->data;
       int length = (ie->length >= 0) ? ie->length : -ie->length;
-      printf("   IE[%i] (offset 0x%X):\n", i, ie->offset);
+      printf("   IE[%u] (offset 0x%X):\n", i, (unsigned)ie->offset);
       printf("      discriminator: %s (0x%X)\n", 
-               ooQ931GetIEName(ie->discriminator, buf), ie->discriminator);
+               ooQ931GetIEName(ie->discriminator, buf), (unsigned)ie->discriminator);
       printf("      data length: %i\n", length);
  
       curNode = curNode->next;

Modified: branches/11/addons/ooh323c/src/printHandler.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/addons/ooh323c/src/printHandler.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/addons/ooh323c/src/printHandler.c (original)
+++ branches/11/addons/ooh323c/src/printHandler.c Tue Jul 22 09:00:33 2014
@@ -268,7 +268,7 @@
       if (bufsiz > 1) buffer[1] = '\0';
       for (i = 0; i < numocts; i++) {
          if (i < bufsiz - 1) {
-            sprintf (lbuf, "%02x", data[i]);
+            sprintf (lbuf, "%02x", (unsigned)data[i]);
             strcat (&buffer[(i*2)+1], lbuf);
          }
          else break;

Modified: branches/11/apps/app_meetme.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/apps/app_meetme.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/apps/app_meetme.c (original)
+++ branches/11/apps/app_meetme.c Tue Jul 22 09:00:33 2014
@@ -2918,7 +2918,7 @@
 
 	if (ast_test_flag64(confflags, CONFFLAG_DURATION_STOP) && !ast_strlen_zero(optargs[OPT_ARG_DURATION_STOP])) {
 		calldurationlimit = atoi(optargs[OPT_ARG_DURATION_STOP]);
-		ast_verb(3, "Setting call duration limit to %d seconds.\n", calldurationlimit);
+		ast_verb(3, "Setting call duration limit to %u seconds.\n", calldurationlimit);
 	}
 
 	if (ast_test_flag64(confflags, CONFFLAG_DURATION_LIMIT) && !ast_strlen_zero(optargs[OPT_ARG_DURATION_LIMIT])) {
@@ -4046,12 +4046,12 @@
 						break;
 					default:
 						ast_debug(1,
-							"Got ignored control frame on channel %s, f->frametype=%d,f->subclass=%d\n",
+							"Got ignored control frame on channel %s, f->frametype=%u,f->subclass=%d\n",
 							ast_channel_name(chan), f->frametype, f->subclass.integer);
 					}
 				} else {
 					ast_debug(1,
-						"Got unrecognized frame on channel %s, f->frametype=%d,f->subclass=%d\n",
+						"Got unrecognized frame on channel %s, f->frametype=%u,f->subclass=%d\n",
 						ast_channel_name(chan), f->frametype, f->subclass.integer);
 				}
 				ast_frfree(f);
@@ -6906,7 +6906,7 @@
 		ast_cond_destroy(&cond);
 		ast_autoservice_stop(chan);
 		if (!trunk_ref->trunk->chan) {
-			ast_debug(1, "Trunk didn't get created. chan: %lx\n", (long) trunk_ref->trunk->chan);
+			ast_debug(1, "Trunk didn't get created. chan: %lx\n", (unsigned long) trunk_ref->trunk->chan);
 			pbx_builtin_setvar_helper(chan, "SLASTATION_STATUS", "CONGESTION");
 			sla_change_trunk_state(trunk_ref->trunk, SLA_TRUNK_STATE_IDLE, ALL_TRUNK_REFS, NULL);
 			trunk_ref->chan = NULL;

Modified: branches/11/res/res_jabber.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/res/res_jabber.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/res/res_jabber.c (original)
+++ branches/11/res/res_jabber.c Tue Jul 22 09:00:33 2014
@@ -2623,7 +2623,7 @@
 			ASTOBJ_UNREF(buddy, ast_aji_buddy_destroy);
 		}
 	default:
-		ast_verb(5, "JABBER: This is a subcription of type %i\n", pak->subtype);
+		ast_verb(5, "JABBER: This is a subcription of type %u\n", pak->subtype);
 	}
 }
 

Modified: branches/11/tests/test_abstract_jb.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_abstract_jb.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_abstract_jb.c (original)
+++ branches/11/tests/test_abstract_jb.c Tue Jul 22 09:00:33 2014
@@ -117,6 +117,15 @@
 	} } while (0)
 
 /*! \internal
+ * \brief Test two numeric (unsigned int) values.
+*/
+#define UINT_TEST(actual, expected) do { \
+	if ((actual) != (expected)) { \
+		ast_test_status_update(test, #actual ": expected [%u]; actual [%u]\n", (expected), (actual)); \
+		return AST_TEST_FAIL; \
+	} } while (0)
+
+/*! \internal
  * \brief Test two string values
 */
 #define STRING_TEST(actual, expected) do { \
@@ -129,7 +138,7 @@
  * \brief Verify that two frames have the same properties
  */
 #define VERIFY_FRAME(actual, expected) do { \
-	INT_TEST((actual)->frametype, (expected)->frametype); \
+	UINT_TEST((actual)->frametype, (expected)->frametype); \
 	INT_TEST((actual)->seqno, (expected)->seqno); \
 	LONG_INT_TEST((actual)->ts, (expected)->ts); \
 	LONG_INT_TEST((actual)->len, (expected)->len); \

Modified: branches/11/tests/test_aoc.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_aoc.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_aoc.c (original)
+++ branches/11/tests/test_aoc.c Tue Jul 22 09:00:33 2014
@@ -411,7 +411,7 @@
 			if (!(unit = ast_aoc_get_unit_info(decoded, i)) ||
 				((unit->valid_amount) && (unit->amount != (i+1))) ||
 				((unit->valid_type) && (unit->type != (i+2)))) {
-				ast_test_status_update(test, "TEST 2, invalid unit entry result, got %d,%d, expected %d,%d\n",
+				ast_test_status_update(test, "TEST 2, invalid unit entry result, got %u,%u, expected %d,%d\n",
 					unit->amount,
 					unit->type,
 					i+1,

Modified: branches/11/tests/test_astobj2.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_astobj2.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_astobj2.c (original)
+++ branches/11/tests/test_astobj2.c Tue Jul 22 09:00:33 2014
@@ -154,7 +154,7 @@
 		}
 	}
 
-	ast_test_status_update(test, "Container created: random bucket size %d: number of items: %d\n", bucket_size, lim);
+	ast_test_status_update(test, "Container created: random bucket size %d: number of items: %u\n", bucket_size, lim);
 
 	/* Testing ao2_container_clone */
 	c3 = ao2_container_clone(c1, 0);

Modified: branches/11/tests/test_astobj2_thrash.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_astobj2_thrash.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_astobj2_thrash.c (original)
+++ branches/11/tests/test_astobj2_thrash.c Tue Jul 22 09:00:33 2014
@@ -82,7 +82,7 @@
 	if (keybuf == NULL) {
 		return NULL;
 	}
-	needed = snprintf(keybuf, buflen, "key%08x", i);
+	needed = snprintf(keybuf, buflen, "key%08x", (unsigned)i);
 	ast_atomic_fetchadd_int(&alloc_count, 1);
 	ast_assert(needed + 1 <= buflen);
 	return keybuf;

Modified: branches/11/tests/test_config.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_config.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_config.c (original)
+++ branches/11/tests/test_config.c Tue Jul 22 09:00:33 2014
@@ -885,19 +885,19 @@
 	arr[3] = item_defaults;
 	/* Test global and item against configs, global_defaults and item_defaults against defaults */
 
-#define NOT_EQUAL_FAIL(field)  \
+#define NOT_EQUAL_FAIL(field, format)  \
 	if (arr[x]->field != control->field) { \
-		ast_test_status_update(test, "%s did not match: %d != %d with x = %d\n", #field, arr[x]->field, control->field, x); \
+		ast_test_status_update(test, "%s did not match: " format " != " format " with x = %d\n", #field, arr[x]->field, control->field, x); \
 		res = AST_TEST_FAIL; \
 	}
 	for (x = 0; x < 4; x++) {
 		struct test_item *control = x < 2 ? &configs : &defaults;
 
-		NOT_EQUAL_FAIL(intopt);
-		NOT_EQUAL_FAIL(uintopt);
-		NOT_EQUAL_FAIL(boolopt);
-		NOT_EQUAL_FAIL(flags);
-		NOT_EQUAL_FAIL(customopt);
+		NOT_EQUAL_FAIL(intopt, "%d");
+		NOT_EQUAL_FAIL(uintopt, "%u");
+		NOT_EQUAL_FAIL(boolopt, "%d");
+		NOT_EQUAL_FAIL(flags, "%u");
+		NOT_EQUAL_FAIL(customopt, "%d");
 		if (fabs(arr[x]->doubleopt - control->doubleopt) > 0.001) {
 			ast_test_status_update(test, "doubleopt did not match: %f vs %f on loop %d\n", arr[x]->doubleopt, control->doubleopt, x);
 			res = AST_TEST_FAIL;

Modified: branches/11/tests/test_event.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_event.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_event.c (original)
+++ branches/11/tests/test_event.c Tue Jul 22 09:00:33 2014
@@ -66,7 +66,7 @@
 	/* Check #1: Ensure event type is set properly. */
 	type = ast_event_get_type(event);
 	if (ast_event_get_type(event) != type) {
-		ast_test_status_update(test, "Expected event type: '%d', got '%d'\n",
+		ast_test_status_update(test, "Expected event type: '%u', got '%u'\n",
 				expected_type, type);
 		return -1;
 	}
@@ -343,7 +343,7 @@
 	sub_res = ast_event_check_subscriber(AST_EVENT_CUSTOM,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "CUSTOM subscriptions should not exist! (%d)\n",
+		ast_test_status_update(test, "CUSTOM subscriptions should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -376,7 +376,7 @@
 	sub_res = ast_event_check_subscriber(AST_EVENT_CUSTOM,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_EXISTS) {
-		ast_test_status_update(test, "A CUSTOM subscription should exist! (%d)\n",
+		ast_test_status_update(test, "A CUSTOM subscription should exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -623,7 +623,7 @@
 		AST_EVENT_IE_DEVICE, AST_EVENT_IE_PLTYPE_STR, "Money",
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "Str Money subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "Str Money subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -641,7 +641,7 @@
 		AST_EVENT_IE_MAILBOX, AST_EVENT_IE_PLTYPE_RAW, "FOO/bar", sizeof("FOO/bar") - 1,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "Raw FOO/bar-1 subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "Raw FOO/bar-1 subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -650,7 +650,7 @@
 		AST_EVENT_IE_MAILBOX, AST_EVENT_IE_PLTYPE_RAW, "Monkeys", sizeof("Monkeys"),
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "Raw Monkeys subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "Raw Monkeys subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -668,7 +668,7 @@
 		AST_EVENT_IE_NEWMSGS, AST_EVENT_IE_PLTYPE_UINT, 1,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "UINT=1 subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "UINT=1 subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -686,7 +686,7 @@
 		AST_EVENT_IE_NEWMSGS, AST_EVENT_IE_PLTYPE_BITFLAGS, 8,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "BITFLAGS=8 subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "BITFLAGS=8 subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}
@@ -705,7 +705,7 @@
 		AST_EVENT_IE_NEWMSGS, AST_EVENT_IE_PLTYPE_UINT, 4,
 		AST_EVENT_IE_END);
 	if (sub_res != AST_EVENT_SUB_NONE) {
-		ast_test_status_update(test, "EXISTS subscription should not exist! (%d)\n",
+		ast_test_status_update(test, "EXISTS subscription should not exist! (%u)\n",
 			sub_res);
 		res = AST_TEST_FAIL;
 	}

Modified: branches/11/tests/test_format_api.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_format_api.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_format_api.c (original)
+++ branches/11/tests/test_format_api.c Tue Jul 22 09:00:33 2014
@@ -120,7 +120,7 @@
 			}
 			break;
 		default:
-			ast_log(LOG_WARNING, "unknown attribute type %d\n", key);
+			ast_log(LOG_WARNING, "unknown attribute type %u\n", key);
 		}
 	}
 }

Modified: branches/11/tests/test_hashtab_thrash.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_hashtab_thrash.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_hashtab_thrash.c (original)
+++ branches/11/tests/test_hashtab_thrash.c Tue Jul 22 09:00:33 2014
@@ -73,7 +73,7 @@
 	if (keybuf == NULL) {
 		return NULL;
 	}
-	needed = snprintf(keybuf, buflen, "key%08x", i);
+	needed = snprintf(keybuf, buflen, "key%08x", (unsigned)i);
 	ast_assert(needed + 1 <= buflen);
 	return keybuf;
 }

Modified: branches/11/tests/test_logger.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_logger.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_logger.c (original)
+++ branches/11/tests/test_logger.c Tue Jul 22 09:00:33 2014
@@ -55,12 +55,12 @@
 	unsigned int x;
 
 	for (x = 0; x < num_tests; x++) {
-		ast_cli(fd, "Test %d: %s\n", x + 1, tests[x].name);
-		ast_cli(fd, "\tExpected Successes: %d\n", tests[x].x_success);
-		ast_cli(fd, "\tExpected Failures: %d\n", tests[x].x_failure);
-		ast_cli(fd, "\tUnexpected Successes: %d\n", tests[x].u_success);
-		ast_cli(fd, "\tUnexpected Failures: %d\n", tests[x].u_failure);
-		ast_cli(fd, "Test %d Result: %s\n", x + 1, (tests[x].u_success + tests[x].u_failure) ? "FAIL" : "PASS");
+		ast_cli(fd, "Test %u: %s\n", x + 1, tests[x].name);
+		ast_cli(fd, "\tExpected Successes: %u\n", tests[x].x_success);
+		ast_cli(fd, "\tExpected Failures: %u\n", tests[x].x_failure);
+		ast_cli(fd, "\tUnexpected Successes: %u\n", tests[x].u_success);
+		ast_cli(fd, "\tUnexpected Failures: %u\n", tests[x].u_failure);
+		ast_cli(fd, "Test %u Result: %s\n", x + 1, (tests[x].u_success + tests[x].u_failure) ? "FAIL" : "PASS");
 	}
 }
 
@@ -88,11 +88,11 @@
 	}
 
 	for (test = 0; test < ARRAY_LEN(tests); test++) {
-		ast_cli(a->fd, "Test %d: %s.\n", test + 1, tests[test].name);
+		ast_cli(a->fd, "Test %u: %s.\n", test + 1, tests[test].name);
 		switch (test) {
 		case 0:
 			if ((level = ast_logger_register_level("test")) != -1) {
-				ast_cli(a->fd, "Test: got level %d\n", level);
+				ast_cli(a->fd, "Test: got level %u\n", level);
 				ast_log_dynamic_level(level, "Logger Dynamic Test: Test 1\n");
 				ast_logger_unregister_level("test");
 				tests[test].x_success++;
@@ -106,7 +106,7 @@
 			char level_name[18][8];
 
 			for (x = 0; x < ARRAY_LEN(level_name); x++) {
-				sprintf(level_name[x], "level%02d", x);
+				sprintf(level_name[x], "level%02u", x);
 				if ((level = ast_logger_register_level(level_name[x])) == -1) {
 					if (x < 16) {
 						tests[test].u_failure++;
@@ -115,7 +115,7 @@
 					}
 					level_name[x][0] = '\0';
 				} else {
-					ast_cli(a->fd, "Test: registered '%s', got level %d\n", level_name[x], level);
+					ast_cli(a->fd, "Test: registered '%s', got level %u\n", level_name[x], level);
 					if (x < 16) {
 						tests[test].x_success++;
 					} else {
@@ -159,7 +159,7 @@
 	}
 
 	for (test = 0; test < ARRAY_LEN(tests); test++) {
-		ast_cli(a->fd, "Test %d: %s.\n", test + 1, tests[test].name);
+		ast_cli(a->fd, "Test %u: %s.\n", test + 1, tests[test].name);
 		switch (test) {
 		case 0:
 			if ((level = ast_logger_register_level("perftest")) != -1) {
@@ -167,7 +167,7 @@
 				struct timeval start, end;
 				int elapsed;
 
-				ast_cli(a->fd, "Test: got level %d\n", level);
+				ast_cli(a->fd, "Test: got level %u\n", level);
 				start = ast_tvnow();
 				for (x = 0; x < 10000; x++) {
 					ast_log_dynamic_level(level, "Performance test log message\n");

Modified: branches/11/tests/test_voicemail_api.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/tests/test_voicemail_api.c?view=diff&rev=419162&r1=419161&r2=419162
==============================================================================
--- branches/11/tests/test_voicemail_api.c (original)
+++ branches/11/tests/test_voicemail_api.c Tue Jul 22 09:00:33 2014
@@ -87,7 +87,7 @@
  * object is test_mbox_snapshot
  */
 #define VM_API_STRING_FIELD_VERIFY(expected, actual) do { \
-	if (strncmp((expected), (actual), sizeof((expected)))) { \
+	if (strncmp((expected), (actual), strlen((expected)))) { \
 		ast_test_status_update(test, "Test failed for parameter %s: Expected [%s], Actual [%s]\n", #actual, expected, actual); \
 		VM_API_SNAPSHOT_TEST_CLEANUP; \
 		return AST_TEST_FAIL; \
@@ -97,7 +97,7 @@
  * that it assumes the mailbox snapshot object is test_mbox_snapshot */
 #define VM_API_INT_VERIFY(expected, actual) do { \
 	if ((expected) != (actual)) { \
-		ast_test_status_update(test, "Test failed for parameter %s: Expected [%d], Actual [%d]\n", #actual, expected, actual); \
+		ast_test_status_update(test, "Test failed for parameter %s: Expected [%d], Actual [%d]\n", #actual, (int)expected, (int)actual); \
 		VM_API_SNAPSHOT_TEST_CLEANUP; \
 		return AST_TEST_FAIL; \
 	} } while (0)
@@ -365,9 +365,9 @@
 	 */
 	snprintf(folder_path, sizeof(folder_path), "%s/voicemail/%s/%s/%s",
 		ast_config_AST_SPOOL_DIR, context, mailbox, snapshot->folder_name);
-	snprintf(msg_path, sizeof(msg_path), "%s/msg%04d.txt",
+	snprintf(msg_path, sizeof(msg_path), "%s/msg%04u.txt",
 		folder_path, snapshot->msg_number);
-	snprintf(snd_path, sizeof(snd_path), "%s/msg%04d.gsm",
+	snprintf(snd_path, sizeof(snd_path), "%s/msg%04u.gsm",
 		folder_path, snapshot->msg_number);
 	snprintf(beep_path, sizeof(beep_path), "%s/sounds/en/beep.gsm", ast_config_AST_VAR_DIR);
 
@@ -453,9 +453,9 @@
 	snprintf(folder_path, sizeof(folder_path), "%s/voicemail/%s/%s/%s",
 		ast_config_AST_SPOOL_DIR, "default", snapshot->exten, snapshot->folder_name);
 
-	snprintf(msg_path, sizeof(msg_path), "%s/msg%04d.txt",
+	snprintf(msg_path, sizeof(msg_path), "%s/msg%04u.txt",
 			folder_path, snapshot->msg_number);
-	snprintf(snd_path, sizeof(snd_path), "%s/msg%04d.gsm",
+	snprintf(snd_path, sizeof(snd_path), "%s/msg%04u.gsm",
 			folder_path, snapshot->msg_number);
 	unlink(msg_path);
 	unlink(snd_path);




More information about the asterisk-commits mailing list