[asterisk-commits] kmoore: branch group/media_formats-reviewed-trunk r418584 - /team/group/media...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Mon Jul 14 08:57:50 CDT 2014


Author: kmoore
Date: Mon Jul 14 08:57:45 2014
New Revision: 418584

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=418584
Log:
media formats: Fix format cache case sensitivity

This changes the format cache to be case insensitive which allows the
tests/channels/pjsip/video_calls/fast_picture_update integration test
to pass. It was failing in the media formats branch due to the "alice"
endpoint failing to load because codecs H261 and H263 were not
recognized.

Review: https://reviewboard.asterisk.org/r/3778/

Modified:
    team/group/media_formats-reviewed-trunk/main/format_cache.c

Modified: team/group/media_formats-reviewed-trunk/main/format_cache.c
URL: http://svnview.digium.com/svn/asterisk/team/group/media_formats-reviewed-trunk/main/format_cache.c?view=diff&rev=418584&r1=418583&r2=418584
==============================================================================
--- team/group/media_formats-reviewed-trunk/main/format_cache.c (original)
+++ team/group/media_formats-reviewed-trunk/main/format_cache.c Mon Jul 14 08:57:45 2014
@@ -251,10 +251,10 @@
 	switch (flags & OBJ_SEARCH_MASK) {
 	case OBJ_SEARCH_KEY:
 		key = obj;
-		return ast_str_hash(key);
+		return ast_str_case_hash(key);
 	case OBJ_SEARCH_OBJECT:
 		format = obj;
-		return ast_str_hash(ast_format_get_name(format));
+		return ast_str_case_hash(ast_format_get_name(format));
 	default:
 		/* Hash can only work on something with a full key. */
 		ast_assert(0);
@@ -274,10 +274,10 @@
 		right_key = ast_format_get_name(right);
 		/* Fall through */
 	case OBJ_SEARCH_KEY:
-		cmp = strcmp(ast_format_get_name(left), right_key);
+		cmp = strcasecmp(ast_format_get_name(left), right_key);
 		break;
 	case OBJ_SEARCH_PARTIAL_KEY:
-		cmp = strncmp(ast_format_get_name(left), right_key, strlen(right_key));
+		cmp = strncasecmp(ast_format_get_name(left), right_key, strlen(right_key));
 		break;
 	default:
 		ast_assert(0);




More information about the asterisk-commits mailing list