[asterisk-commits] kmoore: branch 12 r406775 - /branches/12/res/res_stasis_device_state.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Tue Jan 28 13:13:36 CST 2014


Author: kmoore
Date: Tue Jan 28 13:13:30 2014
New Revision: 406775

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=406775
Log:
ARI: Make double subscribe respond with success

Currently, attempting to subscribe an application to a device state
that it has already subscribed to will generate a 500 error response.
This will now be treated as a subscription refresh even though ARI
subscriptions don't currently support lifetimes and will respond with
the normal response for a successful subscription (200 OK).

(closes issue ASTERISK-23143)
Reported by: Matt Jordan

Modified:
    branches/12/res/res_stasis_device_state.c

Modified: branches/12/res/res_stasis_device_state.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/res/res_stasis_device_state.c?view=diff&rev=406775&r1=406774&r2=406775
==============================================================================
--- branches/12/res/res_stasis_device_state.c (original)
+++ branches/12/res/res_stasis_device_state.c Tue Jan 28 13:13:30 2014
@@ -326,8 +326,8 @@
 	ast_debug(3, "Subscribing to device %s", sub->device_name);
 
 	if (is_subscribed_device_state(app, sub->device_name)) {
-		ast_log(LOG_WARNING, "Already subscribed to %s\n", sub->device_name);
-		return -1;
+		ast_debug(3, "App %s is already subscribed to %s\n", stasis_app_name(app), sub->device_name);
+		return 0;
 	}
 
 	if (!(sub->sub = stasis_subscribe(




More information about the asterisk-commits mailing list