[asterisk-commits] rmudgett: branch 1.8 r407764 - /branches/1.8/channels/chan_iax2.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Feb 7 14:42:28 CST 2014


Author: rmudgett
Date: Fri Feb  7 14:42:26 2014
New Revision: 407764

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=407764
Log:
chan_iax2: Add some more iaxs[] NULL checks to a routine already full of them.

Modified:
    branches/1.8/channels/chan_iax2.c

Modified: branches/1.8/channels/chan_iax2.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/channels/chan_iax2.c?view=diff&rev=407764&r1=407763&r2=407764
==============================================================================
--- branches/1.8/channels/chan_iax2.c (original)
+++ branches/1.8/channels/chan_iax2.c Fri Feb  7 14:42:26 2014
@@ -11722,8 +11722,10 @@
 		fr->ts = (iaxs[fr->callno]->last & 0xFFFF0000L) | ntohs(mh->ts);
 		/* FIXME? Surely right here would be the right place to undo timestamp wraparound? */
 	}
+
 	/* Don't pass any packets until we're started */
-	if (!ast_test_flag(&iaxs[fr->callno]->state, IAX_STATE_STARTED)) {
+	if (!iaxs[fr->callno]
+		|| !ast_test_flag(&iaxs[fr->callno]->state, IAX_STATE_STARTED)) {
 		ast_variables_destroy(ies.vars);
 		ast_mutex_unlock(&iaxsl[fr->callno]);
 		return 1;
@@ -11740,7 +11742,8 @@
 		}
 		if (f.subclass.integer == AST_CONTROL_CONNECTED_LINE
 			|| f.subclass.integer == AST_CONTROL_REDIRECTING) {
-			if (!ast_test_flag64(iaxs[fr->callno], IAX_RECVCONNECTEDLINE)) {
+			if (iaxs[fr->callno]
+				&& !ast_test_flag64(iaxs[fr->callno], IAX_RECVCONNECTEDLINE)) {
 				/* We are not configured to allow receiving these updates. */
 				ast_debug(2, "Callno %u: Config blocked receiving control frame %d.\n",
 					fr->callno, f.subclass.integer);
@@ -11762,7 +11765,8 @@
 	}
 
 	if (f.frametype == AST_FRAME_CONTROL
-		&& f.subclass.integer == AST_CONTROL_CONNECTED_LINE) {
+		&& f.subclass.integer == AST_CONTROL_CONNECTED_LINE
+		&& iaxs[fr->callno]) {
 		struct ast_party_connected_line connected;
 
 		/*
@@ -11818,9 +11822,11 @@
 		fr->outoforder = -1;
 	}
 	fr->cacheable = ((f.frametype == AST_FRAME_VOICE) || (f.frametype == AST_FRAME_VIDEO));
-	duped_fr = iaxfrdup2(fr);
-	if (duped_fr) {
-		schedule_delivery(duped_fr, updatehistory, 0, &fr->ts);
+	if (iaxs[fr->callno]) {
+		duped_fr = iaxfrdup2(fr);
+		if (duped_fr) {
+			schedule_delivery(duped_fr, updatehistory, 0, &fr->ts);
+		}
 	}
 	if (iaxs[fr->callno] && iaxs[fr->callno]->last < fr->ts) {
 		iaxs[fr->callno]->last = fr->ts;




More information about the asterisk-commits mailing list