[asterisk-commits] rmudgett: branch 13 r429829 - in /branches/13: ./ channels/chan_dahdi.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Fri Dec 19 11:31:31 CST 2014


Author: rmudgett
Date: Fri Dec 19 11:31:28 2014
New Revision: 429829

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=429829
Log:
chan_dahdi: Don't ignore setvar when using configuration section scheme.

When the configuration section scheme of chan_dahdi.conf is used (keyword
dahdichan instead of channel) all setvar= options are completely ignored.
No variable defined this way appears in the created DAHDI channels.

* Move the clearing of setvar values to after the deferred processing of
dahdichan.

AST-1378 #close
Reported by: Guenther Kelleter
Patch by: Guenther Kelleter
........

Merged revisions 429825 from http://svn.asterisk.org/svn/asterisk/branches/11

Modified:
    branches/13/   (props changed)
    branches/13/channels/chan_dahdi.c

Propchange: branches/13/
------------------------------------------------------------------------------
--- branch-11-merged (original)
+++ branch-11-merged Fri Dec 19 11:31:28 2014
@@ -1,1 +1,1 @@
-/branches/11:1-429517,429539,429632,429783,429804
+/branches/11:1-429517,429539,429632,429783,429804,429825

Modified: branches/13/channels/chan_dahdi.c
URL: http://svnview.digium.com/svn/asterisk/branches/13/channels/chan_dahdi.c?view=diff&rev=429829&r1=429828&r2=429829
==============================================================================
--- branches/13/channels/chan_dahdi.c (original)
+++ branches/13/channels/chan_dahdi.c Fri Dec 19 11:31:28 2014
@@ -18927,12 +18927,6 @@
 			ast_log(LOG_WARNING, "Ignoring any changes to '%s' (on reload) at line %d.\n", v->name, v->lineno);
 	}
 
-	/* Since confp has already filled invidual dahdi_pvt objects with channels at this point, clear the variables in confp's pvt. */
-	if (confp->chan.vars) {
-		ast_variables_destroy(confp->chan.vars);
-		confp->chan.vars = NULL;
-	}
-
 	if (dahdichan) {
 		/* Process the deferred dahdichan value. */
 		if (build_channels(confp, dahdichan->value, reload, dahdichan->lineno)) {
@@ -18944,6 +18938,15 @@
 				return -1;
 			}
 		}
+	}
+
+	/*
+	 * Since confp has already filled individual dahdi_pvt objects with channels
+	 * at this point, clear the variables in confp's pvt.
+	 */
+	if (confp->chan.vars) {
+		ast_variables_destroy(confp->chan.vars);
+		confp->chan.vars = NULL;
 	}
 
 	/* mark the first channels of each DAHDI span to watch for their span alarms */




More information about the asterisk-commits mailing list