[asterisk-commits] r411702 - svn:log

[SVN commits to the Asterisk project]

Author: rmudgett
Revision: 411702
Modified property: svn:log

Modified: svn:log at Fri Apr  4 13:42:02 2014
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Fri Apr  4 13:42:02 2014
@@ -1,33 +1,20 @@
-internal_timing: Remove the option and always make it enabled if a timing module is loaded.
+Add some asserts that were handy when looking for a stasis cache problem.
 
-The masquerade supertest frequently fails because either the local channel
-chain doesn't completely optimize out or the DTMF handshake doesn't
-completely get accross.  Local channel optimization requires frames
-flowing to trigger when optimization can happen.  When optimization
-happens the media frame that triggered the optimization is dropped.
-Sending DTMF requires frames to flow in the other direction for timing
-purposes while sending nothing.  If internal timing is not enabled when
-MOH is playing, Asterisk switches to received timing when an audio frame
-is received.  With optimization dropping media frames and MOH not sending
-frames unless it receives frames, occasionaly there are no more frames
-being passed and the test fails.
+* Assert if a channel is destroyed but has the snapshot staging flag set.
+In this case the final channel destruction snapshot would never get taken.
 
-* The asterisk command line -I option and the asterisk.conf
-internal_timing option are removed.  Asterisk now always uses internal
-timing when needed if any timing module is loaded.  The issue
-ASTERISK-14861 did this quite awhile ago in v1.4 but effectively is broken
-if other internal timing modules besides DAHDI are used.  The
-ast_read_generator_actions() now only does received timing if it has no
-choice for frame generators like MOH, silence, and playback streaming.
+* Assert if what we just got out of the stasis cache is not what we were
+looking for.  This assert would have saved several days searching for a
+bug and a lot of my hair.
 
-* Cleaned up some code dealing with frame generators in
-ast_deactivate_generator(), generator_write_format_change(),
-ast_activate_generator(), and ast_channel_stop_silence_generator().
+* Assert if the music on hold message posts could not find the associated
+channel.  A crash will happen later when manager tries to send the MOH AMI
+message.  This assert catches the problem when the stasis message is
+posted instead of by the thread processing the defective message.
 
-ASTERISK-22846 #close
-Reported by: Matt Jordan
+* Always generate a backtrace when an ast_assert() fails.
 
-Review: https://reviewboard.asterisk.org/r/3414/
+Review: https://reviewboard.asterisk.org/r/3411/
 ........
 
-Merged revisions 411715 from http://svn.asterisk.org/svn/asterisk/branches/1.8
+Merged revisions 411701 from http://svn.asterisk.org/svn/asterisk/branches/12