[asterisk-commits] rmudgett: branch 12 r399596 - /branches/12/main/media_index.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri Sep 20 20:46:16 2013
New Revision: 399596

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=399596
Log:
media_index: Fix process_description_file() memory leak of file_id_persist.

Modified:
    branches/12/main/media_index.c

Modified: branches/12/main/media_index.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/main/media_index.c?view=diff&rev=399596&r1=399595&r2=399596
==============================================================================
--- branches/12/main/media_index.c (original)
+++ branches/12/main/media_index.c Fri Sep 20 20:46:16 2013
@@ -439,6 +439,7 @@
 			/* if there's text in cumulative_description, archive it and start anew */
 			if (file_id_persist && !ast_strlen_zero(ast_str_buffer(cumulative_description))) {
 				RAII_VAR(struct media_variant *, variant, NULL, ao2_cleanup);
+
 				variant = find_variant(index, file_id_persist, variant_str);
 				if (!variant) {
 					variant = alloc_variant(index, file_id_persist, variant_str);
@@ -451,11 +452,10 @@
 				ast_string_field_set(variant, description, ast_str_buffer(cumulative_description));
 
 				ast_str_reset(cumulative_description);
-				ast_free(file_id_persist);
-				file_id_persist = NULL;
-			}
-
-			file_id_persist = strdup(file_identifier);
+			}
+
+			ast_free(file_id_persist);
+			file_id_persist = ast_strdup(file_identifier);
 			description = ast_skip_blanks(description);
 			ast_str_set(&cumulative_description, 0, "%s", description);
 		}
@@ -464,6 +464,7 @@
 	/* handle the last one */
 	if (file_id_persist && !ast_strlen_zero(ast_str_buffer(cumulative_description))) {
 		RAII_VAR(struct media_variant *, variant, NULL, ao2_cleanup);
+
 		variant = find_variant(index, file_id_persist, variant_str);
 		if (!variant) {
 			variant = alloc_variant(index, file_id_persist, variant_str);
@@ -471,12 +472,12 @@
 
 		if (variant) {
 			ast_string_field_set(variant, description, ast_str_buffer(cumulative_description));
-			ast_free(file_id_persist);
 		} else {
 			res = -1;
 		}
 	}
 
+	ast_free(file_id_persist);
 	fclose(f);
 	return res;
 }