[asterisk-commits] rmudgett: branch rmudgett/bridge_phase r383118 - /team/rmudgett/bridge_phase/...

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Thu Mar 14 19:10:52 2013
New Revision: 383118

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=383118
Log:
Add notes about bridge hooks coverting to ao2.

Modified:
    team/rmudgett/bridge_phase/include/asterisk/bridging_features.h

Modified: team/rmudgett/bridge_phase/include/asterisk/bridging_features.h
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/bridge_phase/include/asterisk/bridging_features.h?view=diff&rev=383118&r1=383117&r2=383118
==============================================================================
--- team/rmudgett/bridge_phase/include/asterisk/bridging_features.h (original)
+++ team/rmudgett/bridge_phase/include/asterisk/bridging_features.h Thu Mar 14 19:10:52 2013
@@ -156,9 +156,8 @@
 	unsigned int seqno;
 };
 
-/*!
- * \brief Structure that is the essence of a feature hook.
- */
+/* BUGBUG ast_bridge_hook needs to be turned into ao2 objects so bridge push/pulls can add/remove hooks */
+/*! \brief Structure that is the essence of a feature hook. */
 struct ast_bridge_hook {
 	/*! Linked list information */
 	AST_LIST_ENTRY(ast_bridge_hook) entry;
@@ -183,10 +182,13 @@
  * \brief Structure that contains features information
  */
 struct ast_bridge_features {
+/* BUGBUG dtmf_hooks needs to be an ao2_container so it would be possible to iterate without keeping a lock */
 	/*! Attached DTMF feature hooks */
 	AST_LIST_HEAD_NOLOCK(, ast_bridge_hook) dtmf_hooks;
+/* BUGBUG hangup_hooks needs to be an ao2_container so it would be possible to iterate without keeping a lock */
 	/*! Attached hangup interception hooks */
 	AST_LIST_HEAD_NOLOCK(, ast_bridge_hook) hangup_hooks;
+/* BUGBUG use of interval_hooks needs to be made ao2 safe */
 	/*! Attached interval hooks */
 	struct ast_heap *interval_hooks;
 	/*! Used to determine when interval based features should be checked */
@@ -207,7 +209,6 @@
 	unsigned int usable:1;
 	/*! TRUE if the channel/bridge is muted. */
 	unsigned int mute:1;
-/* BUGBUG why is dtmf_passthrough not a feature_flags bit? */
 	/*! TRUE if DTMF should be passed into the bridge tech.  */
 	unsigned int dtmf_passthrough:1;
 };