[asterisk-commits] rmudgett: branch rmudgett/bridge_phase r382777 - in /team/rmudgett/bridge_pha...

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri Mar  8 19:42:13 2013
New Revision: 382777

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=382777
Log:
Add more notes.

Modified:
    team/rmudgett/bridge_phase/bridges/bridge_softmix.c
    team/rmudgett/bridge_phase/main/bridging.c

Modified: team/rmudgett/bridge_phase/bridges/bridge_softmix.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/bridge_phase/bridges/bridge_softmix.c?view=diff&rev=382777&r1=382776&r2=382777
==============================================================================
--- team/rmudgett/bridge_phase/bridges/bridge_softmix.c (original)
+++ team/rmudgett/bridge_phase/bridges/bridge_softmix.c Fri Mar  8 19:42:13 2013
@@ -756,7 +756,8 @@
 	unsigned int stat_iteration_counter = 0; /* counts down, gather stats at zero and reset. */
 	int timingfd;
 	int update_all_rates = 0; /* set this when the internal sample rate has changed */
-	int i, x;
+	int i;
+	int x;
 	int res = -1;
 
 	softmix_data = bridge->bridge_pvt;
@@ -867,6 +868,7 @@
 
 			/* process the softmix channel's new write audio */
 			softmix_process_write_audio(&trans_helper, ast_channel_rawwriteformat(bridge_channel->chan), sc);
+/* BUGBUG need to put the frame on the bridge_channel write queue. */
 
 			/* The frame is now ready for use... */
 			sc->have_frame = 1;
@@ -923,6 +925,7 @@
 	.destroy = softmix_bridge_destroy,
 	.join = softmix_bridge_join,
 	.leave = softmix_bridge_leave,
+/* BUGBUG need suspend/unsuspend to keep track of num active channels in bridge.  Then softmix mixing thread can wake up when there are channels in the bridge. */
 	.write = softmix_bridge_write,
 	.thread_loop = softmix_bridge_thread,
 	.poke_channel = softmix_bridge_poke_channel,

Modified: team/rmudgett/bridge_phase/main/bridging.c
URL: http://svnview.digium.com/svn/asterisk/team/rmudgett/bridge_phase/main/bridging.c?view=diff&rev=382777&r1=382776&r2=382777
==============================================================================
--- team/rmudgett/bridge_phase/main/bridging.c (original)
+++ team/rmudgett/bridge_phase/main/bridging.c Fri Mar  8 19:42:13 2013
@@ -1562,6 +1562,7 @@
 			bridge_handle_hangup(bridge, bridge_channel);
 		}
 	} else {
+/* BUGBUG Check the features.dtmf_passthrough flag just like ast_bridge_handle_trip() before passing on the collected digits. */
 		ast_bridge_dtmf_stream(bridge, dtmf, bridge_channel->chan);
 	}
 }
@@ -2463,6 +2464,7 @@
 
 void ast_bridge_technology_unsuspend(struct ast_bridge_technology *technology)
 {
+/* BUGBUG unsuspending a bridge technology probably needs to prod all existing bridges to see if they should start using it. */
 	technology->suspended = 0;
 }