[asterisk-commits] rmudgett: branch group/bridge_construction r382744 - in /team/group/bridge_co...

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri Mar  8 14:23:59 2013
New Revision: 382744

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=382744
Log:
Add holding bridge tech and BridgeWait app enhancement notes.

Modified:
    team/group/bridge_construction/apps/app_bridgewait.c
    team/group/bridge_construction/bridges/bridge_holding.c

Modified: team/group/bridge_construction/apps/app_bridgewait.c
URL: http://svnview.digium.com/svn/asterisk/team/group/bridge_construction/apps/app_bridgewait.c?view=diff&rev=382744&r1=382743&r2=382744
==============================================================================
--- team/group/bridge_construction/apps/app_bridgewait.c (original)
+++ team/group/bridge_construction/apps/app_bridgewait.c Fri Mar  8 14:23:59 2013
@@ -85,6 +85,13 @@
 		</description>
 	</application>
  ***/
+/* BUGBUG Add bridge name/id parameter to specify which holding bridge to join (required) */
+/* BUGBUG Add h(moh-class) option to put channel on hold using AST_CONTROL_HOLD/AST_CONTROL_UNHOLD while in bridge */
+/* BUGBUG Add s option to send silence media frames to channel while in bridge (uses a silence generator) */
+/* BUGBUG Add n option to send no media to channel while in bridge (Channel should not be answered yet) */
+/* BUGBUG The channel may or may not be answered with the r option. */
+/* BUGBUG You should not place an announcer into a holding bridge with unanswered channels. */
+/* BUGBUG Not supplying any option flags will assume the m option with the default music class. */
 
 static char *app = "BridgeWait";
 static struct ast_bridge *holding_bridge;

Modified: team/group/bridge_construction/bridges/bridge_holding.c
URL: http://svnview.digium.com/svn/asterisk/team/group/bridge_construction/bridges/bridge_holding.c?view=diff&rev=382744&r1=382743&r2=382744
==============================================================================
--- team/group/bridge_construction/bridges/bridge_holding.c (original)
+++ team/group/bridge_construction/bridges/bridge_holding.c Fri Mar  8 14:23:59 2013
@@ -54,6 +54,9 @@
 	HOLDING_ROLE_ANNOUNCER = (1 << 1),
 };
 
+/* BUGBUG Add IDLE_MODE_HOLD option to put channel on hold using AST_CONTROL_HOLD/AST_CONTROL_UNHOLD while in bridge */
+/* BUGBUG Add IDLE_MODE_SILENCE to send silence media frames to channel while in bridge (uses a silence generator) */
+/* BUGBUG A channel without the holding_participant role will assume IDLE_MODE_MOH with the default music class. */
 enum idle_modes {
 	IDLE_MODE_NONE = 0,
 	IDLE_MODE_MOH,