[asterisk-commits] mmichelson: branch mmichelson/atxfer_features r392932 - /team/mmichelson/atxf...

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Tue Jun 25 18:49:16 CDT 2013


Author: mmichelson
Date: Tue Jun 25 18:49:14 2013
New Revision: 392932

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=392932
Log:
Fix channel refleak.

I accidentally introduced a fix in the last revision twice. With this
change, I believe I have no further refleaks when performing a
straightforward attended transfer. I am happy.


Modified:
    team/mmichelson/atxfer_features/main/bridging_basic.c

Modified: team/mmichelson/atxfer_features/main/bridging_basic.c
URL: http://svnview.digium.com/svn/asterisk/team/mmichelson/atxfer_features/main/bridging_basic.c?view=diff&rev=392932&r1=392931&r2=392932
==============================================================================
--- team/mmichelson/atxfer_features/main/bridging_basic.c (original)
+++ team/mmichelson/atxfer_features/main/bridging_basic.c Tue Jun 25 18:49:14 2013
@@ -1295,11 +1295,6 @@
 		return 0;
 	}
 
-	/* We increase the refcount of the transfer target because ast_bridge_impart() will
-	 * steal the reference we already have. We need to keep a reference, so the only
-	 * choice is to give it a bump
-	 */
-	ast_channel_ref(props->transfer_target);
 	if (ast_bridge_impart(props->target_bridge, props->transfer_target, NULL, NULL, 1)) {
 		ast_log(LOG_ERROR, "Unable to place transfer target into bridge\n");
 		ast_stream_and_wait(bridge_channel->chan, props->failsound, AST_DIGIT_NONE);




More information about the asterisk-commits mailing list