[asterisk-commits] file: branch file/stasis_peerevent r391602 - in /team/file/stasis_peerevent: ...
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Thu Jun 13 06:19:14 CDT 2013
Author: file
Date: Thu Jun 13 06:18:44 2013
New Revision: 391602
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=391602
Log:
Multiple revisions 389202,389204,389217,389246-389247,389251,389306,389343,389378,389402,389426,389454,389492,389505,389519,389551,389567-389569,389587,389603,389609,389618,389623,389639,389663,389680,389733,389738,389746,389748,389770,389785,389799,389813,389827,389848,389869-389870,389897,389974,389990,390042,390068,390122,390154,390180,390230,390249-390250,390268,390289,390291,390317,390352,390398,390439-390440,390472-390473,390510,390525,390550,390584-390585,390612-390613,390639,390669,390698,390701,390728-390730,390733-390734,390751,390771,390787,390803-390804,390830,390848-390849,390864,390885,390901,390920,390940,390956-390957,390975,390991,391012,391016,391040,391064,391102,391112,391154,391199,391245,391269,391271,391297,391314,391335,391380,391403,391430,391453,391455,391479,391521,391561,391596
........
r389202 | kmoore | 2013-05-20 10:45:50 -0300 (Mon, 20 May 2013) | 8 lines
Add documentation for record_file_append
When this option was added, it was noted in CHANGES, but was missing
the XML documentation that this patch adds.
(closes issue ASTERISK-21780)
Patch-by: Brad Latus (snuffy)
........
r389204 | file | 2013-05-20 11:02:37 -0300 (Mon, 20 May 2013) | 2 lines
In Sorcery pass the name of the object being allocated to the allocator.
........
r389217 | kmoore | 2013-05-20 11:21:39 -0300 (Mon, 20 May 2013) | 5 lines
Add missing exports file
This exposes stasis_app_control_answer and allows
res_stasis_http_channels to load properly.
........
r389246 | qwell | 2013-05-20 14:44:41 -0300 (Mon, 20 May 2013) | 8 lines
Add doxygen.log to svn:ignore property.
........
Merged revisions 389244 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 389245 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r389247 | rmudgett | 2013-05-20 14:53:24 -0300 (Mon, 20 May 2013) | 1 line
Fixup svn:keywords in all *.c and *.h files.
........
r389251 | rmudgett | 2013-05-20 15:03:22 -0300 (Mon, 20 May 2013) | 1 line
Fixup svn:keywords in all *.c and *.h files.
........
r389306 | mjordan | 2013-05-20 16:24:16 -0300 (Mon, 20 May 2013) | 6 lines
Set the AST_CDR_FLAG_ORIGINATED flag on originated channel's CDRs
This may alleviate some of the CDR woes with originated channels, as CDRs
do like to know when a channel was originated. Eventually this will get
converted to be a channel flag, so its location is still good to know
post the great CDR shakeup of 2013.
........
r389343 | dlee | 2013-05-21 11:17:24 -0300 (Tue, 21 May 2013) | 1 line
Fixed some extra field assertion when the event WebSocket is connected
........
r389378 | rmudgett | 2013-05-21 15:00:22 -0300 (Tue, 21 May 2013) | 10 lines
Merge in the bridge_construction branch to make the system use the Bridging API.
Breaks many things until they can be reworked. A partial list:
chan_agent
chan_dahdi, chan_misdn, chan_iax2 native bridging
app_queue
COLP updates
DTMF attended transfers
Protocol attended transfers
........
r389402 | mjordan | 2013-05-21 15:45:57 -0300 (Tue, 21 May 2013) | 10 lines
Raise the ConfBridgeMute/Unmute events when a CLI or AMI action triggers the change
New in 12 are the ConfBridgeMute/Unmute events, which are triggered when a user
changes their mute/unmute state. This was typically triggered when a user hit a
DTMF key that triggered the mute/unmute menu handler. Forgotten in this is when an
AMI action or CLI command triggers the mute/unmute. This patch now raises the
events in those situations as well.
(closes issue ASTERISK-21802)
Reported by: Birger "WIMPy" Harzenetter
........
r389426 | rmudgett | 2013-05-21 18:08:19 -0300 (Tue, 21 May 2013) | 5 lines
Conditional out more app_queue logging that needs to be reworked.
Fixes crash because app_queue was unconditionally freeing a datastore that
was still on a channel.
........
r389454 | dlee | 2013-05-21 19:49:23 -0300 (Tue, 21 May 2013) | 1 line
Fix destruction order assert for stasis_bridging
........
r389492 | qwell | 2013-05-22 15:11:57 -0300 (Wed, 22 May 2013) | 9 lines
Add dial events to app_queue and app_followme.
Also fixes an issue in app_dial, where the channels were swapped on dial events.
(closes issue ASTERISK-21551)
(closes issue ASTERISK-21550)
Review: https://reviewboard.asterisk.org/r/2549/
........
r389505 | qwell | 2013-05-22 15:20:53 -0300 (Wed, 22 May 2013) | 1 line
Remove bad props, before anybody notices.
........
r389519 | dlee | 2013-05-22 16:15:16 -0300 (Wed, 22 May 2013) | 7 lines
Fixed startup race condition which caused occasional stasis_mwi_state_type assertions.
The caching topic (which refers to the message type) was created before the
message type. If the initial subscription message gets processed before
the type can be initialized, the assertion about using an uninitialized type
fires.
........
r389551 | file | 2013-05-23 12:51:05 -0300 (Thu, 23 May 2013) | 2 lines
Fix a bug where the codec order as configured was not being obeyed.
........
r389567 | file | 2013-05-23 15:19:27 -0300 (Thu, 23 May 2013) | 2 lines
Fix a bug with applying the end result of the codec negotiation to the Asterisk channel.
........
r389568 | file | 2013-05-23 15:39:05 -0300 (Thu, 23 May 2013) | 2 lines
Fix a bug where the DTMF mode was not set on newly created RTP instances in the res_sip_sdp_rtp module.
........
r389569 | rmudgett | 2013-05-23 15:40:50 -0300 (Thu, 23 May 2013) | 1 line
Fix inverted test preventing DTMF disconnect from working.
........
r389587 | dlee | 2013-05-23 17:11:35 -0300 (Thu, 23 May 2013) | 18 lines
This patch implements the REST API's for POST /channels/{channelId}/play
and GET /playback/{playbackId}.
This allows an external application to initiate playback of a sound on a
channel while the channel is in the Stasis application.
/play commands are issued asynchronously, and return immediately with
the URL of the associated /playback resource. Playback commands queue up,
playing in succession. The /playback resource shows the state of a
playback operation as enqueued, playing or complete. (Although the
operation will only be in the 'complete' state for a very short time,
since it is almost immediately freed up).
(closes issue ASTERISK-21283)
(closes issue ASTERISK-21586)
Review: https://reviewboard.asterisk.org/r/2531/
........
r389603 | dlee | 2013-05-23 17:21:16 -0300 (Thu, 23 May 2013) | 18 lines
This patch adds support for controlling a playback operation from the
Asterisk REST interface.
This adds the /playback/{playbackId}/control resource, which may be
POSTed to to pause, unpause, reverse, forward or restart the media
playback.
Attempts to control a playback that is not currently playing will
either return a 404 Not Found (because the playback object no longer
exists) or a 409 Conflict (because the playback object is still in the
queue to be played).
This patch also adds skipms and offsetms parameters to the
/channels/{channelId}/play resource.
(closes issue ASTERISK-21587)
Review: https://reviewboard.asterisk.org/r/2559
........
r389609 | file | 2013-05-23 17:25:48 -0300 (Thu, 23 May 2013) | 8 lines
Fix a crash due to the INVITE session being destroyed before the session.
This change ensures that the INVITE session remains valid for the lifetime
of the session object itself by increasing the session count on the dialog that
the INVITE session is allocated from. Once this reaches zero (normally as a result
of decrementing it within the session destructor) the dialog, and INVITE session,
are destroyed.
........
r389618 | jrose | 2013-05-23 17:48:41 -0300 (Thu, 23 May 2013) | 9 lines
res_parking: Fix some simple bugs
Both of them are covered in the dynamic parking review on
https://reviewboard.asterisk.org/r/2550 - Remove unref against
parking lot that the bridge did on dissolve since the reference
wasn't taken in the first place. On a swap, reapply bridge roles
in order to get music on hold and such playing on the channel that
swaps into the bridge.
........
r389623 | jrose | 2013-05-23 18:11:18 -0300 (Thu, 23 May 2013) | 2 lines
res_parking: Add a verbose message when a channel is parked
........
r389639 | dlee | 2013-05-23 18:46:38 -0300 (Thu, 23 May 2013) | 1 line
stasis-http: Provide a response body for 201 created responses
........
r389663 | igorg | 2013-05-24 07:23:48 -0300 (Fri, 24 May 2013) | 10 lines
Fix several problems caused by multiple line usage with i2004 phones.
Reported by: Daniel Bohling, MihaiMircea
(closes issue ASTERISK-21061)
(closes issue ASTERISK-21120)
........
Merged revisions 389661 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r389680 | mjordan | 2013-05-24 08:57:48 -0300 (Fri, 24 May 2013) | 18 lines
Print all logger messages on shutdown
When Asterisk shuts down and shuts down the loggin gsubsystem, any
messages currently in flight will not get logged. This patch prevents the
loop writing messages from breaking out prematurely, such that all of the
messages are logged.
(closes issue ASTERISK-21716)
Reported by: Corey Farrell
patches:
logger-process-all-messages.patch uploaded by Corey Farrell (license 5909)
........
Merged revisions 389676 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 389677 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r389733 | mjordan | 2013-05-24 17:44:07 -0300 (Fri, 24 May 2013) | 20 lines
Migrate a large number of AMI events over to Stasis-Core
This patch moves a number of AMI events over to the Stasis-Core message bus.
This includes:
* ChanSpyStart/Stop
* MonitorStart/Stop
* MusicOnHoldStart/Stop
* FullyBooted/Reload
* All Voicemail/MWI related events
In addition, it adds some Stasis-Core and AMI support for generic AMI messages,
refactors the message router in AMI to use a single router with topic
forwarding for the topics that AMI cares about, and refactors MWI message
types and topics to be more name compliant.
Review: https://reviewboard.asterisk.org/r/2532
(closes issue ASTERISK-21462)
........
r389738 | kmoore | 2013-05-24 18:01:30 -0300 (Fri, 24 May 2013) | 5 lines
Remove a junk define
BLOB_HANDLER_BUCKETS is a remnant of using "type" fields in
JSON/snapshot blobs and is no longer used.
........
r389746 | qwell | 2013-05-24 18:21:25 -0300 (Fri, 24 May 2013) | 5 lines
Split Hold event into Hold/Unhold, and move it into core.
(closes issue ASTERISK-21487)
Review: https://reviewboard.asterisk.org/r/2565/
........
r389748 | qwell | 2013-05-24 18:23:19 -0300 (Fri, 24 May 2013) | 1 line
grr, props.
........
r389770 | mjordan | 2013-05-25 14:41:25 -0300 (Sat, 25 May 2013) | 4 lines
Restore initialization of security topics
During a merge the security topic initialization got blown away.
This patch restores it.
........
r389785 | mjordan | 2013-05-26 01:47:17 -0300 (Sun, 26 May 2013) | 12 lines
Fix a variety of memory corruption/assertion errors
* Initialize a Stasis-Core message type prior to initializing a caching topic.
The caching topic will attempt to use the message type.
* Don't attempt to publish Stasis-Core messages from remote console connections.
They aren't the main process; they shouldn't attempt to behave as it (they also
don't have the infrastructure to do so)
* Don't treat a JSON object as an ao2 object (whoops)
* In asterisk.c, ref bump the JSON even package that is distributed with the
event meta data. The callers assume that they own the reference, and the packing
routine steals references.
........
r389799 | mjordan | 2013-05-26 13:49:28 -0300 (Sun, 26 May 2013) | 11 lines
Fix a few fax gateway failures
Fax gateway requires knowledge of a channel's peer in a bridge. This patch
now uses the supported mechanisms to get this information.
This is acceptable for a few reasons:
* Fax gateway can only ever work in a 2-party bridge
* Fax gateway cannot work when not in a bridge
* Fax gateway cannot work without knowledge of the capabilities of both
channels in the fax operation (it is, after all, a gateway)
........
r389813 | mjordan | 2013-05-26 21:06:40 -0300 (Sun, 26 May 2013) | 5 lines
Initialize the message type before the topic
Caching topics will during initialization attempt to reference
their message type. The message type therefore has to be
initialized prior to the topic to prevent the dreaded assertion.
........
r389827 | mjordan | 2013-05-26 22:33:12 -0300 (Sun, 26 May 2013) | 14 lines
Fix some more fax test errors due to needing the peer in a bridge
In r389799, a number of fax errors in gateway mode were fixed by using the
appropriate function to get a channel's peer while in a bridge. This patch
does two things:
(1) It uses the same function in res_fax_spandsp while starting the fax
gateway. Without this, the fax gateway will not actually start up, as
res_fax_spandsp also must inspect the channel's peer in a two-party
bridge
(2) It refactors some ao2 objects in sendfax_exec to use RAII_VAR. This was
reverted in r389799 as some off nominal paths were getting hit without
the fix in (1) that indicated an ao2 object issue; this turned out to
be a red herring (which is an odd phrase)
........
r389848 | mmichelson | 2013-05-28 11:45:31 -0300 (Tue, 28 May 2013) | 18 lines
Adds support for a core attended transfer function plus adds some hiding of masquerades.
The attended transfer API call can complete the attended transfer in a number of ways
depending on the current bridged states of the channels involved.
The hiding of masquerades is done in some bridging-related functions, such as the manager
Bridge action and the Bridge dialplan application. In addition, call pickup was edited
to "move" a channel rather than masquerade it.
Review: https://reviewboard.asterisk.org/r/2511
(closes issue ASTERISK-21334)
Reported by Matt Jordan
(closes issue Asterisk-21336)
Reported by Matt Jordan
........
r389869 | mmichelson | 2013-05-28 12:26:15 -0300 (Tue, 28 May 2013) | 10 lines
Add attended transfer support for chan_sip.c
This now uses the core API for performing attended transfers.
Review https://reviewboard.asterisk.org/r/2513
(Closes issue ASTERISK-21520)
reported by Matt Jordan
........
r389870 | mmichelson | 2013-05-28 12:54:53 -0300 (Tue, 28 May 2013) | 3 lines
Add missing NULL check to acquire_bridge() function.
........
r389897 | jrose | 2013-05-28 14:47:29 -0300 (Tue, 28 May 2013) | 14 lines
Fix a memory copying bug in slinfactory which was causing mixmonitor issues.
Reported by: Michael Walton
Tested by: Jonathan Rose
Patches:
slinfactory.c.ASTERISK-21799.patch uploaded by Michael Walton (license 6502)
(closes issue ASTERISK-21799)
........
Merged revisions 389895 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 389896 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r389974 | kmoore | 2013-05-28 23:26:17 -0300 (Tue, 28 May 2013) | 9 lines
Resolve a merge conflict
When ast_channel_cached_blob_create was merged,
ast_channel_blob_create_from_cache was partially removed in an
unresolved merge conflict. This restores ast_channel_blob_create_from_cache
and refactors usage of ast_channel_cached_blob_create (requires an
ast_channel) to use ast_channel_blob_create_from_cache (requires a
channel uniqueid) instead.
........
r389990 | mjordan | 2013-05-29 00:22:04 -0300 (Wed, 29 May 2013) | 5 lines
Pack the right number of items into the status and receive fax blobs
The code was still attempting to pack an additional item into the blobs
that didn't exist. Crashes ensued. This patch modifies the publishing of
these messages so that the correct number of items are packed in the JSON.
........
r390042 | qwell | 2013-05-29 16:54:01 -0300 (Wed, 29 May 2013) | 1 line
Remove unused RAII vars.
........
r390068 | rmudgett | 2013-05-29 17:24:18 -0300 (Wed, 29 May 2013) | 18 lines
Fix segfault when dealing with chan_agent channels.
Check the returned bridged pointer for NULL to avoid a crash. It looks
like chan_agent is returning a NULL pointer when it probably should be
returning a pointer to the channel the Agent channel is pretending to be.
(closes issue ASTERISK-21793)
Reported by: Rodrigo P. Telles
Patches:
jira_asterisk_21793_v1.8.patch (license #5621) patch uploaded by rmudgett
Tested by: Rodrigo P. Telles
........
Merged revisions 390044 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 390047 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r390122 | dlee | 2013-05-30 14:05:53 -0300 (Thu, 30 May 2013) | 34 lines
Avoid unnecessary cleanups during immediate shutdown
This patch addresses issues during immediate shutdowns, where modules
are not unloaded, but Asterisk atexit handlers are run.
In the typical case, this usually isn't a big deal. But the
introduction of the Stasis message bus makes it much more likely for
asynchronous activity to be happening off in some thread during
shutdown.
During an immediate shutdown, Asterisk skips unloading modules. But
while it is processing the atexit handlers, there is a window of time
where some of the core message types have been cleaned up, but the
message bus is still running. Specifically, it's still running
module subscriptions that might be using the core message types. If a
message is received by that subscription in that window, it will
attempt to use a message type that has been cleaned up.
To solve this problem, this patch introduces ast_register_cleanup().
This function operates identically to ast_register_atexit(), except
that cleanup calls are not invoked on an immediate shutdown. All of
the core message type and topic cleanup was moved from atexit handlers
to cleanup handlers.
This ensures that core type and topic cleanup only happens if the
modules that used them are first unloaded.
This patch also changes the ast_assert() when accessing a cleaned up
or uninitialized message type to an error log message. Message type
functions are actually NULL safe across the board, so the assert was a
bit heavy handed. Especially for anyone with DO_CRASH enabled.
Review: https://reviewboard.asterisk.org/r/2562/
........
r390154 | dlee | 2013-05-30 16:23:53 -0300 (Thu, 30 May 2013) | 1 line
Missed a line from a bad merge in r390122
........
r390180 | wdoekes | 2013-05-31 04:57:28 -0300 (Fri, 31 May 2013) | 4 lines
Let find do its own globbing.
Previously a stray .c file would cause xmldocs to not get built.
........
r390230 | may | 2013-05-31 07:42:19 -0300 (Fri, 31 May 2013) | 27 lines
Multiple revisions 390228-390229
........
r390228 | may | 2013-05-31 14:19:52 +0400 (Fri, 31 May 2013) | 14 lines
reject call attempts when gatekeeper is configured but not registered
(closes issue ASTERISK-21800)
Reported by: Dmitry Melekhov
Patches:
ASTERISK-21800-1.patch
Tested by: Dmitry Melekhov
........
Merged revisions 390181 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 390223 from http://svn.asterisk.org/svn/asterisk/branches/10
........
r390229 | may | 2013-05-31 14:34:20 +0400 (Fri, 31 May 2013) | 4 lines
remove unnecessary declarations
(issue ASTERISK-21800)
........
Merged revisions 390228-390229 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r390249 | kmoore | 2013-05-31 09:27:29 -0300 (Fri, 31 May 2013) | 8 lines
Add snapshot cache that indexes by channel name
This adds a new channel snapshot cache in parallel to the existing
cache; the difference being that it indexes the channel snapshots by
channel name instead of channel uniqueid.
Review: https://reviewboard.asterisk.org/r/2576
........
r390250 | kmoore | 2013-05-31 09:41:10 -0300 (Fri, 31 May 2013) | 8 lines
Remove remnant of snapshot blob JSON types
Remove usage of the once-mandatory snapshot blob type field, refactor
confbridge stasis messages accordingly, and remove
ast_bridge_blob_json_type().
Review: https://reviewboard.asterisk.org/r/2575/
........
r390268 | qwell | 2013-05-31 11:36:08 -0300 (Fri, 31 May 2013) | 7 lines
Replace ast_manager_publish_message() with a more useful version.
It's much easier to just create a blob of the message. Convert some AMI events
to use it.
Review: https://reviewboard.asterisk.org/r/2577/
........
r390289 | rmudgett | 2013-05-31 12:34:20 -0300 (Fri, 31 May 2013) | 15 lines
Fixup hold/unhold with attended and blind transfers.
* DTMF attended and blind transfers have hold/unhold behavior restored.
* External attended and blind transfers unhold the transfered party when
the transfer is initiated.
* Made prohibit blind transferring a bridge marked as masquerade only.
(ConfBridge bridges)
* Made running an application or playing a file inside a bridge post the
hold/unhold messages if MOH is requested.
Review: https://reviewboard.asterisk.org/r/2574/
........
r390291 | rmudgett | 2013-05-31 13:15:32 -0300 (Fri, 31 May 2013) | 4 lines
Remove ast_channel_bridge() and associated code called only by it.
* Added some more BUGBUG notes.
........
r390317 | kmoore | 2013-05-31 16:00:51 -0300 (Fri, 31 May 2013) | 6 lines
Refactor code and fix a reference leak
Refactor some channel blob publishing code to use
ast_channel_publish_blob now that it is available and fix a JSON
reference leak that was occurring during varset publishing.
........
r390352 | dlee | 2013-06-03 12:57:42 -0300 (Mon, 03 Jun 2013) | 14 lines
Correct autoconf script for finding UUID support.
The library that provides UUID support varies greatly from system to
system. On most Linux distros, it's in libuuid. On OpenBSD, it's in
libe2fs-uuid. On OS X, it is in libsystem.
This patch plays hide-and-seek with UUID support, looking for it in the
three places we know about. It also corrects the Makefile so that it uses
the configured library name and include path.
(closes issue ASTERISK-21816)
Reported by: Brad Latus (snuffy)
Tested by: Brad Latus (snuffy)
........
r390398 | dlee | 2013-06-04 12:55:19 -0300 (Tue, 04 Jun 2013) | 1 line
Corrected the docs on ast_manager_event_blob_create
........
r390439 | rmudgett | 2013-06-04 19:51:04 -0300 (Tue, 04 Jun 2013) | 1 line
Simple lock, assignment, unlock sandwich optimization.
........
r390440 | rmudgett | 2013-06-04 19:55:46 -0300 (Tue, 04 Jun 2013) | 1 line
Add BUGBUG comment.
........
r390472 | dlee | 2013-06-05 11:47:30 -0300 (Wed, 05 Jun 2013) | 12 lines
Fixed a consistency problem with channel snapshot and endpoint state.
When channels are added to an endpoint, the code originally posted a channel
snapshot to the endoint's topic directly. Turns out, this is a bad idea.
This causes the endpoint to see an inconsistent view of the channel, since it
will later receive in-flight messages with old channel snapshots.
This patch instead just publishes channel state immediately after setting up
the forward to the endpoint's topic. This gives the endpoints a consistent
view of the channel's state.
........
r390473 | file | 2013-06-05 11:50:46 -0300 (Wed, 05 Jun 2013) | 3 lines
Publish the channel state snapshot *before* calling device state so a device state producer can use
an up to date snapshot.
........
r390510 | mmichelson | 2013-06-05 15:07:23 -0300 (Wed, 05 Jun 2013) | 7 lines
Change the remove_on_pull flag on ast_bridge_hook to be a set of flags.
This change is used to make bridge hook removal more generic. This way,
depending on the circumstance, the appropriate bridge hooks may be
removed.
........
r390525 | mmichelson | 2013-06-05 15:21:19 -0300 (Wed, 05 Jun 2013) | 3 lines
Give the AST_BRIDGE_HOOK_REMOVE_ON_PULL a legitimate value.
........
r390550 | mmichelson | 2013-06-05 16:19:48 -0300 (Wed, 05 Jun 2013) | 3 lines
Remove remaining traces of remove_on_pull from hooks and hook APIs.
........
r390584 | dlee | 2013-06-05 18:14:03 -0300 (Wed, 05 Jun 2013) | 10 lines
Fixed refcounting problems with chanspy AMI support.
The ast_multi_channel_blob_get_channel function does not bump the refcount on
the channel snapshot that it returns. This is typical for Stasis message
payloads, since being immutable means that the object won't get unreffed out
from underneath you.
The manager code for chanspy was unreffing the snapshots it got out of the
multi-channel blob, which was one unref too many.
........
r390585 | dlee | 2013-06-05 18:14:46 -0300 (Wed, 05 Jun 2013) | 1 line
Corrected comment on stasis_cache_get
........
r390612 | rmudgett | 2013-06-05 20:29:43 -0300 (Wed, 05 Jun 2013) | 1 line
Make local channels use ast_channel_move() instead of the inlined version.
........
r390613 | rmudgett | 2013-06-05 21:16:23 -0300 (Wed, 05 Jun 2013) | 8 lines
Misc core external attended transfer fixes.
* Fix external attended transfer bridge move/swap method. One of the
transferrer channels was not kicked out of the bridge.
* Fix several off-nominal extended attended transfer paths. Mainly the
channels involved needed to be hung up or kicked out of the bridge.
........
r390639 | rmudgett | 2013-06-05 22:52:05 -0300 (Wed, 05 Jun 2013) | 1 line
Add a BUGBUG note.
........
r390669 | jrose | 2013-06-06 15:21:18 -0300 (Thu, 06 Jun 2013) | 3 lines
Parking: Enable code responsible for intercepting park exten transfers
........
r390698 | qwell | 2013-06-06 16:44:45 -0300 (Thu, 06 Jun 2013) | 4 lines
Convert message_router routes to ao2. Add support for removal.
Review: https://reviewboard.asterisk.org/r/2591/
........
r390701 | qwell | 2013-06-06 16:51:12 -0300 (Thu, 06 Jun 2013) | 7 lines
Split AGI manager events, to remove SubEvent field.
This moves them to stasis, in the process.
(closes issue ASTERISK-21470)
Review: https://reviewboard.asterisk.org/r/2587/
........
r390728 | kmoore | 2013-06-06 17:30:56 -0300 (Thu, 06 Jun 2013) | 1 line
Fix documentation that was in review during the great suffix/prefix swap
........
r390729 | qwell | 2013-06-06 17:32:15 -0300 (Thu, 06 Jun 2013) | 4 lines
Remove props that people will yell at me for.
I'm sorry I broke automerge. :(
........
r390730 | kmoore | 2013-06-06 17:37:48 -0300 (Thu, 06 Jun 2013) | 4 lines
Fix documentation generation
Regression from r390701
........
r390733 | rmudgett | 2013-06-06 17:47:10 -0300 (Thu, 06 Jun 2013) | 4 lines
* Fix a couple missed hook installs that need AST_BRIDGE_HOOK_REMOVE_ON_PULL.
* Rename some hook flag parameters to remove_flags.
........
r390734 | rmudgett | 2013-06-06 17:50:25 -0300 (Thu, 06 Jun 2013) | 1 line
Fix compiler warning.
........
r390751 | mmichelson | 2013-06-06 18:40:35 -0300 (Thu, 06 Jun 2013) | 21 lines
Refactor the features configuration scheme.
Features configuration is handled in its own API in
features_config.h and features_config.c. This way, features
configuration is accessible to anything that needs it.
In addition, features configuration has been altered to
be more channel-oriented. Most callers of features API
code will be supplying a channel so that the individual
channel's settings will be acquired rather than the global
setting.
Missing from this commit is XML documentation for the
features configuration. That will be handled in a separate
commit.
Review: https://reviewboard.asterisk.org/r/2578/
(issue ASTERISK-21542)
........
r390771 | rmudgett | 2013-06-06 19:46:54 -0300 (Thu, 06 Jun 2013) | 30 lines
Reimplement bridging and DTMF features related channel variables in the bridging core.
* The channel variable ATTENDED_TRANSFER_COMPLETE_SOUND is no longer
channel driver specific. If the channel variable is set on the
transferrer channel, the sound will be played to the target of an attended
transfer.
* The channel variable BRIDGEPEER becomes a comma separated list of peers
in a multi-party bridge. The BRIDGEPEER value can have a maximum of 10
peers listed. Any more peers in the bridge will not be included in the
list. BRIDGEPEER is not valid in holding bridges like parking since those
channels do not talk to each other even though they are in a bridge.
* The channel variable BRIDGEPVTCALLID is only valid for two party bridges
and will contain a value if the BRIDGEPEER's channel driver supports it.
* The channel variable DYNAMIC_PEERNAME is redundant with BRIDGEPEER and
is removed. The more useful DYNAMIC_WHO_ACTIVATED gives the channel name
that activated the dynamic feature.
* The channel variables DYNAMIC_FEATURENAME and DYNAMIC_WHO_ACTIVATED are
set only on the channel executing the dynamic feature. Executing a
dynamic feature on the bridge peer in a multi-party bridge will execute it
on all peers of the activating channel.
(closes issue ASTERISK-21555)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2582/
........
r390787 | mmichelson | 2013-06-06 20:32:13 -0300 (Thu, 06 Jun 2013) | 8 lines
Conditionally reject duplicate entries in applicationmap containers.
When reading from a config file, it's important to reject duplicates. Otherwise,
featuregroups will have ambiguity when pointing to applicationmap items. However,
when constructing the channel's current applicationmap, we don't care about duplicate
names since it's the DTMF that identifies a feature, not the name.
........
r390803 | rmudgett | 2013-06-06 21:33:20 -0300 (Thu, 06 Jun 2013) | 8 lines
Tweak applicationmap and featuregroup config containers.
* Change applicationmap and featuregroup to replace duplicate config items
rather than reject them.
* Remove some unneeded warning messages when getting the applicationmap
allows duplicates from DYNAMIC_FEATURES.
........
r390804 | rmudgett | 2013-06-06 22:06:49 -0300 (Thu, 06 Jun 2013) | 10 lines
Refactor chan_dahdi/sig_analog/sig_pri and chan_misdn to use the common transfer functions.
(closes issue ASTERISK-21523)
Reported by: Matt Jordan
(closes issue ASTERISK-21524)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2600/
........
r390830 | kmoore | 2013-06-07 09:56:56 -0300 (Fri, 07 Jun 2013) | 16 lines
Rework stasis cache clear events
Stasis cache clear message payloads now consist of a stasis_message
representative of the message to be cleared from the cache. This allows
multiple parallel caches to coexist and be cleared properly by the same
cache clear message even when keyed on different fields.
This change fixes a bug where multiple cache clears could be posted for
channels. The cache clear is now produced in the destructor instead of
ast_hangup.
Additionally, dummy channels are no longer capable of producing channel
snapshots.
Review: https://reviewboard.asterisk.org/r/2596
........
r390848 | jrose | 2013-06-07 12:54:26 -0300 (Fri, 07 Jun 2013) | 6 lines
app_meetme: Refactor manager events to use stasis
(closes issue ASTERISK-21467)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2564/
........
r390849 | jrose | 2013-06-07 13:07:18 -0300 (Fri, 07 Jun 2013) | 6 lines
res_parking: Automatically generate extensions, hints, etc.
(closes issue ASTERISK-21645)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2545/
........
r390864 | kmoore | 2013-06-07 13:22:24 -0300 (Fri, 07 Jun 2013) | 1 line
Ensure that all unit tests compile with the cache clear rework in place
........
r390885 | qwell | 2013-06-07 15:39:42 -0300 (Fri, 07 Jun 2013) | 5 lines
Implement ARI POST to /channels, to originate a call.
(closes issue ASTERISK-21617)
Review: https://reviewboard.asterisk.org/r/2597/
........
r390901 | qwell | 2013-06-07 16:51:19 -0300 (Fri, 07 Jun 2013) | 8 lines
Make app_queue AMI events more consistent. Give Join/Leave more useful names.
This also removes the eventwhencalled and eventmemberstatus configuration
options. These events can just be filtered via manager.conf blacklists.
(closes issue ASTERISK-21469)
Review: https://reviewboard.asterisk.org/r/2586/
........
r390920 | jrose | 2013-06-07 17:51:19 -0300 (Fri, 07 Jun 2013) | 6 lines
res_parking: Add parking_devicestate.c left out from previous commit
(issue ASTERISK-21645)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2545/
........
r390940 | rmudgett | 2013-06-07 22:12:57 -0300 (Fri, 07 Jun 2013) | 1 line
Add some bridge identifiers to some softmix messages.
........
r390956 | rmudgett | 2013-06-07 23:10:47 -0300 (Fri, 07 Jun 2013) | 1 line
The bridge uniqueid is available for softmix destructor.
........
r390957 | rmudgett | 2013-06-07 23:13:58 -0300 (Fri, 07 Jun 2013) | 1 line
Update some doxygen comments.
........
r390975 | rmudgett | 2013-06-08 02:18:22 -0300 (Sat, 08 Jun 2013) | 19 lines
Fix a crash when a bridge switches from the softmix bridge technology to another.
A three party bridge uses the softmix bridging technology. This
technology has a dedicated thread used to perform the analog mixing. When
one of these parties leaves the bridge, the bridge technology is changed
from the softmix technology to a two-party mixing technology. Changing
technologies is done by removing channels from the old technology and
adding them to the new technology. Since the remaining channels do not
leave the bridge, the softmix mixing thread could continue to process all
channels in the bridge. If the bridge code is not able to start
destruction of the softmix technology before the softmix mixing thread
wakes up, a crash happens.
* Added a stop technology callback that technologies can use to request
any helper threads to stop in preparation for being destroyed.
(closes issue AST-1156)
Reported by: John Bigelow
........
r390991 | rmudgett | 2013-06-08 03:31:50 -0300 (Sat, 08 Jun 2013) | 8 lines
Add more support for native bridging.
* Added a start technology callback that technologies can use to start
bridging operations. It is expected that native bridges will find this
useful.
* Factored out bridge_channel_complete_join().
........
r391012 | mjordan | 2013-06-08 19:09:07 -0300 (Sat, 08 Jun 2013) | 15 lines
Add backtrace generation to MALLOC_DEBUG memory corruption reports
This patch allows astmm to access the backtrace generation code in Asterisk.
When memory is allocated, a backtrace is created and stored with the memory
region that tracks the allocation. If a memory corruption is detected, the
backtrace is printed to the astmm log. The backtrace will make use of the
BETTER_BACKTRACES build option if available.
As a result, this patch moves the backtrace generation code into its own file
and uses the non-wrapped versions of the C library memory allocation routines.
This allows the memory allocation code to safely use the backtrace generation
routines without infinitely recursing.
Review: https://reviewboard.asterisk.org/r/2567
........
r391016 | mjordan | 2013-06-08 19:18:38 -0300 (Sat, 08 Jun 2013) | 5 lines
Only initialize manager_bridging during startup
This moves the initialization call behind the protection against
reloads. We don't want to re-add message router routes during
reloads.
........
r391040 | mjordan | 2013-06-09 18:11:25 -0300 (Sun, 09 Jun 2013) | 5 lines
Clean up MWI topic pool before message type destruction
Topics need to be disposed of prior to the message types that are published
on them. This includes topic pools. This prevents an assertion from being
raised on shutdown.
........
r391064 | alecdavis | 2013-06-10 04:35:06 -0300 (Mon, 10 Jun 2013) | 27 lines
IAX2: fix race condition with nativebridge transfers.
1). When touching the bridgecallno, we need to lock it.
2). stop_stuff() which calls iax2_destroy_helper()
Assumes the lock on the pvt is already held, when iax2_destroy_helper() is called.
Thus we need to lock the bridgecallno pvt before we call stop_stuff(iaxs[fr->callno]->bridgecallno);
3). When evaluating the state of 'callno->transferring' of the current leg,
we can't change it to READY unless the bridgecallno is locked.
Why, if we are interrupted by the other call leg before 'transferring = TRANSFER_RELEASED',
the interrupt will find that it is READY and that the bridgecallno is also READY so Releases the legs.
(closes issue ASTERISK-21409)
Reported by: alecdavis
Tested by: alecdavis
alecdavis (license 585)
Review https://reviewboard.asterisk.org/r/2594/
........
Merged revisions 391062 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 391063 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r391102 | alecdavis | 2013-06-10 05:30:31 -0300 (Mon, 10 Jun 2013) | 18 lines
IAX2: refactor nativebridge transfer
remove triple checking of iaxs[fr->callno]->transferring
reduce indentation.
Reported by: alecdavis
Tested by: alecdavis
alecdavis (license 585)
Review https://reviewboard.asterisk.org/r/2602/
........
Merged revisions 391065 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 391084 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r391112 | alecdavis | 2013-06-10 05:38:03 -0300 (Mon, 10 Jun 2013) | 8 lines
fix bad edit after conflict resolution
........
Merged revisions 391107 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 391111 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r391154 | alecdavis | 2013-06-10 06:33:56 -0300 (Mon, 10 Jun 2013) | 8 lines
chan_iax2: nativebridge refactor, missed unlock bridgecallno
........
Merged revisions 391143 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 391148 from http://svn.asterisk.org/svn/asterisk/branches/11
........
r391199 | kmoore | 2013-06-10 10:07:11 -0300 (Mon, 10 Jun 2013) | 23 lines
Stasis-HTTP: Flesh out bridge-related capabilities
This adds support for Stasis applications to receive bridge-related
messages when the application shows interest in a given bridge.
To supplement this work and test it, this also adds support for the
following bridge-related Stasis-HTTP functionality:
* GET stasis/bridges
* GET stasis/bridges/{bridgeId}
* POST stasis/bridges
* DELETE stasis/bridges/{bridgeId}
* POST stasis/bridges/{bridgeId}/addChannel
* POST stasis/bridges/{bridgeId}/removeChannel
Review: https://reviewboard.asterisk.org/r/2572/
(closes issue ASTERISK-21711)
(closes issue ASTERISK-21621)
(closes issue ASTERISK-21622)
[... 43882 lines stripped ...]
More information about the asterisk-commits
mailing list