[asterisk-commits] mjordan: branch 12 r397630 - /branches/12/tests/test_bucket.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Sun Aug 25 13:12:16 CDT 2013


Author: mjordan
Date: Sun Aug 25 13:12:15 2013
New Revision: 397630

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=397630
Log:
Fix bucket unit tests

After the review for buckets was completed (r2715), the handling of names in
the bucket core was deferred to the wizards. As such, the bucket unit tests
cannot expect that passing a URI with a scheme specified but no actual resource
name will automatically fail. The tests have been updated to not make this
check.

Modified:
    branches/12/tests/test_bucket.c

Modified: branches/12/tests/test_bucket.c
URL: http://svnview.digium.com/svn/asterisk/branches/12/tests/test_bucket.c?view=diff&rev=397630&r1=397629&r2=397630
==============================================================================
--- branches/12/tests/test_bucket.c (original)
+++ branches/12/tests/test_bucket.c Sun Aug 25 13:12:15 2013
@@ -170,11 +170,6 @@
 		return AST_TEST_FAIL;
 	}
 
-	if ((bucket = ast_bucket_alloc("test://"))) {
-		ast_test_status_update(test, "Allocated a bucket with no name\n");
-		return AST_TEST_FAIL;
-	}
-
 	if (!(bucket = ast_bucket_alloc("test:///tmp/bob"))) {
 		ast_test_status_update(test, "Failed to allocate bucket\n");
 		return AST_TEST_FAIL;
@@ -374,11 +369,6 @@
 
 	if ((file = ast_bucket_file_alloc(""))) {
 		ast_test_status_update(test, "Allocated a file with no URI provided\n");
-		return AST_TEST_FAIL;
-	}
-
-	if ((file = ast_bucket_file_alloc("test://"))) {
-		ast_test_status_update(test, "Allocated a file with no name\n");
 		return AST_TEST_FAIL;
 	}
 




More information about the asterisk-commits mailing list