[asterisk-commits] jrose: branch 11 r397365 - /branches/11/main/udptl.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Wed Aug 21 18:02:37 CDT 2013


Author: jrose
Date: Wed Aug 21 18:02:35 2013
New Revision: 397365

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=397365
Log:
UDPTL: Fix a regression where UDPTL won't load default settings

If the file udptl.conf is unavailable at startup, UDPTL will fail to
initialize and while it makes some noise, it isn't immediately
obvious why consumers start to fail when using it. This patch makes
UDPTL load as though an empty config was provided  when udptl is
unavailable at startup.

(closes issue ASTERISK-22349)
Reported by: Jonathan Rose
Review: https://reviewboard.asterisk.org/r/2773/

Modified:
    branches/11/main/udptl.c

Modified: branches/11/main/udptl.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/main/udptl.c?view=diff&rev=397365&r1=397364&r2=397365
==============================================================================
--- branches/11/main/udptl.c (original)
+++ branches/11/main/udptl.c Wed Aug 21 18:02:35 2013
@@ -1419,8 +1419,15 @@
 
 static void __ast_udptl_reload(int reload)
 {
+	RAII_VAR(struct udptl_config *, udptl_cfg, udptl_snapshot_alloc(), ao2_cleanup);
+
 	if (aco_process_config(&cfg_info, reload) == ACO_PROCESS_ERROR) {
-		ast_log(LOG_WARNING, "Could not reload udptl config\n");
+		if (!reload) {
+			if (!aco_set_defaults(&general_option, "general", udptl_cfg->general)) {
+				ast_log(LOG_WARNING, "Could not load udptl config; using defaults\n");
+				ao2_global_obj_replace(globals, udptl_cfg);
+			}
+		}
 	}
 }
 




More information about the asterisk-commits mailing list