[asterisk-commits] dlee: branch dlee/stasis-http r386141 - in /team/dlee/stasis-http: include/as...
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Fri Apr 19 13:00:14 CDT 2013
Author: dlee
Date: Fri Apr 19 13:00:10 2013
New Revision: 386141
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=386141
Log:
Addressed review comments
* Removed unnecessary whitespace change in utis.h
* Fixed bad whitespace in resource_channels.c
* Made doxygen comments in generated code more readable.
Modified:
team/dlee/stasis-http/include/asterisk/utils.h
team/dlee/stasis-http/res/stasis_http/resource_asterisk.h
team/dlee/stasis-http/res/stasis_http/resource_bridges.h
team/dlee/stasis-http/res/stasis_http/resource_channels.c
team/dlee/stasis-http/res/stasis_http/resource_channels.h
team/dlee/stasis-http/res/stasis_http/resource_endpoints.h
team/dlee/stasis-http/res/stasis_http/resource_events.h
team/dlee/stasis-http/res/stasis_http/resource_playback.h
team/dlee/stasis-http/res/stasis_http/resource_recordings.h
team/dlee/stasis-http/res/stasis_http/resource_sounds.h
team/dlee/stasis-http/rest-api-templates/stasis_http_resource.h.mustache
Modified: team/dlee/stasis-http/include/asterisk/utils.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/include/asterisk/utils.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/include/asterisk/utils.h (original)
+++ team/dlee/stasis-http/include/asterisk/utils.h Fri Apr 19 13:00:10 2013
@@ -932,4 +932,5 @@
auto void _dtor_ ## varname (vartype * v); \
void _dtor_ ## varname (vartype * v) { dtor(*v); } \
vartype varname __attribute__((cleanup(_dtor_ ## varname))) = (initval)
+
#endif /* _ASTERISK_UTILS_H */
Modified: team/dlee/stasis-http/res/stasis_http/resource_asterisk.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_asterisk.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_asterisk.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_asterisk.h Fri Apr 19 13:00:10 2013
@@ -46,6 +46,7 @@
};
/*!
* \brief Gets Asterisk system information.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_bridges.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_bridges.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_bridges.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_bridges.h Fri Apr 19 13:00:10 2013
@@ -44,6 +44,7 @@
};
/*!
* \brief List active bridges.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -54,6 +55,7 @@
};
/*!
* \brief Create a new bridge.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -66,6 +68,7 @@
};
/*!
* \brief Get bridge details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -78,6 +81,7 @@
};
/*!
* \brief Delete bridge.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -92,6 +96,7 @@
};
/*!
* \brief Add a channel to a bridge.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -106,6 +111,7 @@
};
/*!
* \brief Remove a channel from a bridge.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -130,6 +136,7 @@
};
/*!
* \brief Start a recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_channels.c
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_channels.c?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_channels.c (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_channels.c Fri Apr 19 13:00:10 2013
@@ -138,7 +138,7 @@
{
RAII_VAR(struct stasis_caching_topic *, caching_topic, NULL, ao2_cleanup);
RAII_VAR(struct stasis_message *, msg, NULL, ao2_cleanup);
- struct ast_channel_snapshot *snapshot;
+ struct ast_channel_snapshot *snapshot;
caching_topic = ast_channel_topic_all_cached();
if (!caching_topic) {
Modified: team/dlee/stasis-http/res/stasis_http/resource_channels.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_channels.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_channels.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_channels.h Fri Apr 19 13:00:10 2013
@@ -44,6 +44,7 @@
};
/*!
* \brief List active channels.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -60,6 +61,7 @@
};
/*!
* \brief Create a new channel (originate).
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -72,6 +74,7 @@
};
/*!
* \brief Channel details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -84,6 +87,7 @@
};
/*!
* \brief Delete (i.e. hangup) a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -102,6 +106,7 @@
};
/*!
* \brief Create a new channel (originate) and bridge to this channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -114,6 +119,7 @@
};
/*!
* \brief Exit application; continue execution in the dialplan.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -126,6 +132,7 @@
};
/*!
* \brief Reject a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -138,6 +145,7 @@
};
/*!
* \brief Answer a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -152,6 +160,7 @@
};
/*!
* \brief Mute a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -166,6 +175,7 @@
};
/*!
* \brief Unmute a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -178,6 +188,7 @@
};
/*!
* \brief Hold a channel.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -190,6 +201,7 @@
};
/*!
* \brief Remove a channel from hold.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -231,6 +243,7 @@
};
/*!
* \brief Start a recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_endpoints.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_endpoints.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_endpoints.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_endpoints.h Fri Apr 19 13:00:10 2013
@@ -46,6 +46,7 @@
};
/*!
* \brief List available endoints.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -58,6 +59,7 @@
};
/*!
* \brief Details for an endpoint.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_events.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_events.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_events.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_events.h Fri Apr 19 13:00:10 2013
@@ -48,6 +48,7 @@
};
/*!
* \brief WebSocket connection for events.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_playback.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_playback.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_playback.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_playback.h Fri Apr 19 13:00:10 2013
@@ -46,6 +46,7 @@
};
/*!
* \brief Get a playback's details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -58,6 +59,7 @@
};
/*!
* \brief Stop a playback.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -72,6 +74,7 @@
};
/*!
* \brief Get a playback's details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_recordings.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_recordings.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_recordings.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_recordings.h Fri Apr 19 13:00:10 2013
@@ -44,6 +44,7 @@
};
/*!
* \brief List all recordings.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -54,6 +55,7 @@
};
/*!
* \brief List recordings that are complete.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -66,6 +68,7 @@
};
/*!
* \brief Get a stored recording's details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -78,6 +81,7 @@
};
/*!
* \brief Delete a stored recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -88,6 +92,7 @@
};
/*!
* \brief List libe recordings.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -100,6 +105,7 @@
};
/*!
* \brief List live recordings.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -112,6 +118,7 @@
};
/*!
* \brief Stop a live recording and discard it.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -124,6 +131,7 @@
};
/*!
* \brief Stop a live recording and store it.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -136,6 +144,7 @@
};
/*!
* \brief Pause a live recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -148,6 +157,7 @@
};
/*!
* \brief Unpause a live recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -160,6 +170,7 @@
};
/*!
* \brief Mute a live recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -172,6 +183,7 @@
};
/*!
* \brief Unmute a live recording.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/res/stasis_http/resource_sounds.h
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/res/stasis_http/resource_sounds.h?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/res/stasis_http/resource_sounds.h (original)
+++ team/dlee/stasis-http/res/stasis_http/resource_sounds.h Fri Apr 19 13:00:10 2013
@@ -44,6 +44,7 @@
};
/*!
* \brief List all sounds.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
@@ -56,6 +57,7 @@
};
/*!
* \brief Get a sound's details.
+ *
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
Modified: team/dlee/stasis-http/rest-api-templates/stasis_http_resource.h.mustache
URL: http://svnview.digium.com/svn/asterisk/team/dlee/stasis-http/rest-api-templates/stasis_http_resource.h.mustache?view=diff&rev=386141&r1=386140&r2=386141
==============================================================================
--- team/dlee/stasis-http/rest-api-templates/stasis_http_resource.h.mustache (original)
+++ team/dlee/stasis-http/rest-api-templates/stasis_http_resource.h.mustache Fri Apr 19 13:00:10 2013
@@ -55,8 +55,8 @@
{{#notes}}
*
* {{{notes}}}
+{{/notes}}
*
-{{/notes}}
* \param headers HTTP headers
* \param args Swagger parameters
* \param[out] response HTTP response
More information about the asterisk-commits
mailing list