[asterisk-commits] mjordan: trunk r384942 - /trunk/res/

[SVN commits to the Asterisk project]

Author: mjordan
Date: Mon Apr  8 10:38:34 2013
New Revision: 384942

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=384942
Log:
Don't attempt a websocket protocol removal if res_http_websocket isn't there

This patch sets the protocols container provided by res_http_websocket to NULL
when the module gets unloaded and adds the necessary checks when adding/
removing a websocket protocol. This prevents some FRACKing on an invalid
pointer to the disposed container if a module that uses res_http_websocket is
unloaded after it.


Modified:
    trunk/res/res_http_websocket.c
    trunk/res/res_stasis_websocket.c

Modified: trunk/res/res_http_websocket.c
URL: http://svnview.digium.com/svn/asterisk/trunk/res/res_http_websocket.c?view=diff&rev=384942&r1=384941&r2=384942
==============================================================================
--- trunk/res/res_http_websocket.c (original)
+++ trunk/res/res_http_websocket.c Mon Apr  8 10:38:34 2013
@@ -122,6 +122,10 @@
 {
 	struct websocket_protocol *protocol;
 
+	if (!protocols) {
+		return -1;
+	}
+
 	ao2_lock(protocols);
 
 	/* Ensure a second protocol handler is not registered for the same protocol */
@@ -156,6 +160,10 @@
 int AST_OPTIONAL_API_NAME(ast_websocket_remove_protocol)(const char *name, ast_websocket_callback callback)
 {
 	struct websocket_protocol *protocol;
+
+	if (!protocols) {
+		return -1;
+	}
 
 	if (!(protocol = ao2_find(protocols, name, OBJ_KEY))) {
 		return -1;
@@ -670,6 +678,7 @@
 	ast_websocket_remove_protocol("echo", websocket_echo_callback);
 	ast_http_uri_unlink(&websocketuri);
 	ao2_ref(protocols, -1);
+	protocols = NULL;
 
 	return 0;
 }

Modified: trunk/res/res_stasis_websocket.c
URL: http://svnview.digium.com/svn/asterisk/trunk/res/res_stasis_websocket.c?view=diff&rev=384942&r1=384941&r2=384942
==============================================================================
--- trunk/res/res_stasis_websocket.c (original)
+++ trunk/res/res_stasis_websocket.c Mon Apr  8 10:38:34 2013
@@ -305,7 +305,7 @@
 		/* ironic */
 		return AST_MODULE_LOAD_FAILURE;
 	}
-        r |= ast_websocket_add_protocol(ws_protocol, websocket_callback);
+	r |= ast_websocket_add_protocol(ws_protocol, websocket_callback);
 	return r;
 }
 
@@ -315,12 +315,13 @@
 
 	ast_json_unref(oom_json);
 	oom_json = NULL;
-        r |= ast_websocket_remove_protocol(ws_protocol, websocket_callback);
+	r |= ast_websocket_remove_protocol(ws_protocol, websocket_callback);
 	return r;
 }
 
 AST_MODULE_INFO(ASTERISK_GPL_KEY, 0, "Stasis HTTP bindings",
                 .load = load_module,
                 .unload = unload_module,
-                .nonoptreq = "app_stasis,res_http_websocket"
+                .nonoptreq = "app_stasis,res_http_websocket",
+                .load_pri = AST_MODPRI_APP_DEPEND,
         );