[asterisk-commits] mjordan: branch 10 r372582 - in /branches/10: ./ apps/app_minivm.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Thu Sep  6 21:25:36 2012
New Revision: 372582

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=372582
Log:
Free ast_str objects when temp file fails to be created in MiniVM

The previous commit (r372554) was from a patch that was written before
r366880, which ensured that ast_str objects allocated in the sendmail
routine were free'd in off nominal paths.  This commit frees the
string objects in the off nominal path introduced in r372554.

(issue ASTERISK-17133)
Reported by: Tzafrir Cohen
........

Merged revisions 372581 from http://svn.asterisk.org/svn/asterisk/branches/1.8

Modified:
    branches/10/   (props changed)
    branches/10/apps/app_minivm.c

Propchange: branches/10/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: branches/10/apps/app_minivm.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/apps/app_minivm.c?view=diff&rev=372582&r1=372581&r2=372582
==============================================================================
--- branches/10/apps/app_minivm.c (original)
+++ branches/10/apps/app_minivm.c Thu Sep  6 21:25:36 2012
@@ -1277,6 +1277,8 @@
 		tmpfd = mkstemp(newtmp);
 		if (tmpfd < 0) {
 			ast_log(LOG_WARNING, "Failed to create temporary file for volgain: %d\n", errno);
+			ast_free(str1);
+			ast_free(str2);
 			return -1;
 		}
 		snprintf(tmpcmd, sizeof(tmpcmd), "sox -v %.4f %s.%s %s.%s", vmu->volgain, filename, format, newtmp, format);