[asterisk-commits] r374135 - svn:log

[SVN commits to the Asterisk project]

Author: seanbright
Revision: 374135
Modified property: svn:log

Modified: svn:log at Mon Oct  1 12:54:28 2012
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Mon Oct  1 12:54:28 2012
@@ -1,4 +1,22 @@
-Use ast_copy_string instead of strncpy to guarantee a NUL terminated string.
+app_queue: Support persisting and loading of long member lists.
+
+Greenlight in #asterisk brought up that he was receiving an error message "Could
+not create persistent member string, out of space" when running app_queue in
+Asterisk 10.  dump_queue_members() made an assumption that 8K would be enough to
+store the generated string, but with queues that have large member lists this is
+not always the case.  This patch removes the limitation and uses ast_str instead
+of a fixed sized buffer.
+
+The complicating factor comes from the fact that ast_db_get requires a buffer
+and buffer size argument, which doesn't let us pull back more than what we pass
+in, so I introduced a new ast_db_get_allocated() which returns an ast_strdup()'d
+copy of the value from astdb.
+
+As an aside, I did some testing on the maximum size of data that we can store in
+the BDB library we distribute and was able to store a 10MB string and retrieve
+it with no problems, so I feel this is a safe patch.
+
+Review: https://reviewboard.asterisk.org/r/2136/
 ........
 
-Merged revisions 374132 from http://svn.asterisk.org/svn/asterisk/branches/10
+Merged revisions 374132 from http://svn.asterisk.org/svn/asterisk/branches/1.8