[asterisk-commits] mmichelson: branch 11 r376089 - in /branches/11: ./ res/res_fax.c
SVN commits to the Asterisk project
asterisk-commits at lists.digium.com
Thu Nov 8 16:09:02 CST 2012
Author: mmichelson
Date: Thu Nov 8 16:08:58 2012
New Revision: 376089
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=376089
Log:
Fix a "set but not used" warning on newer gccs.
Turns out the "helpful" setting of ms and res in this
macro is completely useless after the timeout antipattern
fix.
If you're a new guy looking to write code, don't write
a macro like this one.
........
Merged revisions 376087 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........
Merged revisions 376088 from http://svn.asterisk.org/svn/asterisk/branches/10
Modified:
branches/11/ (props changed)
branches/11/res/res_fax.c
Propchange: branches/11/
------------------------------------------------------------------------------
Binary property 'branch-10-merged' - no diff available.
Modified: branches/11/res/res_fax.c
URL: http://svnview.digium.com/svn/asterisk/branches/11/res/res_fax.c?view=diff&rev=376089&r1=376088&r2=376089
==============================================================================
--- branches/11/res/res_fax.c (original)
+++ branches/11/res/res_fax.c Thu Nov 8 16:08:58 2012
@@ -1206,7 +1206,6 @@
#define GENERIC_FAX_EXEC_ERROR_QUIET(fax, chan, errorstr, reason) \
do { \
GENERIC_FAX_EXEC_SET_VARS(fax, chan, errorstr, reason); \
- res = ms = -1; \
} while (0)
#define GENERIC_FAX_EXEC_ERROR(fax, chan, errorstr, reason) \
@@ -1318,7 +1317,7 @@
{
int ms;
int timeout = RES_FAX_TIMEOUT;
- int res, chancount;
+ int chancount;
unsigned int expected_frametype = -1;
union ast_frame_subclass expected_framesubclass = { .integer = -1 };
unsigned int t38negotiated = (ast_channel_get_t38_state(chan) == T38_STATE_NEGOTIATED);
More information about the asterisk-commits
mailing list