[asterisk-commits] bebuild: tag 1.8.19.0-tc1 r375944 - /tags/1.8.19.0-tc1/

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Tue Nov 6 10:18:50 CST 2012


Author: bebuild
Date: Tue Nov  6 10:18:45 2012
New Revision: 375944

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=375944
Log:
Importing files for 1.8.19.0-tc1 release.

Added:
    tags/1.8.19.0-tc1/.lastclean   (with props)
    tags/1.8.19.0-tc1/.version   (with props)
    tags/1.8.19.0-tc1/ChangeLog   (with props)

Added: tags/1.8.19.0-tc1/.lastclean
URL: http://svnview.digium.com/svn/asterisk/tags/1.8.19.0-tc1/.lastclean?view=auto&rev=375944
==============================================================================
--- tags/1.8.19.0-tc1/.lastclean (added)
+++ tags/1.8.19.0-tc1/.lastclean Tue Nov  6 10:18:45 2012
@@ -1,0 +1,3 @@
+39
+
+

Propchange: tags/1.8.19.0-tc1/.lastclean
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: tags/1.8.19.0-tc1/.lastclean
------------------------------------------------------------------------------
    svn:keywords = none

Propchange: tags/1.8.19.0-tc1/.lastclean
------------------------------------------------------------------------------
    svn:mime-type = text/plain

Added: tags/1.8.19.0-tc1/.version
URL: http://svnview.digium.com/svn/asterisk/tags/1.8.19.0-tc1/.version?view=auto&rev=375944
==============================================================================
--- tags/1.8.19.0-tc1/.version (added)
+++ tags/1.8.19.0-tc1/.version Tue Nov  6 10:18:45 2012
@@ -1,0 +1,1 @@
+1.8.19.0-tc1

Propchange: tags/1.8.19.0-tc1/.version
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: tags/1.8.19.0-tc1/.version
------------------------------------------------------------------------------
    svn:keywords = none

Propchange: tags/1.8.19.0-tc1/.version
------------------------------------------------------------------------------
    svn:mime-type = text/plain

Added: tags/1.8.19.0-tc1/ChangeLog
URL: http://svnview.digium.com/svn/asterisk/tags/1.8.19.0-tc1/ChangeLog?view=auto&rev=375944
==============================================================================
--- tags/1.8.19.0-tc1/ChangeLog (added)
+++ tags/1.8.19.0-tc1/ChangeLog Tue Nov  6 10:18:45 2012
@@ -1,0 +1,42909 @@
+2012-11-06  Asterisk Development Team <asteriskteam at digium.com>
+
+	* Asterisk 1.8.19.0-rc1 Released.
+
+2012-11-05 22:50 +0000 [r375893]  Matthew Jordan <mjordan at digium.com>
+
+	* bridges/bridge_softmix.c, include/asterisk/timing.h,
+	  res/res_musiconhold.c, channels/chan_iax2.c,
+	  res/res_fax_spandsp.c, res/res_timing_kqueue.c, main/timing.c,
+	  main/channel.c, res/res_timing_pthread.c, res/res_timing_dahdi.c,
+	  res/res_timing_timerfd.c: Refactor ast_timer_ack to return an
+	  error and handle the error in timer users Currently, if an
+	  acknowledgement of a timer fails Asterisk will not realize that a
+	  serious error occurred and will continue attempting to use the
+	  timer's file descriptor. This can lead to situations where errors
+	  stream to the CLI/log file. This consumes significant resources,
+	  masks the actual problem that occurred (whatever caused the timer
+	  to fail in the first place), and can leave channels in odd
+	  states. This patch propagates the errors in the timing resource
+	  modules up through the timer core, and makes users of these
+	  timers handle acknowledgement failures. It also adds some
+	  defensive coding around the use of timers to prevent using bad
+	  file descriptors in off nominal code paths. Note that the patch
+	  created by the issue reporter was modified slightly for this
+	  commit and backported to 1.8, as it was originally written for
+	  Asterisk 10. (issue ASTERISK-20032) Reported by: Jeremiah Gowdy
+	  patches: jgowdy-timerfd-6-22-2012.diff uploaded by Jeremiah Gowdy
+	  (license 6358)
+
+2012-11-05 21:36 +0000 [r375862]  Richard Mudgett <rmudgett at digium.com>
+
+	* main/loader.c: Add safety NULL pointer check in module user
+	  references. Made __ast_module_user_remove() check for NULL
+	  pointers. ........ Merged revision 375860 from C.3
+
+2012-11-04 03:06 +0000 [r375727-375800]  Matthew Jordan <mjordan at digium.com>
+
+	* main/manager.c: Don't attempt to purge sessions when no sessions
+	  exist Manager's tcp/tls objects have a periodic function that
+	  purge old manager sessions periodically. During shutdown, the
+	  underlying container holding those sessions can be disposed of
+	  and set to NULL before the tcp/tls periodic function is stopped.
+	  If the periodic function fires, it will attempt to iterate over a
+	  NULL container. This patch checks for whether or not the sessions
+	  container exists before attempting to purge sessions out of it.
+	  If the sessions container is NULL, we simply return. Note that
+	  this error was also caught by the Asterisk Test Suite.
+
+	* main/manager.c: Properly clean up manager resources on exit This
+	  patch does two things: 1) It properly unregisters the manager CLI
+	  commands 2) It cleans up AMI users on exit. Prior to this patch,
+	  the AMI users were not being disposed of properly, resulting in a
+	  memory leak. (closes issue ASTERISK-20646) Reported by: Corey
+	  Farrell patches: manager_shutdown.patch uploaded by Corey Farrell
+	  (license 5909)
+
+	* main/xmldoc.c: Fix memory leak when unloading XML documentation
+	  This patch is a modified version of a patch originally committed
+	  for the Asterisk 11 branch in r375756. A portion of that patch,
+	  that fixed the memory leak during unloading XML documentation,
+	  applies to branches 1.8 and 10 as well. The patch for this issue
+	  was modified for these two branches. (issue ASTERISK-20648)
+	  Reported by: Corey Farrell Tested by: mjordan patches:
+	  xmldoc-memory_leak.patch uploaded by Corey Farrell (license 5909)
+
+	* main/cdr.c: Prevent multiple CDR batches from conflicting when
+	  scheduling the CDR write The Asterisk Test Suite caught an error
+	  condition where a scheduled CDR batch write can be deleted twice
+	  if two channels attempt to post their CDRs at the same time. The
+	  batch CDR mutex is locked while the CDRs are appended to the
+	  current batch list; however, it is unlocked prior to actually
+	  scheduling the CDR write. As such, two threads can attempt to
+	  remove the currently scheduled batch write at the same time,
+	  resulting in an assertion error. This patch extends the time that
+	  the mutex is locked to encompass actually scheduling the write.
+	  This prevents two threads from unscheduling the currently
+	  scheduled write at the same time.
+
+2012-11-03 03:11 +0000 [r375698]  Andrew Latham <lathama at gmail.com>
+
+	* README, include/asterisk/doxyref.h: Doxygen Updates Replace links
+	  to missing text files removed in the 1.6.x series with links to
+	  the wiki. Doxygen can handle URLs fine, don't atempt to quote
+	  them. Also update the wiki link in the Readme to get everyone on
+	  the same page. (issue ASTERISK-20259)
+
+2012-11-02 20:48 +0000 [r375625-375658]  Richard Mudgett <rmudgett at digium.com>
+
+	* main/channel.c, channels/chan_misdn.c, main/ccss.c: Things don't
+	  need to be that const.
+
+	* channels/misdn/isdn_lib.c, channels/misdn/isdn_lib.h: Multiple
+	  revisions 375519-375524 ........ r375519 | rmudgett | 2012-10-30
+	  16:06:15 -0500 (Tue, 30 Oct 2012) | 11 lines chan_misdn: Timer
+	  primitives must be handled first. The frm->addr is a different
+	  "address space" than the stack/instance address of other Lx
+	  primitives. The test for B channel instance address could fail.
+	  Patches: patch01_timers.diff (license #6372) patch uploaded by
+	  Guenther Kelleter JIRA ABE-2888 ........ r375520 | rmudgett |
+	  2012-10-30 16:14:58 -0500 (Tue, 30 Oct 2012) | 10 lines
+	  chan_misdn: Free memory in error paths and other memory leaks.
+	  The one line commented with BUG is not easily fixable because
+	  there is no de-init function one can call. Patches:
+	  patch02_memory.diff (license #6372) patch uploaded by Guenther
+	  Kelleter JIRA ABE-2888 ........ r375521 | rmudgett | 2012-10-30
+	  16:38:41 -0500 (Tue, 30 Oct 2012) | 14 lines chan_misdn: ISDN NT
+	  L2 de-establish/establish * An NT-PTMP cannot de/establish L2
+	  since it doesn't know the TEIs. * On NT-PTP L2 is started when L1
+	  is finally active in handle_l1. * L2 deactivation logging
+	  cleanup. * L2 aggregate link status is unknown for NT-PTMP, show
+	  as "UNKN". * Removed unused functions and code for L2 handling.
+	  Patches: patch03_L2estab.diff (license #6372) patch uploaded by
+	  Guenther Kelleter Modified JIRA ABE-2888 ........ r375522 |
+	  rmudgett | 2012-10-30 16:56:14 -0500 (Tue, 30 Oct 2012) | 22
+	  lines chan_misdn: Fix broken upper_id/lower_id usage. Sending PH
+	  prim via lower_id layer (3 or 1) simply does not work. For TE (3)
+	  it returns an error (len=-6) which is not evaluated by
+	  handle_l1(), so the L1 layer status ends up wrong. Instead PH
+	  must be sent via L4, only then does it reach L1 without an error
+	  message. And NT PH prims only reach L1 when they are sent to
+	  layer 2 id. --> use upper_id to send PH primitives. * Check for
+	  errors in PH_(DE)ACTIVATE | CONFIRM. * Debug messages are
+	  improved. * The lower_id is now not used for anything, except:
+	  Why is lower_id layer deleted when it wasn't created? I removed
+	  this code since it looks very wrong. Patches:
+	  patch04_l1activation.diff (license #6372) patch uploaded by
+	  Guenther Kelleter JIRA ABE-2888 ........ r375523 | rmudgett |
+	  2012-10-30 17:29:15 -0500 (Tue, 30 Oct 2012) | 31 lines
+	  chan_misdn: Fix loss of B channels if L1 is down. If you make 2
+	  calls out an NT PTMP port which is not connected to any phone,
+	  the B channel associated with that call becomes unusable until
+	  Asterisk is restarted. The problem is the EVENT_SETUP is queued
+	  when L1 is not up in misdn_lib_send_event(). If L1 cannot be
+	  activated the event won't be dequeued. It gets even worse when
+	  the call is hung up. The queued EVENT_SETUP will be overwritten
+	  by an EVENT_DISCONNECT. The reserved B channel then will never be
+	  freed. If later someone connects a phone to the port, L1 will
+	  eventually activate and the queued EVENT_DISCONNECT is sent down
+	  the stack. However, it is ignored because it is the wrong call
+	  state. The real fix would be that activation and queueing for a
+	  new SETUP is done by the NT stack. But since it doesn't, the
+	  workaround must be removed because it doesn't always work. Fix:
+	  The event is no longer queued but immediately sent to the stack.
+	  If L1 cannot be activated, the L3 state machine that was started
+	  by the EVENT_SETUP will do its work, i.e. a timeout will release
+	  the B channel properly. The SETUP possibly cannot be sent the
+	  first time but is resent by T303 in case L1 could be activated.
+	  Patches: patch05_bchan-loss.diff (license #6372) patch uploaded
+	  by Guenther Kelleter Modified JIRA ABE-2888 ........ r375524 |
+	  rmudgett | 2012-10-30 18:26:05 -0500 (Tue, 30 Oct 2012) | 13
+	  lines chan_misdn: Remove some calls to exit(). Try proper cleanup
+	  when something goes wrong in misdn_lib_init(). Especially do not
+	  call exit()! * Fix memory leak because stack_destroy() does not
+	  free the stack struct. Patches: patch06_cleanup-init.diff
+	  (license #6372) patch uploaded by Guenther Kelleter Modified JIRA
+	  ABE-2888 ........ Merged revisions 375519-375524 from
+	  https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
+
+2012-11-02 16:58 +0000 [r375594]  Michael L. Young <elgueromexicano at gmail.com>
+
+	* channels/chan_sip.c: Fix Wrong Result In Debug Message For SDP
+	  Origin Processing While looking at some debug logs, I noticed
+	  that it was being reported that the SDP origin line was
+	  unsupported or failed. Upon looking into this on my local
+	  machine, I found that I too was getting this debug message yet
+	  everything seemed to be getting processed properly. What was
+	  discovered is, that, the variable to determine what is displayed
+	  in the debug message for the SDP line that was processed, was not
+	  being set for the origin line when the result was successful.
+	  This patch fixes this and was tested on local machine.
+
+2012-10-31 14:23 +0000 [r375528]  Matthew Jordan <mjordan at digium.com>
+
+	* res/res_calendar_ews.c: Properly extract the Body information of
+	  an EWS calendar item Unlike all other calendar modules,
+	  res_calendar_ews fails to extract the Body information for a
+	  calendar item. This is due, in part, to a quirk in the schema in
+	  the XML - not only does a CalendarItem contain a Body element,
+	  but the CalendarItem exists as a descendant of a different Body
+	  element. The neon parser was erroneously skipping all Body
+	  elements. This patch fixes that by bypassing Body elements that
+	  are not a child of CalendarItem, and parsing the Body element out
+	  if it is a child. Note that the original patch by Terry Wilson
+	  only needed slight modifications to make it properly pull the
+	  Body information out; as such, while I've linked to the patch
+	  that I uploaded for Dmitry, I've attributed the patch to Terry.
+	  (closes issue ASTERISK-19738) Reported by: Dmitry Burilov Tested
+	  by: Dmitry Burilov patches: calendar_ews_body_2012_10_29.diff
+	  uploaded by Terry Wilson (license 6283)
+
+2012-10-30 18:48 +0000 [r375484]  Jonathan Rose <jrose at digium.com>
+
+	* apps/app_mixmonitor.c: mixmonitor: Add a test event This test
+	  event is being used to fix the mixmonitor_audiohook_inherit test.
+
+2012-10-30 02:07 +0000 [r375450]  Matthew Jordan <mjordan at digium.com>
+
+	* apps/app_queue.c: Ensure that the Queue application tracks busy
+	  members in off nominal situations There are a few code paths
+	  where the Queue application fails to count a paused or in use
+	  queue member as being 'busy'. This can cause callers to get stuck
+	  in the Queue until a paused agent unpauses themselves. (closes
+	  issue ASTERISK-20623) Reported by: Bryan Walters patches:
+	  app_queue.patch uploaded by Bryan Walters (license 5851)
+
+2012-10-29 21:01 +0000 [r375415]  Mark Michelson <mmichelson at digium.com>
+
+	* channels/chan_sip.c: Prevent resetting of NATted realtime peer
+	  address on reload. If a "sip reload" is issued for a SIP peer,
+	  then his IP address will be cleared, thus resulting in forgetting
+	  the public IP address. Asterisk will then attempt to route SIP
+	  traffic to the private IP address. The fix here is to make "sip
+	  reload" ignore realtime peers when "host = dynamic" is spotted.
+	  Realtime peers can now only have their IP address reset if they
+	  have gone from being not dynamic to being dynamic. (closes issue
+	  ASTERISK-18203) reported by daren ferreira (closes issue
+	  ASTERISK-20572) reported by JoshE Patches: fix_nat_realtime.diff
+	  uploaded by JoshE (license #6075)
+
+2012-10-29 19:26 +0000 [r375361-375388]  Richard Mudgett <rmudgett at digium.com>
+
+	* main/features.c: Fix the Park 'r' option when a channel parks
+	  itself. When a channel uses the Park appliation to park itself
+	  with the 'r' option, the channel hears music-on-hold instead of
+	  the requested ringing. * Added a missing check for the 'r' option
+	  when a channel parks itself. (closes issue ASTERISK-19382)
+	  Reported by: James Stocks Patches by: dsessions Review:
+	  https://reviewboard.asterisk.org/r/2148/
+
+	* channels/chan_dahdi.c: chan_dahdi: Fix segfault dereferencing a
+	  NULL tech_pvt. The tech support customer was using the AMI
+	  Redirect action shortly after a call was placed. While the
+	  channel tried to do an ast_read(), the masquerade resulting from
+	  the channel redirect took place. The masquerade in the middle of
+	  the ast_read() resulted in the segfault. (closes issue AST-1025)
+	  Reported by: Trey Blancher Patches: jira_ast_1025_v1.8_v2.patch
+	  (license #5621) patch uploaded by rmudgett
+
+2012-10-23 16:20 +0000 [r375272-375325]  Jonathan Rose <jrose at digium.com>
+
+	* contrib/scripts/ast_tls_cert: ast_tls_cert script: Better
+	  response for various exit conditions to openssl (closes issue
+	  ASTERISK-20260) Reported by: Daniel O'Connor Patches:
+	  ast_tls_cert-update.diff uploaded by Daniel O'Connor (license
+	  6419)
+
+	* main/app.c: core: Fix a memory leak in app.c from an early return
+	  ast_app_group_match_get_count allocates memory with the regcomp
+	  function and we previously forgot to free it when bailing out due
+	  to a regex compilation failure against category. (closes issue
+	  AST-1018) Reported by: Guenther Kelleter Patches:
+	  regcomp_memleak.diff uploaded by Guenther Kelleter (license 6372)
+
+	* codecs/gsm/src/code.c: GSM: Fix encoding problems with GSM
+	  (closes issue ASTERISK-20457) Reported by: Richard Miller
+	  Patches: code.patch uploaded by Richard Miller (license 5685)
+
+2012-10-18 21:36 +0000 [r375216-375244]  Jonathan Rose <jrose at digium.com>
+
+	* UPGRADE.txt: Correct version number in Upgrade.txt release notes
+	  pertaining to queue order Showed 1.8.17 to 1.8.18, needs to be
+	  1.8.18 to 1.8.19
+
+	* UPGRADE.txt: app_queue: add upgrade notes for 375216 Adds notes
+	  describing behavioral changes to rrmemory strategy caused by
+	  375216 (issue AST-989) Reported by: Thomas Arimont
+
+	* apps/app_queue.c: app_queue: Make ordering of rrmemory/rrordered
+	  persist over add/remove members Prior to this patch, adding,
+	  removing or reloading members to rrmemory would cause the order
+	  to become completely jumbled. Now it behaves more or less like
+	  rrordered other than the fact that it stores the members on a
+	  hash table rather than a linked list. This patch also prevents
+	  removal of members and member reloads from jumbling rrordered
+	  queues. (issue AST-989) Reported by: Thomas Arimont Review:
+	  https://reviewboard.asterisk.org/r/2164/
+
+2012-10-18 19:42 +0000 [r375189]  Richard Mudgett <rmudgett at digium.com>
+
+	* makeopts.in, Makefile, build_tools/make_version, configure,
+	  configure.ac: build_tools: Allow Asterisk to report git SHAs in
+	  version string. Make git more attractive for managing
+	  work-in-progress. Especially convenient when a potential patch
+	  set needs to be tested on multiple platforms since one can use
+	  git to keep all the test environments in sync independent of a
+	  subversion server. Now the Asterisk version will show the exact
+	  git SHA5 that was used when building (still appended by "M" if
+	  there are local modifications) from a git clone of the Asterisk
+	  repository so the developer can more easily know what is actually
+	  under test. You will now get this: $ asterisk -V Asterisk
+	  GIT-1698298 Instead of this: $ asterisk -V Asterisk
+	  UNKNOWN__and_probably_unsupported This has zero impact for those
+	  not using git with the exception of an extra test in the
+	  configure script to gather git's path. This is necessary to
+	  prevent "sudo make install" from failing since git may not be in
+	  the path in make's shell environment. (closes issue
+	  ASTERISK-20483) Reported by: Shaun Ruffell Patches:
+	  0001-build_tools-Allow-Asterisk-to-report-git-SHAs-in-ver.patch
+	  (license #5417) patch uploaded by Shaun Ruffell Modified
+
+2012-10-17 18:55 +0000 [r375146]  Kinsey Moore <kmoore at digium.com>
+
+	* main/tcptls.c: Ensure Asterisk fails TCP/TLS SIP calls when
+	  certificate checking fails When placing a call to a TCP/TLS SIP
+	  endpoint whose certificate is not signed by a configured CA
+	  certificate, Asterisk would issue a warning and continue to
+	  process the call as if there was not an issue with the
+	  certificate. Asterisk now properly fails the call if the
+	  certificate fails verification or if the certificate does not
+	  exist when certificate checking is enabled (the default
+	  behavior). (closes issue ASTERISK-20559) Reported by: kmoore
+	  Review: https://reviewboard.asterisk.org/r/2163/
+
+2012-10-16 21:41 +0000 [r375074-375111]  Walter Doekes <walter+asterisk at wjd.nu>
+
+	* channels/chan_sip.c: Fixes to the fd-oriented SIP TCP reads.
+	  Don't crash on large user input. Allow SIP headers without space.
+	  Optimize code a bit. Review:
+	  https://reviewboard.asterisk.org/r/2162
+
+	* channels/chan_sip.c: Update sip_request_call SIP dial string
+	  documentation. This was missed when merging review r1859.
+
+2012-10-16 19:13 +0000 [r375059]  Tzafrir Cohen <tzafrir.cohen at xorcom.com>
+
+	* contrib/scripts/autosupport: autosupport: fix bashism '==' is
+	  bashism (bashspecific, fails when dash is /bin/sh). Anyway, a
+	  'case' works better there. (closes issue ASTERISK-20567) Reported
+	  by: Tzafrir Cohen
+
+2012-10-15 21:00 +0000 [r375025]  Mark Michelson <mmichelson at digium.com>
+
+	* include/asterisk/strings.h, channels/chan_iax2.c,
+	  apps/app_dial.c, main/ccss.c: Fix some potential misuses of
+	  ast_str in the code. Passing an ast_str pointer by value that
+	  then calls ast_str_set(), ast_str_set_va(), ast_str_append(), or
+	  ast_str_append_va() can result in the pointer originally passed
+	  by value being invalidated if the ast_str had to be reallocated.
+	  This fixes places in the code that do this. Only the example in
+	  ccss.c could result in pointer invalidation though since the
+	  other cases use a stack-allocated ast_str and cannot be
+	  reallocated. I've also updated the doxygen in strings.h to
+	  include notes about potential misuse of the functions mentioned
+	  previously. Review: https://reviewboard.asterisk.org/r/2161
+
+2012-10-14 08:59 +0000 [r374977]  Tzafrir Cohen <tzafrir.cohen at xorcom.com>
+
+	* config.guess, config.sub: Update config.guess and config.sub:
+	  2012-10-10 Update config.guess and config.sub to revision
+	  fb456b34ef4aa02b95dc6be69aaa66fa94a844fb from the
+	  savannah.gnu.org git repo. Adds support for e.g. aarch64 (ARM
+	  64bit). config.guess:timestamp='2012-09-25'
+	  config.sub:timestamp='2012-10-10'
+
+2012-10-12 15:57 +0000 [r374905]  Mark Michelson <mmichelson at digium.com>
+
+	* include/asterisk/tcptls.h, main/tcptls.c, channels/chan_sip.c: Do
+	  not use a FILE handle when doing SIP TCP reads. This is used to
+	  solve an issue where a poll on a file descriptor does not
+	  necessarily correspond to the readiness of a FILE handle to be
+	  read. This change makes it so that for TCP connections, we do a
+	  recv() on the file descriptor instead. Because TCP does not
+	  guarantee that an entire message or even just one single message
+	  will arrive during a read, a loop has been introduced to ensure
+	  that we only attempt to handle a single message at a time. The
+	  tcptls_session_instance structure has also had an overflow buffer
+	  added to it so that if more than one TCP message arrives in one
+	  go, there is a place to throw the excess. Huge thanks goes out to
+	  Walter Doekes for doing extensive review on this change and
+	  finding edge cases where code could fail. (closes issue
+	  ASTERISK-20212) reported by Phil Ciccone Review:
+	  https://reviewboard.asterisk.org/r/2123
+
+2012-10-11 15:42 +0000 [r374843]  Matthew Jordan <mjordan at digium.com>
+
+	* main/cdr.c: Fix incorrect billing duration reported when batch
+	  mode is enabled Similar to r369351, the billing duration can be
+	  skewed when batch mode is enabled. This happened much more rarely
+	  than the duration, as it only occured when the call was answered
+	  (thereby indicating an actual answer time) and immediately hung
+	  up on (indicating a billsec of 0). Since a billing time of '0'
+	  can either mean that the call immediately ended or that the CDR
+	  was improperly answered, we have to use additional information to
+	  know whether or not we can trust the CDR billsec value. Prior to
+	  this patch, we looked to see if we had a valid answer time. If we
+	  did, and billsec was zero, we used the current time to calculate
+	  what billsec value we could from the CDR being written. If batch
+	  mode is enabled, this will incorrectly report a billsec value
+	  being much greater than the actual duration of the call. Instead
+	  of relying on the presence of an answer time to know whether or
+	  not we can re-calculate the billsec for the CDR, we now also use
+	  the presence of the CDR's end time to know if we need to
+	  re-calculate or whether we can trust the billsec value that we
+	  have. This prevents erroneous jumps in the billsec value, while
+	  still making sure that in the worst case, some billing time will
+	  be calculated. (closes issue AST-1016) Reported by: Thomas
+	  Arimont Tested by: Thomas Arimont
+
+2012-10-10 20:52 +0000 [r374686-374802]  Richard Mudgett <rmudgett at digium.com>
+
+	* apps/app_queue.c: app_queue: Made pass connected line updates
+	  from the caller to ringing queue members. Party A calls Party B
+	  Party B puts Party A on hold. Party B calls a queue. Ringing
+	  queue member D sees Party B identification. Party B transfers
+	  Party A to the queue. Queue member D does not get a connected
+	  line update for Party A. Queue member D answers the call and
+	  still sees Party B information. However, if Party A later
+	  transfers the call to Party C then queue member D gets a
+	  connected line update for Party C. * Made pass connected line
+	  updates from the caller to queue members while the queue members
+	  are ringing. (closes issue AST-1017) Reported by: Thomas Arimont
+	  (closes issue ABE-2886) Reported by: Thomas Arimont Tested by:
+	  rmudgett ........ Merged revisions 374801 from
+	  https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
+
+	* main/pbx.c: Fix execution of 'i' extension due to uninitialized
+	  variable. The fix for ASTERISK-18243 added code that could
+	  potentially use dst_exten[] uninitialized. As a result the 'i'
+	  exten may not be executed when it should. (closes issue
+	  ASTERISK-20455) Reported by: Richard Miller Patches:
+	  pbx-1.8.16.0.diff (license #5685) patch uploaded by Richard
+	  Miller Made some cosmetic modifications.
+
+	* configs/chan_dahdi.conf.sample: dahdi.conf.sample: Add
+	  description for "buffers" setting. This contains an edited
+	  version of the patch originally created by John Bigelow. (closes
+	  issue ASTERISK-14435) Reported by: John Bigelow Patches:
+	  buffers.patch (license #5091) patch uploaded by John Bigelow
+	  0001-dahdi.conf.sample-Add-description-for-buffers-settin.patch
+	  (license #5417) patch uploaded by Shaun Ruffell Modified
+
+	* pbx/pbx_spool.c: Fix deletion of unopenable spool files. If
+	  scan_service() cannot open the spool file, it logs a message
+	  saying that it will delete the file and calls remove_from_queue()
+	  to do it. However, remove_from_queue() fails to delete the spool
+	  file because struct outgoing has not yet been fully initialized.
+	  * Merged allocating a new struct outgoing and init_outgoing()
+	  into new_outgoing(). Allocation is initialization. * Made
+	  apply_outgoing() not initialize the spool filename in struct
+	  outgoing. * Made apply_outgoing() call ast_trim_blanks() and
+	  ast_skip_blanks() rather than manually inlining them. * Reduced
+	  indentation levels in apply_outgoing(). * Fixed a garbled comment
+	  in remove_from_queue(). * Reworked scan_service() to simplify it.
+	  (closes issue ASTERISK-17231) Reported by: David Chappell
+	  Patches: spool_open_failure.diff (license #4997) patch uploaded
+	  by David Chappell Started with this patch.
+
+2012-11-06  Asterisk Development Team <asteriskteam at digium.com>
+
+	* Asterisk 1.8.18.0 Released.
+
+2012-10-08  Asterisk Development Team <asteriskteam at digium.com>
+
+	* Asterisk 1.8.18.0-rc1 Released.
+
+2012-10-05 20:20 +0000 [r374570-374581]  dlee <dlee at localhost>:
+
+	* main/manager.c: I've committed too much. Reverting part of
+	  r374570.
+
+	* main/manager.c: Improve AMI long line error handling In AMI's
+	  parser, when it receives a long line (> 1024 characters), it
+	  discards that line, but continues to process the message
+	  normally. Typically, this is not a problem because a) who has
+	  lines that long and b) usually a discarded line results in an
+	  invalid message. But if that line is specifying an optional
+	  field, then the message will be processed, you get a 'Response:
+	  Success', but things don't work the way you expected them to.
+	  This patch changes the behavior when a line-too-long parse error
+	  occurs. * Changes the log message to avoid way-too-long (and
+	  truncated anyways) log messages * Adds a 'parsing' status flag to
+	  Response: Success * Sets parsing = MESSAGE_LINE_TOO_LONG if,
+	  well, a line is too long * Responds with an appropriate error if
+	  parsing != MESSAGE_OKAY (closes issue AST-961) Reported by: John
+	  Bigelow Review: https://reviewboard.asterisk.org/r/2142/
+
+2012-10-05 18:20 +0000 [r374536]  Richard Mudgett <rmudgett at digium.com>
+
+	* channels/misdn/isdn_msg_parser.c, channels/misdn/isdn_lib.c,
+	  channels/misdn/isdn_lib.h, channels/chan_misdn.c: Merged
+	  revisions 374515-374535 from
+	  https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
+	  ................ r374515 | rmudgett | 2012-10-04 17:52:36 -0500
+	  (Thu, 04 Oct 2012) | 10 lines chan_misdn: Remove some deadcode *
+	  Made setup_bc() static. Patches: patch1_unused-code.diff (license
+	  #6372) patch uploaded by Guenther Kelleter Modified JIRA ABE-2882
+	  ................ r374516 | rmudgett | 2012-10-04 18:01:01 -0500
+	  (Thu, 04 Oct 2012) | 7 lines chan_misdn: Remove unused bchan
+	  states Patches: patch2_unused-states.diff (license #6372) patch
+	  uploaded by Guenther Kelleter JIRA ABE-2882 ................
+	  r374517 | rmudgett | 2012-10-04 18:17:51 -0500 (Thu, 04 Oct 2012)
+	  | 16 lines chan_misdn: Remove unnecessary null pointer checks and
+	  checks for stack->nt * cleanup_bc() is always called with valid
+	  bc (or it would've crashed before). * Value of stack->nt is known
+	  in advance at some places. * Rename handle_event() to
+	  handle_event_te(), handle_frm() to handle_frm_te(). Patches:
+	  patch3_checks.diff (license #6372) patch uploaded by Guenther
+	  Kelleter Modified JIRA ABE-2882 ................ r374518 |
+	  rmudgett | 2012-10-04 18:21:59 -0500 (Thu, 04 Oct 2012) | 7 lines
+	  chan_misdn: Fix spelling in log messages Patches:
+	  patch4_spelling.diff (license #6372) patch uploaded by Guenther
+	  Kelleter JIRA ABE-2882 ................ r374519 | rmudgett |
+	  2012-10-04 18:31:59 -0500 (Thu, 04 Oct 2012) | 15 lines
+	  chan_misdn: Don't cleanup a bc twice. In handle_frm_te() after
+	  calling misdn_lib_send_event(bc, EVENT_RELEASE_COMPLETE) bc is
+	  emptied, cleaned and set not in use, although
+	  misdn_lib_send_event() already did the same. This is bad. When
+	  it's not in use we are not allowed to touch it. * Moved log
+	  message in front of the resulting actions and fixed it to match
+	  the case. Patches: patch5_bccleanup.diff (license #6372) patch
+	  uploaded by Guenther Kelleter JIRA ABE-2882 ................
+	  r374520 | rmudgett | 2012-10-04 18:43:56 -0500 (Thu, 04 Oct 2012)
+	  | 12 lines chan_misdn: Fix memory leaks, bc, chan not cleaned up
+	  etc., really bad stuff. * Fix return codes of cb_events() for
+	  EVENT_SETUP to use caller's cleanup mechanisms. * Move
+	  cl_queue_chan() call after bearer check. Patches:
+	  patch6_leaks.diff (license #6372) patch uploaded by Guenther
+	  Kelleter JIRA ABE-2882 ................ r374521 | rmudgett |
+	  2012-10-04 18:48:38 -0500 (Thu, 04 Oct 2012) | 11 lines
+	  chan_misdn: We must initialize cause on sending a DISCONNECT. We
+	  must initialize cause on sending a DISCONNECT, so it is later
+	  correctly indicated to ast_channel in case the answer
+	  (RELEASE/RELEASE_COMPLETE) does not include one. Patches:
+	  patch7_hangupcause.diff (license #6372) patch uploaded by
+	  Guenther Kelleter JIRA ABE-2882 ................ r374522 |
+	  rmudgett | 2012-10-04 19:03:56 -0500 (Thu, 04 Oct 2012) | 7 lines
+	  chan_misdn: Remove unused code for upqueue Patches:
+	  patch8_unused-upqueue.diff (license #6372) patch uploaded by
+	  Guenther Kelleter JIRA ABE-2882 ................ r374523 |
+	  rmudgett | 2012-10-04 19:11:50 -0500 (Thu, 04 Oct 2012) | 7 lines
+	  chan_misdn: Improve debugging (port number, messages fixed, dups
+	  removed) Patches: patch9_debug.diff (license #6372) patch
+	  uploaded by Guenther Kelleter JIRA ABE-2882 ................
+	  r374533 | rmudgett | 2012-10-05 12:17:18 -0500 (Fri, 05 Oct 2012)
+	  | 8 lines chan_misdn: Better debug: we can print_bc_info even if
+	  there's no ast leg. Patches: patch10_debug-bc-2.diff (license
+	  #6372) patch uploaded by Guenther Kelleter Modified. JIRA
+	  ABE-2882 ................ r374534 | rmudgett | 2012-10-05
+	  12:34:10 -0500 (Fri, 05 Oct 2012) | 16 lines chan_misdn:
+	  setup_bc() is called too early for an incoming SETUP on TE. This
+	  prevents the B channel from being setup for HDLC mode when
+	  requested by the bearer capability and config option hdlc=yes. It
+	  violates ETS300102 Ch.5.2.3.2: "The user, in any case, must not
+	  connect to the channel until a CONNECT ACKNOWLEDGE message has
+	  been received." * Call setup_bc() on receipt of
+	  CONNECT_ACKNOWLEGDE for PTMP, and on first response to SETUP for
+	  PTP. Patches: abe-2881-2.diff (license #6372) patch uploaded by
+	  Guenther Kelleter Modified. JIRA ABE-2881 ................
+	  r374535 | rmudgett | 2012-10-05 12:41:05 -0500 (Fri, 05 Oct 2012)
+	  | 2 lines chan_misdn: Remove some more deadcode. ................
+
+2012-10-04 20:15 +0000 [r374475-374479]  Alec L Davis <sivad.a at paradise.net.nz>
+
+	* CHANGES, main/dsp.c, configs/dsp.conf.sample: dsp.c User
+	  Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END Instead of
+	  a recompile, allow values to be adjusted in dsp.conf For binary
+	  distributions allows easy adjustment for wobbly GSM calls, and
+	  other reasons. Defaults to DTMF_HITS_TO_BEGIN=2 and
+	  DTMF_MISSES_TO_END=3 (closes issue ASTERISK-17493) Tested by:
+	  alecdavis alecdavis (license 585) Review
+	  https://reviewboard.asterisk.org/r/2144/
+
+	* main/dsp.c: dsp.c fix incorrect DTMF Digit_Duration. it's always
+	  short by 'hits_to_begin*DTMF_GSIZE', or 25.5ms if hitstobegin=2
+	  (issue ASTERISK-16003) Tested by: alecdavis alecdavis (license
+	  585) Review https://reviewboard.asterisk.org/r/2145/
+
+2012-10-04 17:39 +0000 [r374456]  Joshua Colp <jcolp at digium.com>
+
+	* channels/chan_sip.c: Fix a regression from direct media ACLs
+	  where the directrtpsetup option no longer works. A check was
+	  added for direct media ACLs that immediately forbid remote
+	  bridging if there was no bridged channel. This caused
+	  directrtpsetup to no longer function as it needs this information
+	  before bridging actually occurs. Logic has now been adjusted so
+	  if there is no bridged channel a remote bridge will still be
+	  attempted. (closes issue ASTERISK-20511) Reported by: kristoff
+	  Review: https://reviewboard.asterisk.org/r/2146/
+
+2012-10-04 15:25 +0000 [r374426]  dlee <dlee at localhost>:
+
+	* main/db.c, res/res_agi.c: Fix DBDelTree error codes for AMI, CLI
+	  and AGI The AMI DBDelTree command will return Success/Key tree
+	  deleted successfully even if the given key does not exist. The
+	  CLI command 'database deltree' had a similar problem, but was
+	  saved because it actually responded with '0 database entries
+	  removed'. AGI had a slightly different error, where it would
+	  return success if the database was unavailable. This came from
+	  confusion about the ast_db_deltree retval, which is -1 in the
+	  event of a database error, or number of entries deleted
+	  (including 0 for deleting nothing). * Adds a Doxygen comment to
+	  process_db_keys explaining its retval * Changed some poorly named
+	  res variables to num_deleted * Specified specific errors when
+	  calling ast_db_deltree (database unavailable vs. entry not found
+	  vs. success) * Fixed similar bug in AGI database deltree, where
+	  'Database unavailable' results in successful result (closes issue
+	  AST-967) Reported by: John Bigelow Review:
+	  https://reviewboard.asterisk.org/r/2138/
+
+2012-10-04 04:39 +0000 [r374365-374384]  Alec L Davis <sivad.a at paradise.net.nz>
+
+	* CHANGES, main/dsp.c, configs/dsp.conf.sample: dsp.c User
+	  configuration of DTMF_NORMAL_TWIST and DTMF_REVERSE_TWIST values
+	  Asterisk's DTMF Specifications are based on AT&T specs, which may
+	  not be compatible in other countries. Various countries have
+	  different specifications for the maximum power level differences
+	  between the DTMF low group and high group of frequencies. Power
+	  level difference between frequencies for different
+	  Administrations/RPOAs NTT = Max. 5 dB AT&T = 4dB(reverse) to
+	  8dB(normal) Danish = Max. 6 dB Australian = Max. 10 dB Brazilian
+	  = Max. 9 dB ETSI = Max. 6 dB from ETSI ES 201 235-3 V1.3.1
+	  (2006-03) Now allow 4 variables to be individually configured in
+	  dsp.conf, with reasonable min/max of 2dB to 20dB. Default is AT&T
+	  specifications Add's the following variables to dsp.conf
+	  ;dtmf_normal_twist=6.31 ;dtmf_reverse_twist=2.51
+	  ;relax_dtmf_normal_twist=6.31 ;relax_dtmf_reverse_twist=3.98
+	  (closes issue ASTERISK-20442) Reported by: tbsky Tested by:
+	  tbsky,alecdavis alecdavis (license 585) Review
+	  https://reviewboard.asterisk.org/r/2141/
+
+	* main/dsp.c: _dsp_init: bring inline with trunk preparation for
+	  clean merge of DTMF TWIST patch No functional changes, just
+	  style. alecdavis (license 585) Reported by: Alec Davis Tested by:
+	  alecdavis related https://reviewboard.asterisk.org/r/2141
+
+2012-10-04 02:09 +0000 [r374177-374335]  Matthew Jordan <mjordan at digium.com>
+
+	* res/res_jabber.c: Check for presence of buddy in info/dinfo
+	  handlers The res_jabber resource module uses the ASTOBJ library
+	  for managing its ref counted objects. After calling
+	  ASTOBJ_CONTAINER_FIND to locate a buddy object, the pointer to
+	  the object has to be checked to see if the buddy existed. Prior
+	  to this patch, the buddy object was not checked for NULL; with
+	  this patch in both aji_client_info_handler and aji_dinfo_handler
+	  the pointer is checked before used and, if no buddy object was
+	  found, the handlers return an error code. This patch does not
+	  take the approach that our JID can be used to log in from another
+	  resource. If that approach is desired, an improvement could be
+	  made to this patch to create the buddy on the fly. This patch
+	  seeks only to prevent Asterisk from crashing. Note that multiple
+	  people have proposed patches for this issue; the patch being
+	  committed here is based on those. (closes issue ASTERISK-19532)
+	  Reported by: Karsten Wemheuer Tested by: Byron Clark patches:
+	  fix-jabber uploaded by Karsten Wemheuer (license #5930)
+	  xmpp_no_crash_with_ejabberd.patch uploaded by Byron Clark
+	  (license #6157) (closes issue ASTERISK-19557) Reported by:
+	  ulugutz
+
+	* main/ccss.c: Destroy the generic_monitors container after the
+	  core_instances in ccss For each item in core_instances disposed
+	  of in the shutdown of ccss, any generic monitor instances
+	  referenced by the objects will be removed from generic_monitors
+	  during their destruction. Hilarity ensues if generic_monitors no
+	  longer exists. Thanks to the Asterisk Test Suite's generic_ccss
+	  test for complaining loudly when it ran into this.
+
+	* main/asterisk.c: Ensure Shutdown AMI event is still fired during
+	  Asterisk shutdown Richard pointed out that having the manager
+	  dispose of itself gracefully during shutdown meant that the
+	  Shutdown event will no longer get fired. This patch moves the AMI
+	  event just prior to running the atexit callbacks.
+
+	* main/event.c, main/taskprocessor.c, res/res_musiconhold.c,
+	  main/cel.c, main/indications.c, main/channel.c, main/data.c,
+	  main/pbx.c, main/manager.c, main/ccss.c, main/features.c: Fix a
+	  variety of ref counting issues This patch resolves a number of

[... 42256 lines stripped ...]



More information about the asterisk-commits mailing list