[asterisk-commits] mmichelson: branch 1.8 r367027 - in /branches/1.8: channels/ main/

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Fri May 18 12:47:31 2012
New Revision: 367027

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=367027
Log:
Address MISSING_BREAK static analysis reports some more.

This addresses core findings 4 and 6.

Moises Silva helped me by stating that a break could be
safely added to the case where it is added in chan_dahdi.c

In say.c, I have added a comment indicating that static analysis
complains but that it is currently unknown if this is correct.

This fixes all core findings of this type.

(closes issue ASTERISK-19662)
reported by Matthew Jordan



Modified:
    branches/1.8/channels/chan_dahdi.c
    branches/1.8/main/say.c

Modified: branches/1.8/channels/chan_dahdi.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/channels/chan_dahdi.c?view=diff&rev=367027&r1=367026&r2=367027
==============================================================================
--- branches/1.8/channels/chan_dahdi.c (original)
+++ branches/1.8/channels/chan_dahdi.c Fri May 18 12:47:31 2012
@@ -7966,6 +7966,7 @@
 #else
 		ast_log(LOG_WARNING, "Received bits changed on %s signalling?\n", sig2str(p->sig));
 #endif
+		break;
 	case DAHDI_EVENT_PULSE_START:
 		/* Stop tone if there's a pulse start and the PBX isn't started */
 		if (!ast->pbx)

Modified: branches/1.8/main/say.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/say.c?view=diff&rev=367027&r1=367026&r2=367027
==============================================================================
--- branches/1.8/main/say.c (original)
+++ branches/1.8/main/say.c Fri May 18 12:47:31 2012
@@ -6113,6 +6113,9 @@
 				if (tm.tm_hour < 10) {
 					res = wait_file(chan, ints, "digits/0", lang);
 				}
+				/* XXX Static analysis warns of no break here. No idea if this is
+				 * correct or not
+				 */
 			case 'k':
 				/* 24-Hour */
 				if (!(tm.tm_hour % 10) || tm.tm_hour < 10) {