[asterisk-commits] rmudgett: branch 1.8 r360933 - /branches/1.8/main/logger.c

[SVN commits to the Asterisk project]

Author: rmudgett
Date: Fri Mar 30 16:26:47 2012
New Revision: 360933

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=360933
Log:
Fix logger deadlock on Asterisk shutdown.

The logger_thread() had an exit path that failed to release the logmsgs
list lock.

* Make logger_thread() exit path unlock the logmsgs list lock.

* Made ast_log() not queue any messages to the logmsgs list if the
close_logger_thread flag is set.

(issue ASTERISK-19463)
Reported by: Matt Jordan

Modified:
    branches/1.8/main/logger.c

Modified: branches/1.8/main/logger.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/main/logger.c?view=diff&rev=360933&r1=360932&r2=360933
==============================================================================
--- branches/1.8/main/logger.c (original)
+++ branches/1.8/main/logger.c Fri Mar 30 16:26:47 2012
@@ -1062,6 +1062,7 @@
 		AST_LIST_LOCK(&logmsgs);
 		if (AST_LIST_EMPTY(&logmsgs)) {
 			if (close_logger_thread) {
+				AST_LIST_UNLOCK(&logmsgs);
 				break;
 			} else {
 				ast_cond_wait(&logcond, &logmsgs.lock);
@@ -1179,8 +1180,6 @@
 	closelog(); /* syslog */
 
 	AST_RWLIST_UNLOCK(&logchannels);
-
-	return;
 }
 
 /*!
@@ -1267,15 +1266,18 @@
 	/* If the logger thread is active, append it to the tail end of the list - otherwise skip that step */
 	if (logthread != AST_PTHREADT_NULL) {
 		AST_LIST_LOCK(&logmsgs);
-		AST_LIST_INSERT_TAIL(&logmsgs, logmsg, list);
-		ast_cond_signal(&logcond);
+		if (close_logger_thread) {
+			/* Logger is either closing or closed.  We cannot log this message. */
+			ast_free(logmsg);
+		} else {
+			AST_LIST_INSERT_TAIL(&logmsgs, logmsg, list);
+			ast_cond_signal(&logcond);
+		}
 		AST_LIST_UNLOCK(&logmsgs);
 	} else {
 		logger_print_normal(logmsg);
 		ast_free(logmsg);
 	}
-
-	return;
 }
 
 #ifdef HAVE_BKTR