[asterisk-commits] jrose: branch 1.8 r359892 - /branches/1.8/apps/app_chanspy.c

[SVN commits to the Asterisk project]

Author: jrose
Date: Fri Mar 16 15:13:56 2012
New Revision: 359892

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=359892
Log:
Prevent chanspy from binding to zombie channels

This patch addresses a bug with chanspy on local channels which roughly 50% of the time
would create a situation where chanspy can latch onto a zombie channel, keeping the zombie
alive forever and causing the channel doing the spying to never be able to hang up.

(closes issue ASTERISK-19493)
Reported by: lvl
Review: https://reviewboard.asterisk.org/r/1819/

Modified:
    branches/1.8/apps/app_chanspy.c

Modified: branches/1.8/apps/app_chanspy.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/apps/app_chanspy.c?view=diff&rev=359892&r1=359891&r2=359892
==============================================================================
--- branches/1.8/apps/app_chanspy.c (original)
+++ branches/1.8/apps/app_chanspy.c Fri Mar 16 15:13:56 2012
@@ -526,7 +526,8 @@
 
 	/* We now hold the channel lock on spyee */
 
-	if (ast_check_hangup(chan) || ast_check_hangup(spyee_autochan->chan)) {
+	if (ast_check_hangup(chan) || ast_check_hangup(spyee_autochan->chan) ||
+			ast_test_flag(spyee_autochan->chan, AST_FLAG_ZOMBIE)) {
 		return 0;
 	}