[asterisk-commits] may: branch 1.8 r369146 - /branches/1.8/addons/ooh323c/src/

[SVN commits to the Asterisk project]

Author: may
Date: Wed Jun 20 12:33:12 2012
New Revision: 369146

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=369146
Log:
fix locking issue on empty callList
(issue ASTERISK-19298)
Reported by:
        Dmitry Melekhov
Patches:
        ASTERISK-18322-2.patch

Modified:
    branches/1.8/addons/ooh323c/src/ooCalls.c
    branches/1.8/addons/ooh323c/src/ooq931.c

Modified: branches/1.8/addons/ooh323c/src/ooCalls.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/addons/ooh323c/src/ooCalls.c?view=diff&rev=369146&r1=369145&r2=369146
==============================================================================
--- branches/1.8/addons/ooh323c/src/ooCalls.c (original)
+++ branches/1.8/addons/ooh323c/src/ooCalls.c Wed Jun 20 12:33:12 2012
@@ -265,14 +265,13 @@
 
 int ooRemoveCallFromList (OOH323CallData *call)
 {
-   if(!call)
+   if(!call || !gH323ep.callList)
       return OO_OK;
 
    ast_mutex_lock(&callListLock);
 
    OOTRACEINFO3("Removing call %lx: %s\n", call, call->callToken);
 
-   if (!gH323ep.callList) return OO_OK;
    if(call == gH323ep.callList)
    {
       if(!call->next)

Modified: branches/1.8/addons/ooh323c/src/ooq931.c
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/addons/ooh323c/src/ooq931.c?view=diff&rev=369146&r1=369145&r2=369146
==============================================================================
--- branches/1.8/addons/ooh323c/src/ooq931.c (original)
+++ branches/1.8/addons/ooh323c/src/ooq931.c Wed Jun 20 12:33:12 2012
@@ -2316,7 +2316,7 @@
       else
          OO_CLRFLAG(call->flags, OO_M_TUNNELING);
 
-      if(opts->disableGk)
+      if(opts->disableGk || gH323ep.gkClient == NULL)
          OO_SETFLAG(call->flags, OO_M_DISABLEGK);
       else
          OO_CLRFLAG(call->flags, OO_M_DISABLEGK);