[asterisk-commits] jrose: trunk r369644 - /trunk/apps/app_mixmonitor.c

SVN commits to the Asterisk project asterisk-commits at lists.digium.com
Thu Jul 5 13:12:00 CDT 2012


Author: jrose
Date: Thu Jul  5 13:11:58 2012
New Revision: 369644

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=369644
Log:
app_mixmonitor: Fix a reference leak in manager_mixmonitor function

Manager_mixmonitor included an early return on failed executions of mixmonitor
that would result in a leaked channel reference.

(closes issue ASTERISK-19943)
Reported by: Mark Murawski
Patches:
	mixmonitor-trunk-368394.patch uploaded by Mark Murawski (license 5791)

Modified:
    trunk/apps/app_mixmonitor.c

Modified: trunk/apps/app_mixmonitor.c
URL: http://svnview.digium.com/svn/asterisk/trunk/apps/app_mixmonitor.c?view=diff&rev=369644&r1=369643&r2=369644
==============================================================================
--- trunk/apps/app_mixmonitor.c (original)
+++ trunk/apps/app_mixmonitor.c Thu Jul  5 13:11:58 2012
@@ -1258,6 +1258,7 @@
 	ast_channel_unlock(c);
 
 	if (res) {
+		c = ast_channel_unref(c);
 		astman_send_error(s, m, "Could not start monitoring channel");
 		return AMI_SUCCESS;
 	}




More information about the asterisk-commits mailing list