[asterisk-commits] mjordan: branch 10 r354548 - in /branches/10: ./ channels/chan_sip.c

[SVN commits to the Asterisk project]

Author: mjordan
Date: Thu Feb  9 11:08:16 2012
New Revision: 354548

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=354548
Log:
Clean-up of minor formatting issues in r354542/3/4

rmudgett pointed out some formatting issues in the check-in for
ASTERISK-19290.  This cleans those up.

Review: https://reviewboards.asterisk.org/r/1722/
........

Merged revisions 354547 from http://svn.asterisk.org/svn/asterisk/branches/1.8

Modified:
    branches/10/   (props changed)
    branches/10/channels/chan_sip.c

Propchange: branches/10/
------------------------------------------------------------------------------
Binary property 'branch-1.8-merged' - no diff available.

Modified: branches/10/channels/chan_sip.c
URL: http://svnview.digium.com/svn/asterisk/branches/10/channels/chan_sip.c?view=diff&rev=354548&r1=354547&r2=354548
==============================================================================
--- branches/10/channels/chan_sip.c (original)
+++ branches/10/channels/chan_sip.c Thu Feb  9 11:08:16 2012
@@ -19324,17 +19324,19 @@
 			return;
 		}
 
-		/* If dtmf-relay or vnd.nortelnetworks.digits, parse the signal and duration; otherwise use the body as the signal */
+		/* If dtmf-relay or vnd.nortelnetworks.digits, parse the signal and duration;
+		 * otherwise use the body as the signal */
 		if (strcasecmp(c, "application/dtmf")) {
 			const char *msg_body;
 
-			if (ast_strlen_zero(msg_body = get_body(req, "Signal", '=')) && ast_strlen_zero(msg_body = get_body(req, "d", '='))) {
-				ast_log(LOG_WARNING, "Unable to retrieve DTMF signal for INFO message on call %s\n", p->callid);
+			if (   ast_strlen_zero(msg_body = get_body(req, "Signal", '='))
+				&& ast_strlen_zero(msg_body = get_body(req, "d", '='))) {
+				ast_log(LOG_WARNING, "Unable to retrieve DTMF signal for INFO message on "
+						"call %s\n", p->callid);
 				transmit_response(p, "200 OK", req);
 				return;
-			} else {
-				ast_copy_string(buf, msg_body, sizeof(buf));
-			}
+			}
+			ast_copy_string(buf, msg_body, sizeof(buf));
 
 			if (!ast_strlen_zero((msg_body = get_body(req, "Duration", '=')))) {
 				sscanf(msg_body, "%30u", &duration);
@@ -19365,7 +19367,8 @@
 		} else if ('a' <= buf[0] && buf[0] <= 'd') {
 			event = 12 + buf[0] - 'a';
 		} else if ((sscanf(buf, "%30u", &event) != 1) || event > 16) {
-			ast_log(AST_LOG_WARNING, "Unable to convert DTMF event signal code to a valid value for INFO message on call %s\n", p->callid);
+			ast_log(AST_LOG_WARNING, "Unable to convert DTMF event signal code to a valid "
+					"value for INFO message on call %s\n", p->callid);
 			transmit_response(p, "200 OK", req);
 			return;
 		}
@@ -19386,7 +19389,7 @@
 				f.subclass.integer = '*';
 			} else if (event == 11) {
 				f.subclass.integer = '#';
-			} else if (event < 16) {
+			} else {
 				f.subclass.integer = 'A' + (event - 12);
 			}
 			f.len = duration;