[asterisk-commits] mmichelson: branch 1.8 r378147 - /branches/1.8/include/asterisk/rtp_engine.h

[SVN commits to the Asterisk project]

Author: mmichelson
Date: Thu Dec 20 14:26:47 2012
New Revision: 378147

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=378147
Log:
Adjust RTP instance's available_formats callback to return the correct type.

The RTP engine public function that gets the available formats expects a
format_t to be returned; however when calling into an RTP instance's
callback to get the available formats, the callback returned an int.

This never was noticed in Asterisk because the two RTP engines included
do not provide an available_formats callback.

This introduces an API change, and the proposal for this change was brought
up on the Asterisk developers mailing list [1]. There was no public objection
to this change, so it is now being put in.

(closes AST-1054)
reported by Doug Bailey

[1] http://lists.digium.com/pipermail/asterisk-dev/2012-December/058058.html


Modified:
    branches/1.8/include/asterisk/rtp_engine.h

Modified: branches/1.8/include/asterisk/rtp_engine.h
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/include/asterisk/rtp_engine.h?view=diff&rev=378147&r1=378146&r2=378147
==============================================================================
--- branches/1.8/include/asterisk/rtp_engine.h (original)
+++ branches/1.8/include/asterisk/rtp_engine.h Thu Dec 20 14:26:47 2012
@@ -374,7 +374,7 @@
 	/*! Callback to request that the RTP engine send a STUN BIND request */
 	void (*stun_request)(struct ast_rtp_instance *instance, struct ast_sockaddr *suggestion, const char *username);
 	/*! Callback to get the transcodeable formats supported */
-	int (*available_formats)(struct ast_rtp_instance *instance, format_t to_endpoint, format_t to_asterisk);
+	format_t (*available_formats)(struct ast_rtp_instance *instance, format_t to_endpoint, format_t to_asterisk);
 	/*! Callback to send CNG */
 	int (*sendcng)(struct ast_rtp_instance *instance, int level);
 	/*! Linked list information */