[asterisk-commits] mjordan: branch 1.8 r364277 - /branches/1.8/include/asterisk/time.h

[SVN commits to the Asterisk project]

Author: mjordan
Date: Fri Apr 27 14:26:37 2012
New Revision: 364277

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=364277
Log:
Prevent overflow in calculation in ast_tvdiff_ms on 32-bit machines

The method ast_tvdiff_ms attempts to calculate the difference, in milliseconds,
between two timeval structs, and return the difference in a 64-bit integer.
Unfortunately, it assumes that the long tv_sec/tv_usec members in the timeval
struct are large enough to hold the calculated values before it returns.  On
64-bit machines, this might be the case, as a long may be 64-bits.  On 32-bit
machines, however, a long may be less (32-bits), in which case, the calculation
can overflow.

This overflow caused significant problems in MixMonitor, which uses the method
to determine if an audio factory, which has not presented audio to an audiohook,
is merely late in providing said audio or will never provide audio.  In an
overflow situation, the audiohook would incorrectly determine that an audio
factory that will never provide audio is merely late instead.  This led to
situations where a MixMonitor never recorded any audio.  Note that this happened
most frequently when that MixMonitor was started by the ConfBridge application
itself, or when the MixMonitor was attached to a Local channel.

(issue ASTERISK-19497)
Reported by: Ben Klang
Tested by: Ben Klang
Patches:
  32-bit-time-overflow-10-2012-04-26.diff (license #6283) by mjordan

(closes issue ASTERISK-19727)
Reported by: Mark Murawski
Tested by: Michael L. Young
Patches:
  32-bit-time-overflow-2012-04-27.diff (license #6283) by mjordan)

(closes issue ASTERISK-19471)
Reported by: feyfre
Tested by: feyfre

(issue ASTERISK-19426)
Reported by: Johan Wilfer

Review: https://reviewboard.asterisk.org/r/1889/

Modified:
    branches/1.8/include/asterisk/time.h

Modified: branches/1.8/include/asterisk/time.h
URL: http://svnview.digium.com/svn/asterisk/branches/1.8/include/asterisk/time.h?view=diff&rev=364277&r1=364276&r2=364277
==============================================================================
--- branches/1.8/include/asterisk/time.h (original)
+++ branches/1.8/include/asterisk/time.h Fri Apr 27 14:26:37 2012
@@ -83,8 +83,9 @@
 	   is handled for positive and negative numbers, by ensuring
 	   that the divisor is always positive
 	*/
-	return  ((end.tv_sec - start.tv_sec) * 1000) +
-		(((1000000 + end.tv_usec - start.tv_usec) / 1000) - 1000);
+	int64_t sec_dif = (int64_t)(end.tv_sec - start.tv_sec) * 1000;
+	int64_t usec_dif = (1000000 + end.tv_usec - start.tv_usec) / 1000 - 1000;
+	return  sec_dif + usec_dif;
 }
 )